encode environ before getting length to fix environ_sizes_get breaking on unicode

progrium · web-flow · commit 1d0b60c600ee · 2025-03-11T14:42:30.000-07:00
diff --git a/src/wasi.ts b/src/wasi.ts
@@ -105,7 +105,7 @@ export default class WASI {
         buffer.setUint32(environ_count, self.env.length, true);
         let buf_size = 0;
         for (const environ of self.env) {
-          buf_size += environ.length + 1;
+          buf_size += new TextEncoder().encode(environ).length + 1;
         }
         buffer.setUint32(environ_size, buf_size, true);
         debug.log(

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ export default class WASI {`
`105`	`105`	`buffer.setUint32(environ_count, self.env.length, true);`
`106`	`106`	`let buf_size = 0;`
`107`	`107`	`for (const environ of self.env) {`
`108`		`- buf_size += environ.length + 1;`
	`108`	`+ buf_size += new TextEncoder().encode(environ).length + 1;`
`109`	`109`	`}`
`110`	`110`	`buffer.setUint32(environ_size, buf_size, true);`
`111`	`111`	`debug.log(`