Skip to content

FromJSON URI use parseURIReference #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FromJSON URI use parseURIReference #1144

wants to merge 1 commit into from

Conversation

seanhess
Copy link

@seanhess seanhess commented Aug 4, 2025

Right now, the FromJSON instance for Network.URI.URI doesn't round-trip for relative URIs.

> import Network.URI
> import Data.Aeson 
> let mu :: Maybe URI = parseURIReference "/"
> print mu
Just /

> encode mu
"\"/\""

> decode @URI $ encode mu
Nothing

This PR switches the FromJSON instance to use URI.parseURIReference instead of URI.parseURI. The latter fails with Nothing for relative URIs.

@seanhess
FromJSON URI use parseURIReference
7ba10f8 
Support round-trip reference (local) uris
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanhess