Skip to content

Commit 59229c2

Browse files
committed
Use Data.Char.{chr,ord} qualified in generated code
1 parent 3e91a9c commit 59229c2

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*.dyn_o
77
*.info
88
/.ghc.environment.*
9-
/data/
109
/dist
1110
/dist-newstyle
1211
/examples/*.alex.hs

data/AlexTemplate.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ alex_scan_tkn user__ orig_input len input__ s last_acc =
146146
Nothing -> (new_acc, input__)
147147
Just (c, new_input) ->
148148
#ifdef ALEX_DEBUG
149-
Debug.Trace.trace ("State: " ++ show IBOX(s) ++ ", char: " ++ show c ++ " " ++ (show . chr . fromIntegral) c) $
149+
Debug.Trace.trace ("State: " ++ show IBOX(s) ++ ", char: " ++ show c ++ " " ++ (show . Data.Char.chr . fromIntegral) c) $
150150
#endif
151151
case fromIntegral c of { IBOX(ord_c) ->
152152
let

data/AlexWrappers.hs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,28 +17,25 @@ import Data.Word (Word8)
1717
#if defined(ALEX_BASIC_BYTESTRING) || defined(ALEX_POSN_BYTESTRING) || defined(ALEX_MONAD_BYTESTRING)
1818

1919
import Data.Int (Int64)
20-
import qualified Data.Char
2120
import qualified Data.ByteString.Lazy as ByteString
2221
import qualified Data.ByteString.Internal as ByteString (w2c)
2322

2423
#elif defined(ALEX_STRICT_BYTESTRING)
2524

26-
import qualified Data.Char
2725
import qualified Data.ByteString as ByteString
2826
import qualified Data.ByteString.Internal as ByteString hiding (ByteString)
2927
import qualified Data.ByteString.Unsafe as ByteString
3028

3129
#else
3230

33-
import Data.Char (ord)
3431
import qualified Data.Bits
3532

3633
-- | Encode a Haskell String to a list of Word8 values, in UTF8 format.
3734
utf8Encode :: Char -> [Word8]
3835
utf8Encode = uncurry (:) . utf8Encode'
3936

4037
utf8Encode' :: Char -> (Word8, [Word8])
41-
utf8Encode' c = case go (ord c) of
38+
utf8Encode' c = case go (Data.Char.ord c) of
4239
(x, xs) -> (fromIntegral x, map fromIntegral xs)
4340
where
4441
go oc

src/Main.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,7 @@ always_imports :: [String]
401401
always_imports =
402402
[ "#include \"ghcconfig.h\""
403403
, "import qualified Data.Array"
404+
, "import qualified Data.Char"
404405
]
405406

406407
import_glaexts :: [String]
@@ -437,8 +438,7 @@ import_glaexts =
437438

438439
import_debug :: [String]
439440
import_debug =
440-
[ "import Data.Char (chr)"
441-
, "import qualified Debug.Trace"
441+
[ "import qualified Debug.Trace"
442442
]
443443

444444
templateDir :: IO FilePath -> [CLIFlags] -> IO FilePath

0 commit comments

Comments
 (0)