Move unique duplicates to own test

Author: philderbeast

cabal-testsuite/PackageTests/ConditionalAndImport/cabal.out

@@ -194,261 +194,6 @@ Could not resolve dependencies:
       (constraint from oops-0.project requires ==1.4.3.0)
 [__1] fail (backjumping, conflict set: hashable, oops)
 After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: hashable (3), oops (2)
-# checking that we detect when the same config is imported via many different paths
-# cabal v2-build
-Warning: 2 imports of yops-4.config;
-  yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-0.project
-  yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Warning: 2 imports of yops-6.config;
-  yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-0.project
-  yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Warning: 2 imports of yops-8.config;
-  yops-8.config
-    imported by: yops/yops-7.config
-    imported by: yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-0.project
-  yops-8.config
-    imported by: yops/yops-7.config
-    imported by: yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Warning: 2 imports of yops/yops-3.config;
-  yops/yops-3.config
-    imported by: yops-0.project
-  yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Warning: 2 imports of yops/yops-5.config;
-  yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-0.project
-  yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Warning: 2 imports of yops/yops-7.config;
-  yops/yops-7.config
-    imported by: yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-0.project
-  yops/yops-7.config
-    imported by: yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Warning: 2 imports of yops/yops-9.config;
-  yops/yops-9.config
-    imported by: yops-8.config
-    imported by: yops/yops-7.config
-    imported by: yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-0.project
-  yops/yops-9.config
-    imported by: yops-8.config
-    imported by: yops/yops-7.config
-    imported by: yops-6.config
-    imported by: yops/yops-5.config
-    imported by: yops-4.config
-    imported by: yops/yops-3.config
-    imported by: yops-2.config
-    imported by: yops/yops-1.config
-    imported by: yops-0.project
-Up to date
-# checking that we detect when the same config is imported via many different paths
-# cabal v2-build
-Warning: 10 imports of https://www.stackage.org/lts-21.25/cabal.config;
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops-8.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-  https://www.stackage.org/lts-21.25/cabal.config
-    imported by: woops/woops-9.config
-    imported by: woops-8.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops-4.config;
-  woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-0.project
-  woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops-6.config;
-  woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-0.project
-  woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops-8.config;
-  woops-8.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-0.project
-  woops-8.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops/woops-3.config;
-  woops/woops-3.config
-    imported by: woops-0.project
-  woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops/woops-5.config;
-  woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-0.project
-  woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops/woops-7.config;
-  woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-0.project
-  woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Warning: 2 imports of woops/woops-9.config;
-  woops/woops-9.config
-    imported by: woops-8.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-0.project
-  woops/woops-9.config
-    imported by: woops-8.config
-    imported by: woops/woops-7.config
-    imported by: woops-6.config
-    imported by: woops/woops-5.config
-    imported by: woops-4.config
-    imported by: woops/woops-3.config
-    imported by: woops-2.config
-    imported by: woops/woops-1.config
-    imported by: woops-0.project
-Resolving dependencies...
-Build profile: -w ghc-9.4.8 -O1
-In order, the following will be built:
- - my-0.1 (lib:my) (first run)
-Configuring my-0.1...
-Preprocessing library for my-0.1...
-Building library for my-0.1...
 # checking bad conditional
 # cabal v2-build
 Error: [Cabal-7167]

cabal-testsuite/PackageTests/ConditionalAndImport/cabal.test.hs

@@ -133,41 +133,6 @@ main = cabalTest . withRepo "repo" . recordMode RecordMarked $ do
   readFileVerbatim "oops.expect.txt"
     >>= flip (assertOn isInfixOf multilineNeedleHaystack) oopsing . normalizePathSeparators
 
-  -- The project is named yops as it is like hops but with y's for forks.
-  -- +-- yops-0.project
-  --  +-- yops/yops-1.config
-  --   +-- yops-2.config
-  --    +-- yops/yops-3.config
-  --     +-- yops-4.config
-  --      +-- yops/yops-5.config
-  --       +-- yops-6.config
-  --        +-- yops/yops-7.config
-  --         +-- yops-8.config
-  --          +-- yops/yops-9.config (no further imports)
-  --  +-- yops/yops-3.config
-  --   +-- yops-4.config
-  --    +-- yops/yops-5.config
-  --     +-- yops-6.config
-  --      +-- yops/yops-7.config
-  --       +-- yops-8.config
-  --        +-- yops/yops-9.config (no further imports)
-  --  +-- yops/yops-5.config
-  --   +-- yops-6.config
-  --    +-- yops/yops-7.config
-  --     +-- yops-8.config
-  --      +-- yops/yops-9.config (no further imports)
-  --  +-- yops/yops-7.config
-  --   +-- yops-8.config
-  --    +-- yops/yops-9.config (no further imports)
-  --  +-- yops/yops-9.config (no further imports)
-  log "checking that we detect when the same config is imported via many different paths"
-  yopping <- cabal' "v2-build" [ "--project-file=yops-0.project", "--project-file-parser=legacy" ]
-  assertOutputContains "Warning: 2 imports" yopping
-
-  log "checking that we detect when the same config is imported via many different paths"
-  wooping <- cabal' "v2-build" [ "--project-file=woops-0.project", "--project-file-parser=legacy" ]
-  assertOutputContains "Warning: 10 imports" wooping
-
   log "checking bad conditional"
   badIf <- fails $ cabal' "v2-build" [ "--project-file=bad-conditional.project" ]
   assertOutputContains "Cannot set compiler in a conditional clause of a cabal project file" badIf

cabal-testsuite/PackageTests/ProjectImport/UniquePathDuplicates/cabal.test.hs

@@ -0,0 +1,45 @@
+import Test.Cabal.Prelude
+import Test.Cabal.OutputNormalizer
+import Data.Function ((&))
+import Data.Functor ((<&>))
+import Data.List (isInfixOf)
+
+main = cabalTest . withRepo "repo" . recordMode RecordMarked $ do
+  let log = recordHeader . pure
+
+  -- The project is named yops as it is like hops but with y's for forks.
+  -- +-- yops-0.project
+  --  +-- yops/yops-1.config
+  --   +-- yops-2.config
+  --    +-- yops/yops-3.config
+  --     +-- yops-4.config
+  --      +-- yops/yops-5.config
+  --       +-- yops-6.config
+  --        +-- yops/yops-7.config
+  --         +-- yops-8.config
+  --          +-- yops/yops-9.config (no further imports)
+  --  +-- yops/yops-3.config
+  --   +-- yops-4.config
+  --    +-- yops/yops-5.config
+  --     +-- yops-6.config
+  --      +-- yops/yops-7.config
+  --       +-- yops-8.config
+  --        +-- yops/yops-9.config (no further imports)
+  --  +-- yops/yops-5.config
+  --   +-- yops-6.config
+  --    +-- yops/yops-7.config
+  --     +-- yops-8.config
+  --      +-- yops/yops-9.config (no further imports)
+  --  +-- yops/yops-7.config
+  --   +-- yops-8.config
+  --    +-- yops/yops-9.config (no further imports)
+  --  +-- yops/yops-9.config (no further imports)
+  log "checking that we detect when the same config is imported via many different paths"
+  yopping <- cabal' "v2-build" [ "--project-file=yops-0.project", "--project-file-parser=legacy" ]
+  assertOutputContains "Warning: 2 imports" yopping
+
+  log "checking that we detect when the same config is imported via many different paths"
+  wooping <- cabal' "v2-build" [ "--project-file=woops-0.project", "--project-file-parser=legacy" ]
+  assertOutputContains "Warning: 10 imports" wooping
+
+  return ()

cabal-testsuite/PackageTests/ProjectImport/UniquePathDuplicates/repo/hashable-1.4.2.0/hashable.cabal

@@ -0,0 +1,3 @@
+cabal-version:      1.12
+name:               hashable
+version:            1.4.2.0

cabal-testsuite/PackageTests/ProjectImport/UniquePathDuplicates/repo/hashable-1.4.3.0/hashable.cabal

@@ -0,0 +1,3 @@
+cabal-version:      1.12
+name:               hashable
+version:            1.4.3.0

cabal-testsuite/PackageTests/ProjectImport/UniquePathDuplicates/repo/some-exe-0.0.1.0/Main.hs

@@ -0,0 +1,4 @@
+module Main where
+
+main :: IO ()
+main = putStrLn "hello world"

cabal-testsuite/PackageTests/ProjectImport/UniquePathDuplicates/repo/some-exe-0.0.1.0/some-exe.cabal

@@ -0,0 +1,9 @@
+name:           some-exe
+version:        0.0.1.0
+license:        BSD3
+cabal-version:  >= 1.2
+build-type:     Simple
+
+Executable some-exe
+  main-is: Main.hs
+  build-depends: base

cabal-testsuite/PackageTests/ProjectImport/UniquePathDuplicates/with-ghc.config

@@ -0,0 +1,7 @@
+-- WARNING: Override the `with-compiler: ghc-x.y.z` of the stackage import, of
+-- https://www.stackage.org/nightly-yyyy-mm-dd/cabal.config. Otherwise tests
+-- will fail with:
+--   -Error: [Cabal-5490]
+--   -Cannot find the program 'ghc'. User-specified path 'ghc-x.y.z' does not
+--    refer to an executable and the program is not on the system path.
+with-compiler: ghc