From 7d9d53eb128a02f58b7e51678af66671c8590537 Mon Sep 17 00:00:00 2001 From: Bodigrim Date: Wed, 18 Jun 2025 23:17:16 +0100 Subject: [PATCH] Make `lukko` flag automatic and off by default The lukko package (https://hackage.haskell.org/package/lukko) was meant to be a temporary workaround, and relevant improvements have been long accessible from base:GHC.IO.Handle.Lock. As suggested at https://github.com/haskellari/lukko/issues/39#issuecomment-2571692395, let's switch the default value of the lukko flag of cabal-install from True to False. Additionally, to be on the safe side, we make it an automatic one, so that if things go terribly wrong a Hackage revision could sort it back. The same change has been implemented for the hackage-security package sometime ago in https://github.com/haskell/hackage-security/pull/322, and there seems to be no complaints. --- cabal-install/cabal-install.cabal | 4 ++-- changelog.d/pr-11003.md | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 changelog.d/pr-11003.md diff --git a/cabal-install/cabal-install.cabal b/cabal-install/cabal-install.cabal index eac396f6d0e..bc56e428dd8 100644 --- a/cabal-install/cabal-install.cabal +++ b/cabal-install/cabal-install.cabal @@ -36,8 +36,8 @@ Flag native-dns Flag lukko description: Use @lukko@ for file-locking - default: True - manual: True + default: False + manual: False flag git-rev description: include Git revision hash in version diff --git a/changelog.d/pr-11003.md b/changelog.d/pr-11003.md new file mode 100644 index 00000000000..cdab59c146c --- /dev/null +++ b/changelog.d/pr-11003.md @@ -0,0 +1,8 @@ +--- +synopsis: Make lukko flag automatic and off by default +packages: [cabal-install] +prs: 11003 +issues: 10724 +--- + +Make `lukko` flag automatic and off by default, using file locking facilities from `base:GHC.IO.Handle.Lock` and not from the `lukko` package. The change is not expected to affect anyone detrimentally, but one can set the flag on in their configuration to restore the previous behaviour.