Skip to content

Conversation

geekosaur
Copy link
Collaborator

Mostly platform changes.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur marked this pull request as ready for review July 14, 2025 17:53
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above my paygrade but I trust you.

Should we ping Julian for review?..

@ulysses4ever
Copy link
Collaborator

I am also wondering if updating this script should be a part of the release checklist...

@geekosaur
Copy link
Collaborator Author

Probably, as should updating all the files in the SPDX generator (it's got a constructor per SPDX version so a number of places need to be changed to match).

Mostly platform changes.
@geekosaur geekosaur force-pushed the ghcup-metadata-script-updates-for-3.16 branch from 88bde14 to ec28f11 Compare July 14, 2025 19:31
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasufell
Copy link
Member

This will be obsolete by #11072

@geekosaur
Copy link
Collaborator Author

No longer needed, @hasufell's release management PR subsumes it.

@geekosaur geekosaur closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants