Skip to content

Commit e75ec0c

Browse files
authored
Merge pull request #319 from hasufell/create-issues
Add GitLab issue creation to proposal process
2 parents dadd2fb + d5be1fa commit e75ec0c

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

PROPOSALS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,15 @@ request feedback on feasibility before investing time and effort in the full pro
105105
* Unless your branch is particularly big, it's advisable to squash it into
106106
a single commit. At the moment GitLab does not offer "squash-and-merge"
107107
option in UI, so this has to be maintained manually.
108+
6. after the proposal is approved, coordinate with CLC and GHC team:
109+
* CLC needs to label the proposal as "approved" and "awaits-merge"
110+
* CLC or GHC team needs to add a comment to the GHC MR "Approved by CLC in [link to the vote outcome]".
111+
* Double check that the changelog and the commit messages are in order
112+
* Raise an issue on GHC GitLab to help GHC team with progress and release tracking
113+
* The GHC MR needs to be reviewed/approved and landed. This is typically done by members of the CLC and GHC Team.
114+
* After merging, CLC needs to remove the proposal label "awaits-merge" and add "base-4.XX" (coordinate with GHC devs which base would be the first to release the change)
115+
* all changes to `base` package slated for future release should land in GHC `master` before the next major release branch is forked (also see [GHC wiki on major releases](https://gitlab.haskell.org/ghc/ghc/-/wikis/GHC-status#1-major-releases))
116+
- backports are usually reserved for security or packaging matters
108117

109118
## The "when"
110119

0 commit comments

Comments
 (0)