-
Notifications
You must be signed in to change notification settings - Fork 50
Open
Labels
blocked: waiting for upstreamProgress cannot be made until an upstream issue is resolved.Progress cannot be made until an upstream issue is resolved.
Description
copyFile opens a temporary file without setting the close-on-exec flag. So if another thread execs a process at the same time, the process can inherit an open FD to a temp file. Specifically, in withReplacementFile, it uses OS.openBinaryTempFile.
copyFileWithMetadata and copyFileToHandle had this same problem fixed in commit 0ff4e13
Metadata
Metadata
Assignees
Labels
blocked: waiting for upstreamProgress cannot be made until an upstream issue is resolved.Progress cannot be made until an upstream issue is resolved.