Scope? (add hPut, hPutStrLn, putStrLn for OsString)

[0rphee]

Hi! would this library be a good fit for this functions?

hPut :: Handle -> OsString -> IO ()
hPutStr :: Handle -> OsString -> IO ()
hPutStrLn :: Handle -> OsString -> IO ()
putStr :: OsString -> IO ()
putStrLn :: OsString -> IO ()

Here's (https://github.com/0rphee/os-string-io) a POC implementation (based on https://hackage-content.haskell.org/package/byteslice).

Also, I guess he -Ln versions should be behind a *.Word8 module like in bytestring, or under a similar scheme.

[Bodigrim]

(Not a maintainer here) It feels somewhat weird to me, what's your use case? OsString is meant to avoid encoding/decoding as much as possible, but when writing to a file a decision must be made. Would it use UTF-16 on Windows and UTF-8 elsewhere?

[0rphee]

Yes, maybe it's a little misguided. I used it for a OsString port of optparse-applicative (maybe my use of them it's naive, as I've replaced most String usage with OsString very mindlessly 0rphee/optparse-applicative@8cccd13

[hasufell]

Those functions can make sense, but I agree that they could be misleading.

One way might be to add them to an Internal module with an indication that "this might not be what you want".

[Bodigrim]

(Also file-io is a GHC boot package, it cannot easily acquire any additional dependencies such as byteslice)

[0rphee]

Those functions can make sense, but I agree that they could be misleading.

One way might be to add them to an Internal module with an indication that "this might not be what you want".

@hasufell What do you think about putting them in System.File.OsPath.Internal? and maybe change putStrLn or add variations of it for CRLF and LF? Alternatively I can think of System.File.OsPath.Internal.Compat...

(Also file-io is a GHC boot package, it cannot easily acquire any additional dependencies such as byteslice)

@Bodigrim Sorry, I didn't explain myself properly. The implementation is based on the byteslice source code, but it does not depend on it (it depends on bytestring, os-string and primitive), the whole file is here: https://github.com/0rphee/os-string-io/blob/main/src/System/OsString/IO.hs

[Bodigrim]

primitive is similarly out of question unfortunately, only what ghc-pkg list --global lists is in scope for GHC boot libraries. (It can be extended in principle, but it's quite a costly exercise)

[0rphee]

Oh, sorry for not checking. If that dependency was removed, would there be any other similar blockers?