does not respect setLocaleEncoding when opening a Handle

[joeyh]

setLocaleEncoding is supposed to set an encoding that is used by default for all opened Handles. And by default the encoding is set based on the locale settings. But file-io does not use that encoding:

ghci> System.IO.withFile ("/etc/passwd") ReadMode (\h -> print =<< hGetEncoding h)
Just UTF-8
ghci> import System.OsPath
ghci> f <- encodeFS "/etc/passwd"
ghci> System.File.OsPath.withFile f ReadMode (\h -> print =<< hGetEncoding h)
Nothing

This means that, when converting existing code from FilePath to OsPath, any use of file-io for opening a Handle that is used with String based operations risks introducing a bug.

[hasufell]

We use fdToHandle'.

That seems to be a bug in base then?

[joeyh]

It's a documented infelicity of fdToHandle that it does not do this:

-- Makes a binary Handle. This is for historical reasons; it should
-- probably be a text Handle with the default encoding and newline
-- translation instead.

The fact that fdToHandle behaves this way means that it's the responsibility of all users of it to setLocaleEncoding when appropriate.