Skip to content

Issues with test runner configuration #1397

@Bodigrim

Description

@Bodigrim

testPackage :: Verbosity -> BuildOpts -> DocInfo -> IO (Maybe String, Maybe FilePath, Maybe FilePath)
testPackage verbosity opts docInfo = do
let pkgid = docInfoPackage docInfo
testLogFile = (installDirectory opts) </> display pkgid <.> "test"
testReportFile = (installDirectory opts) </> "reports" </> display pkgid <.> "test"
testResultFile = (resultsDirectory opts) </> display pkgid <.> "test"
pkg_flags =
["all",
"--enable-coverage",
"--test-log=" ++ testReportFile,
"--test-show-details=never",
"--disable-optimization"]
notice verbosity ("Testing " ++ display pkgid)

IMO there are a few issues with this:

  • Hiding --test-show-details is very unhelpful. Presumably users are supposed to access --test-log somehow, but I cannot find any link to it in UI.
  • Why --disable-optimizations? This breaks inspection testing (fusion rules and such), here is an example: Inspection tests fail if -O0 is forced text#634
  • --enable-coverage prevents test execution for any package depending on vector (so pretty much any non-trivial package) because of
Resolving dependencies...
Error:
    Internal libraries only supported with per-component builds.
    Per-component builds were disabled because program coverage is enabled
    In the package 'vector-0.13.2.0'

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions