plugins build with 9.14

Author: wz1000

.github/workflows/supported-ghc-versions.json

@@ -1 +1 @@
-["9.12", "9.10", "9.8", "9.6"]
+["9.14", "9.12", "9.10", "9.8", "9.6"]

.github/workflows/test.yml

@@ -146,7 +146,7 @@ jobs:
         run: cabal test hls-refactor-plugin-tests || cabal test hls-refactor-plugin-tests
 
       # TODO enable when it supports 9.10
-      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
+      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.14' && matrix.ghc != '9.10.2'
         name: Test hls-floskell-plugin
         run: cabal test hls-floskell-plugin-tests || cabal test hls-floskell-plugin-tests
 
@@ -163,11 +163,11 @@ jobs:
         run: cabal test hls-eval-plugin-tests || cabal test hls-eval-plugin-tests
 
       # TODO enable when it supports 9.10
-      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
+      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.14' && matrix.ghc != '9.10.2'
         name: Test hls-splice-plugin
         run: cabal test hls-splice-plugin-tests || cabal test hls-splice-plugin-tests
 
-      - if: matrix.test && matrix.ghc != '9.12'
+      - if: matrix.test && matrix.ghc != '9.12' && matrix.ghc != '9.14'
         name: Test hls-stan-plugin
         run: cabal test hls-stan-plugin-tests || cabal test hls-stan-plugin-tests
 
@@ -196,7 +196,7 @@ jobs:
         run: cabal test hls-rename-plugin-tests || cabal test hls-rename-plugin-tests
 
       # TODO enable when it supports 9.10
-      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.10.2'
+      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.14' && matrix.ghc != '9.10.2'
         name: Test hls-hlint-plugin test suite
         run: cabal test hls-hlint-plugin-tests || cabal test hls-hlint-plugin-tests
 
@@ -233,11 +233,11 @@ jobs:
         run: cabal test hls-explicit-record-fields-plugin-tests || cabal test hls-explicit-record-fields-plugin-tests
 
       # versions need to be limited since the tests depend on cabal-fmt which only builds with ghc <9.10
-      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
+      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.14' && matrix.ghc != '9.10.2'
         name: Test hls-cabal-fmt-plugin test suite
         run: cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests || cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests
 
-      - if: matrix.test && matrix.ghc != '9.12'
+      - if: matrix.test && matrix.ghc != '9.12' && matrix.ghc != '9.14'
         name: Test hls-cabal-gild-plugin test suite
         run: cabal test hls-cabal-gild-plugin-tests --flag=isolateCabalGildTests || cabal test hls-cabal-gild-plugin-tests --flag=isolateCabalGildTests
 
@@ -246,7 +246,7 @@ jobs:
         run: cabal test hls-cabal-plugin-tests || cabal test hls-cabal-plugin-tests
 
       # TODO enable when it supports 9.10
-      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
+      - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.14' && matrix.ghc != '9.10.2'
         name: Test hls-retrie-plugin test suite
         run: cabal test hls-retrie-plugin-tests || cabal test hls-retrie-plugin-tests
 
@@ -264,7 +264,7 @@ jobs:
 
       # The plugin tutorial is only compatible with 9.6 and 9.8.
       # No particular reason, just to avoid excessive CPP.
-      - if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
+      - if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.14' && matrix.ghc != '9.10.2'
         name: Compile the plugin-tutorial
         run: cabal build plugin-tutorial
 

cabal.project

@@ -1,5 +1,5 @@
 packages:
-         -- ./
+         ./
          ./shake-bench
          ./hls-graph
          ./ghcide
@@ -133,3 +133,9 @@ if impl(ghc >= 9.14)
     th-compat:template-haskell,
     lsp-test:time,
     ghc-lib-parser:base,
+    lukko:base,
+    binary-instances:base,
+    binary-orphans:base,
+    generic-deriving:template-haskell,
+    generic-deriving:containers,
+    cabal-install-parsers:containers,

ghcide/src/Development/IDE/GHC/Compat.hs

@@ -66,6 +66,7 @@ module Development.IDE.GHC.Compat(
     simplifyExpr,
     tidyExpr,
     emptyTidyEnv,
+    tidyOpenType,
     corePrepExpr,
     corePrepPgm,
     lintInteractiveExpr,
@@ -138,6 +139,7 @@ import           Prelude                                 hiding (mod)
 
 import qualified GHC.Core.Opt.Pipeline                   as GHC
 import           GHC.Core.Tidy                           (tidyExpr)
+import           GHC.Core.TyCo.Tidy                      (tidyOpenType)
 import           GHC.CoreToStg.Prep                      (corePrepPgm)
 import qualified GHC.CoreToStg.Prep                      as GHC
 import           GHC.Driver.Hooks                        (hscCompileCoreExprHook)

haskell-language-server.cabal

@@ -353,7 +353,7 @@ library hls-class-plugin
     , deepseq
     , extra
     , ghc
-    , ghc-exactprint  >= 1.5 && < 1.13.0.0
+    , ghc-exactprint  >= 1.5 && < 1.15
     , ghcide          == 2.12.0.0
     , hls-graph
     , hls-plugin-api  == 2.12.0.0
@@ -712,7 +712,8 @@ common hlint
   -- Hlint isn't compatible with GHC 9.10, and crashes in subtle ways.
   -- See https://github.com/haskell/haskell-language-server/issues/4674
   -- for its wake of destruction.
-  if flag(hlint) && !impl(ghc ==9.10.*)
+  -- hlint depends on ghc-lib-parser which doesn't support GHC 9.14
+  if flag(hlint) && !impl(ghc ==9.10.*) && !impl(ghc >= 9.14)
     build-depends: haskell-language-server:hls-hlint-plugin
     cpp-options: -Dhls_hlint
 
@@ -721,7 +722,8 @@ library hls-hlint-plugin
   -- Hlint isn't compatible with GHC 9.10, and crashes in subtle ways.
   -- See https://github.com/haskell/haskell-language-server/issues/4674
   -- for its wake of destruction.
-  if !flag(hlint) || impl(ghc ==9.10.*)
+  -- hlint depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(hlint) || impl(ghc ==9.10.*) || impl(ghc >= 9.14)
     buildable: False
   exposed-modules:  Ide.Plugin.Hlint
   hs-source-dirs:   plugins/hls-hlint-plugin/src
@@ -771,7 +773,8 @@ test-suite hls-hlint-plugin-tests
   -- Hlint isn't compatible with GHC 9.10, and crashes in subtle ways.
   -- See https://github.com/haskell/haskell-language-server/issues/4674
   -- for its wake of destruction.
-  if !flag(hlint) || impl(ghc ==9.10.*)
+  -- hlint depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(hlint) || impl(ghc ==9.10.*) || impl(ghc >= 9.14)
     buildable: False
   type:             exitcode-stdio-1.0
   hs-source-dirs:   plugins/hls-hlint-plugin/test
@@ -1519,13 +1522,15 @@ flag fourmolu
   manual:      True
 
 common fourmolu
-  if flag(fourmolu)
+  -- fourmolu depends on ghc-lib-parser which doesn't support GHC 9.14
+  if flag(fourmolu) && !impl(ghc >= 9.14)
     build-depends: haskell-language-server:hls-fourmolu-plugin
     cpp-options: -Dhls_fourmolu
 
 library hls-fourmolu-plugin
   import:           defaults, pedantic, warnings
-  if !flag(fourmolu)
+  -- fourmolu depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(fourmolu) || impl(ghc >= 9.14)
     buildable: False
   exposed-modules:  Ide.Plugin.Fourmolu
   hs-source-dirs:   plugins/hls-fourmolu-plugin/src
@@ -1545,7 +1550,8 @@ library hls-fourmolu-plugin
 
 test-suite hls-fourmolu-plugin-tests
   import:           defaults, pedantic, test-defaults, warnings
-  if !flag(fourmolu)
+  -- fourmolu depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(fourmolu) || impl(ghc >= 9.14)
     buildable: False
   type:             exitcode-stdio-1.0
   hs-source-dirs:   plugins/hls-fourmolu-plugin/test
@@ -1573,13 +1579,15 @@ flag ormolu
   manual:      True
 
 common ormolu
-  if flag(ormolu)
+  -- ormolu depends on ghc-lib-parser which doesn't support GHC 9.14
+  if flag(ormolu) && !impl(ghc >= 9.14)
     build-depends: haskell-language-server:hls-ormolu-plugin
     cpp-options: -Dhls_ormolu
 
 library hls-ormolu-plugin
   import:           defaults, pedantic, warnings
-  if !flag(ormolu)
+  -- ormolu depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(ormolu) || impl(ghc >= 9.14)
     buildable: False
   exposed-modules:  Ide.Plugin.Ormolu
   hs-source-dirs:   plugins/hls-ormolu-plugin/src
@@ -1599,7 +1607,8 @@ library hls-ormolu-plugin
 
 test-suite hls-ormolu-plugin-tests
   import:           defaults, pedantic, test-defaults, warnings
-  if !flag(ormolu)
+  -- ormolu depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(ormolu) || impl(ghc >= 9.14)
     buildable: False
   type:             exitcode-stdio-1.0
   hs-source-dirs:   plugins/hls-ormolu-plugin/test
@@ -1628,14 +1637,16 @@ flag stylishHaskell
   manual:      True
 
 common stylishHaskell
-  if flag(stylishHaskell)
+  -- stylish-haskell depends on ghc-lib-parser which doesn't support GHC 9.14
+  if flag(stylishHaskell) && !impl(ghc >= 9.14)
     build-depends: haskell-language-server:hls-stylish-haskell-plugin
     cpp-options: -Dhls_stylishHaskell
 
 library hls-stylish-haskell-plugin
   import:           defaults, pedantic, warnings
   -- https://github.com/haskell/stylish-haskell/issues/479
-  if !flag(stylishHaskell)
+  -- stylish-haskell depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(stylishHaskell) || impl(ghc >= 9.14)
     buildable: False
   exposed-modules:  Ide.Plugin.StylishHaskell
   hs-source-dirs:   plugins/hls-stylish-haskell-plugin/src
@@ -1653,7 +1664,8 @@ library hls-stylish-haskell-plugin
 
 test-suite hls-stylish-haskell-plugin-tests
   import:           defaults, pedantic, test-defaults, warnings
-  if !flag(stylishHaskell)
+  -- stylish-haskell depends on ghc-lib-parser which doesn't support GHC 9.14
+  if !flag(stylishHaskell) || impl(ghc >= 9.14)
     buildable: False
   type:             exitcode-stdio-1.0
   hs-source-dirs:   plugins/hls-stylish-haskell-plugin/test

plugins/hls-alternate-number-format-plugin/src/Ide/Plugin/Literals.hs

@@ -66,17 +66,21 @@ getPattern :: LPat GhcPs -> Maybe Literal
 getPattern (L (locA -> (RealSrcSpan patSpan _)) pat) = case pat of
     LitPat _ lit -> case lit of
         HsInt _ val   -> fromIntegralLit patSpan val
+#if __GLASGOW_HASKELL__ < 913
         HsRat _ val _ -> fromFractionalLit patSpan val
+#endif
         _             -> Nothing
     NPat _ (L (locA -> (RealSrcSpan sSpan _)) overLit) _ _ -> fromOverLit overLit sSpan
     NPlusKPat _ _ (L (locA -> (RealSrcSpan sSpan _)) overLit1) _ _ _ -> fromOverLit overLit1 sSpan
     _ -> Nothing
 getPattern _ = Nothing
 
-fromLit :: HsLit p -> RealSrcSpan -> Maybe Literal
+fromLit :: HsLit GhcPs -> RealSrcSpan -> Maybe Literal
 fromLit lit sSpan = case lit of
         HsInt _ val   -> fromIntegralLit sSpan val
+#if __GLASGOW_HASKELL__ < 913
         HsRat _ val _ -> fromFractionalLit sSpan val
+#endif
         _             -> Nothing
 
 fromOverLit :: HsOverLit p -> RealSrcSpan -> Maybe Literal

plugins/hls-change-type-signature-plugin/src/Ide/Plugin/ChangeTypeSignature.hs

@@ -42,6 +42,10 @@ import           Development.IDE.Types.Diagnostics (_SomeStructuredMessage)
 import           Generics.SYB                      (extQ, something)
 import           GHC.Tc.Errors.Types               (ErrInfo (..),
                                                     TcRnMessageDetailed (..))
+#if MIN_VERSION_ghc(9,13,0)
+import           GHC.Tc.Errors.Ppr                 (pprErrCtxtMsg)
+import           GHC.Utils.Outputable              (vcat)
+#endif
 import qualified Ide.Logger                        as Logger
 import           Ide.Plugin.Error                  (PluginError,
                                                     getNormalizedFilePathE)
@@ -61,8 +65,13 @@ data Log
 
 instance Pretty Log where
     pretty = \case
+#if MIN_VERSION_ghc(9,13,0)
+        LogErrInfoCtxt (ErrInfo ctxt _ _) ->
+            fromSDoc (vcat $ map pprErrCtxtMsg ctxt)
+#else
         LogErrInfoCtxt (ErrInfo ctxt suppl) ->
             Logger.vcat [fromSDoc ctxt, fromSDoc suppl]
+#endif
         LogFindSigLocFailure name ->
             pretty ("Lookup signature location failure: " <> name)
         where
@@ -175,7 +184,11 @@ matchingDiagnostic ErrInfo{errInfoContext} =
         unwrapMatch (_, _, _, [name]) = Just name
         unwrapMatch _                 = Nothing
 
+#if MIN_VERSION_ghc(9,13,0)
+        errInfoTxt = printOutputable (vcat $ map pprErrCtxtMsg errInfoContext)
+#else
         errInfoTxt = printOutputable errInfoContext
+#endif
 
 -- | List of regexes that match various Error Messages
 errorMessageRegexes :: [Text]

plugins/hls-class-plugin/src/Ide/Plugin/Class/CodeAction.hs

@@ -1,3 +1,4 @@
+{-# LANGUAGE CPP             #-}
 {-# LANGUAGE GADTs           #-}
 {-# LANGUAGE LambdaCase      #-}
 {-# LANGUAGE OverloadedLists #-}
@@ -225,14 +226,18 @@ signatureToName :: InstanceBindTypeSig -> T.Text
 signatureToName sig = T.drop (T.length bindingPrefix) (printOutputable (bindName sig))
 
 -- Return [groupName text, [(methodName text, signature text)]]
-minDefToMethodGroups :: HscEnv -> TcGblEnv -> Range -> [InstanceBindTypeSig] -> BooleanFormula Name -> [MethodGroup]
+minDefToMethodGroups :: HscEnv -> TcGblEnv -> Range -> [InstanceBindTypeSig] -> ClassMinimalDef -> [MethodGroup]
 minDefToMethodGroups hsc gblEnv range sigs minDef = makeMethodGroup <$> go minDef
     where
         makeMethodGroup methodDefinitions =
             let name = mconcat $ intersperse "," $ (\x -> "'" <> x <> "'") . fst <$> methodDefinitions
             in  (name, methodDefinitions)
 
+#if __GLASGOW_HASKELL__ >= 913
+        go (Var lmn)  = pure $ makeMethodDefinitions hsc gblEnv range $ filter ((==) (printOutputable (unLoc lmn)) . signatureToName) sigs
+#else
         go (Var mn)   = pure $ makeMethodDefinitions hsc gblEnv range $ filter ((==) (printOutputable mn) . signatureToName) sigs
+#endif
         go (Or ms)    = concatMap (go . unLoc) ms
         go (And ms)   = foldr (liftA2 (<>) . go . unLoc) [[]] ms
         go (Parens m) = go (unLoc m)

plugins/hls-eval-plugin/src/Ide/Plugin/Eval/Handlers.hs

@@ -87,6 +87,11 @@ import           Data.List.Extra                              (unsnoc)
 import           Development.IDE.Core.PluginUtils
 import           Development.IDE.Types.Shake                  (toKey)
 import           GHC.Types.SrcLoc                             (UnhelpfulSpanReason (UnhelpfulInteractive))
+#if MIN_VERSION_ghc(9,13,0)
+import           GHC.Types.Avail                              (DetOrdAvails (DefinitelyDeterministicAvails))
+import           GHC.Tc.Types                                 (tcg_exports)
+import           GHC.Types.Name.Set                           (nameSetElemsStable)
+#endif
 import           Ide.Logger                                   (Priority (..),
                                                                Recorder,
                                                                WithPriority,
@@ -262,11 +267,12 @@ initialiseSessionForEval needs_quickcheck st nfp = do
     -- it back to the iface for the current module.
     tm <- tmrTypechecked <$> use_ TypeCheck nfp
     let rdr_env = tcg_rdr_env tm
-    let linkable_hsc = loadModulesHome (map (addRdrEnv . linkableHomeMod) linkables) deps_hsc
         addRdrEnv hmi
           | iface <- hm_iface hmi
           , ms_mod ms == mi_module iface
-#if MIN_VERSION_ghc(9,11,0)
+#if MIN_VERSION_ghc(9,13,0)
+          = hmi { hm_iface = set_mi_top_env (IfaceTopEnv (DefinitelyDeterministicAvails $ tcg_exports tm) (mkIfaceImports $ tcg_import_decls tm)) iface}
+#elif MIN_VERSION_ghc(9,11,0)
           = hmi { hm_iface = set_mi_top_env (Just $ IfaceTopEnv (forceGlobalRdrEnv (globalRdrEnvLocal rdr_env)) (mkIfaceImports $ tcg_import_decls tm)) iface}
 #else
           = hmi { hm_iface = iface { mi_globals = Just $!
@@ -277,12 +283,20 @@ initialiseSessionForEval needs_quickcheck st nfp = do
                 }}
 #endif
           | otherwise = hmi
-
+#if MIN_VERSION_ghc(9,13,0)
+    linkable_hsc <- liftIO $ loadModulesHome (map (addRdrEnv . linkableHomeMod) linkables) deps_hsc
+#else
+    let linkable_hsc = loadModulesHome (map (addRdrEnv . linkableHomeMod) linkables) deps_hsc
+#endif
     return (ms, linkable_hsc)
   -- Bit awkward we need to use evalGhcEnv here but setContext requires to run
   -- in the Ghc monad
   env2 <- liftIO $ evalGhcEnv env1 $ do
+#if MIN_VERSION_ghc(9,13,0)
+            setContext [Compat.IIModule (ms_mod ms)]
+#else
             setContext [Compat.IIModule (moduleName (ms_mod ms))]
+#endif
             let df = flip xopt_set    LangExt.ExtendedDefaultRules
                    . flip xopt_unset  LangExt.MonomorphismRestriction
                    . flip gopt_set    Opt_ImplicitImportQualified
@@ -296,7 +310,14 @@ initialiseSessionForEval needs_quickcheck st nfp = do
             getSession
   return env2
 
-#if MIN_VERSION_ghc(9,11,0)
+#if MIN_VERSION_ghc(9,13,0)
+mkIfaceImports :: [ImportUserSpec] -> [IfaceImport]
+mkIfaceImports = map go
+  where
+    go (ImpUserSpec decl ImpUserAll) = IfaceImport decl ImpIfaceAll
+    go (ImpUserSpec decl (ImpUserExplicit avails parents)) = IfaceImport decl (ImpIfaceExplicit (DefinitelyDeterministicAvails avails) (nameSetElemsStable parents))
+    go (ImpUserSpec decl (ImpUserEverythingBut ns)) = IfaceImport decl (ImpIfaceEverythingBut (nameSetElemsStable ns))
+#elif MIN_VERSION_ghc(9,11,0)
 mkIfaceImports :: [ImportUserSpec] -> [IfaceImport]
 mkIfaceImports = map go
   where
@@ -463,10 +484,18 @@ evals recorder mark_exception fp df stmts = do
             dbg $ LogEvalFlags flags
             ndf <- getInteractiveDynFlags
             dbg $ LogEvalPreSetDynFlags ndf
+#if MIN_VERSION_ghc(9,13,0)
+            hsc_env <- getSession
+            eans <-
+                liftIO $ try @GhcException $
+                parseDynamicFlagsCmdLine (hsc_logger hsc_env) ndf
+                    (map (L $ UnhelpfulSpan unhelpfulReason) flags)
+#else
             eans <-
                 liftIO $ try @GhcException $
                 parseDynamicFlagsCmdLine ndf
                 (map (L $ UnhelpfulSpan unhelpfulReason) flags)
+#endif
             dbg $ LogEvalParsedFlags eans
             case eans of
                 Left err -> pure $ Just $ errorLines $ show err