WIP fix: do not check for file existance when added to the context

This need to be investigated.

The different `-boot` tests are flaky / failing in this MR because of
this.

Depending on "something" not yet understood, the file listed is
`extendKnownTargets` as `newTargets` exists or not on the disk (checked
with `doesFileExists`), leading to them added or not to the context.

Removing the check makes the test succeed without breaking any other
test.

Author: guibou

ghcide/session-loader/Development/IDE/Session.hs

@@ -476,10 +476,14 @@ loadSessionWithOptions recorder SessionLoadingOptions{..} rootDir que = do
                 -- If we don't generate a TargetFile for each potential location, we will only have
                 -- 'TargetFile Foo.hs' in the 'knownTargetsVar', thus not find 'TargetFile Foo.hs-boot'
                 -- and also not find 'TargetModule Foo'.
-                fs <- filterM (IO.doesFileExist . fromNormalizedFilePath) targetLocations
+                -- fs <- filterM (IO.doesFileExist . fromNormalizedFilePath) targetLocations
+                -- TODO: understand why there was this doesFileExists
+                let fs = targetLocations
                 pure $ map (\fp -> (TargetFile fp, Set.singleton fp)) (nubOrd (f:fs))
               TargetModule _ -> do
-                found <- filterM (IO.doesFileExist . fromNormalizedFilePath) targetLocations
+                -- found <- filterM (IO.doesFileExist . fromNormalizedFilePath) targetLocations
+                -- TODO: understand why there was this doesFileExists
+                let found = targetLocations
                 return [(targetTarget, Set.fromList found)]
           hasUpdate <- atomically $ do
             known <- readTVar knownTargetsVar
@@ -764,6 +768,7 @@ data TargetDetails = TargetDetails
       targetDepends   :: !DependencyInfo,
       targetLocations :: ![NormalizedFilePath]
   }
+  deriving (Show)
 
 fromTargetId :: [FilePath]          -- ^ import paths
              -> [String]            -- ^ extensions to consider