feat(test): add a repro for 4648

Author: guibou

plugins/hls-refactor-plugin/test/Main.hs

@@ -3036,6 +3036,26 @@ addFunctionConstraintTests = let
     , "eq (Pair x y) (Pair x' y') = x == x' && y == y'"
     ]
 
+  -- See https://github.com/haskell/haskell-language-server/issues/4648
+  -- When haddock comment appears after the =>, code action was introducing the
+  -- new constraint in the comment
+  incompleteConstraintSourceCodeWithCommentInTypeSignature :: T.Text -> T.Text
+  incompleteConstraintSourceCodeWithCommentInTypeSignature constraint =
+    T.unlines
+    [ "module Testing where"
+    , "data Pair a b = Pair a b"
+    , "eq "
+    , "    :: (" <> constraint <> ")"
+    , "    =>"
+    , "   -- This is the first argument"
+    , "   Pair a b ->"
+    , "   -- And this is the second"
+    , "   Pair a b ->"
+    , "   -- And this is the result"
+    , "   Bool"
+    , "eq (Pair x y) (Pair x' y') = x == x' && y == y'"
+    ]
+
   missingMonadConstraint constraint = T.unlines
     [ "module Testing where"
     , "f :: " <> constraint <> "m ()"
@@ -3079,6 +3099,11 @@ addFunctionConstraintTests = let
     "Add `Eq b` to the context of the type signature for `eq`"
     (incompleteConstraintSourceCodeWithNewlinesInTypeSignature "Eq a")
     (incompleteConstraintSourceCodeWithNewlinesInTypeSignature "Eq a, Eq b")
+  , checkCodeAction
+    "preexisting constraint, with haddock comment in type signature"
+    "Add `Eq b` to the context of the type signature for `eq`"
+    (incompleteConstraintSourceCodeWithCommentInTypeSignature "Eq a")
+    (incompleteConstraintSourceCodeWithCommentInTypeSignature "Eq a, Eq b")
   , checkCodeAction
     "missing Monad constraint"
     "Add `Monad m` to the context of the type signature for `f`"