Skip to content

Commit b8def30

Browse files
wz1000soulomoon
authored andcommitted
Use 9.10.2 instead of 9.10.3 for CI on windows (#4768)
* Use 9.10.2 instead of 9.10.3 for CI on windows 9.10.2 is currently broken with TH on windows. See https://gitlab.haskell.org/ghc/ghc/-/issues/26613 * Use 9.10.2 instead of 9.10.3 for CI on windows 9.10.2 is currently broken with TH on windows. See https://gitlab.haskell.org/ghc/ghc/-/issues/26613
1 parent 9ee2019 commit b8def30

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

.github/workflows/test.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ jobs:
7777
test:
7878
- true
7979
- false
80+
include:
81+
# 9.10.3 is broken on windows
82+
- os: windows-latest
83+
test: true
84+
ghc: "9.10.2"
8085
exclude:
8186
# Exclude the test configuration on macos, it's sufficiently similar to other OSs
8287
# that it mostly just burns CI time. Buiding is still useful since it catches
@@ -88,6 +93,9 @@ jobs:
8893
test: false
8994
- os: ubuntu-latest
9095
test: false
96+
# 9.10.3 is broken on windows
97+
- os: windows-latest
98+
ghc: "9.10"
9199

92100
steps:
93101
- uses: actions/checkout@v3
@@ -139,7 +147,7 @@ jobs:
139147
run: cabal test hls-refactor-plugin-tests || cabal test hls-refactor-plugin-tests
140148

141149
# TODO enable when it supports 9.10
142-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
150+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
143151
name: Test hls-floskell-plugin
144152
run: cabal test hls-floskell-plugin-tests || cabal test hls-floskell-plugin-tests
145153

@@ -156,7 +164,7 @@ jobs:
156164
run: cabal test hls-eval-plugin-tests || cabal test hls-eval-plugin-tests
157165

158166
# TODO enable when it supports 9.10
159-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
167+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
160168
name: Test hls-splice-plugin
161169
run: cabal test hls-splice-plugin-tests || cabal test hls-splice-plugin-tests
162170

@@ -189,7 +197,7 @@ jobs:
189197
run: cabal test hls-rename-plugin-tests || cabal test hls-rename-plugin-tests
190198

191199
# TODO enable when it supports 9.10
192-
- if: matrix.test && matrix.ghc != '9.10'
200+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.10.2'
193201
name: Test hls-hlint-plugin test suite
194202
run: cabal test hls-hlint-plugin-tests || cabal test hls-hlint-plugin-tests
195203

@@ -226,7 +234,7 @@ jobs:
226234
run: cabal test hls-explicit-record-fields-plugin-tests || cabal test hls-explicit-record-fields-plugin-tests
227235

228236
# versions need to be limited since the tests depend on cabal-fmt which only builds with ghc <9.10
229-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
237+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
230238
name: Test hls-cabal-fmt-plugin test suite
231239
run: cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests || cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests
232240

@@ -239,7 +247,7 @@ jobs:
239247
run: cabal test hls-cabal-plugin-tests || cabal test hls-cabal-plugin-tests
240248

241249
# TODO enable when it supports 9.10
242-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
250+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
243251
name: Test hls-retrie-plugin test suite
244252
run: cabal test hls-retrie-plugin-tests || cabal test hls-retrie-plugin-tests
245253

@@ -257,7 +265,7 @@ jobs:
257265

258266
# The plugin tutorial is only compatible with 9.6 and 9.8.
259267
# No particular reason, just to avoid excessive CPP.
260-
- if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12'
268+
- if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
261269
name: Compile the plugin-tutorial
262270
run: cabal build plugin-tutorial
263271

0 commit comments

Comments
 (0)