Skip to content

Commit cec4e54

Browse files
VenInfVeryMilkyJoe
andauthored
Apply suggestions from code review
Co-authored-by: VeryMilkyJoe <[email protected]>
1 parent 6906a94 commit cec4e54

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/CabalFields.hs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ getModulesNames fields = map swap $ groupSort rawModuleTargetPairs
209209
-- | Trims a given cabal AST leaving only targets and their
210210
-- @exposed-modules@ and @other-modules@ sections.
211211
--
212-
-- For examle:
212+
-- For example:
213213
--
214214
-- * Given a cabal file like this:
215215
--
@@ -218,26 +218,26 @@ getModulesNames fields = map swap $ groupSort rawModuleTargetPairs
218218
-- > hs-source-dirs: source/directory
219219
-- > ...
220220
-- > exposed-modules:
221-
-- > Importaint.Exposed.Module
221+
-- > Important.Exposed.Module
222222
-- > other-modules:
223-
-- > Importaint.Other.Module
223+
-- > Important.Other.Module
224224
-- >
225225
-- > test-suite tests
226226
-- > type: type
227227
-- > build-tool-depends: tool
228228
-- > other-modules:
229-
-- > Importaint.Other.Module
229+
-- > Important.Other.Module
230230
--
231231
-- * @getSectionsWithModules@ gives output:
232232
--
233233
-- > library
234234
-- > exposed-modules:
235-
-- > Importaint.Exposed.Module
235+
-- > Important.Exposed.Module
236236
-- > other-modules:
237-
-- > Importaint.Other.Module
237+
-- > Important.Other.Module
238238
-- > test-suite tests
239239
-- > other-modules:
240-
-- > Importaint.Other.Module
240+
-- > Important.Other.Module
241241
getSectionsWithModules :: [Syntax.Field any] -> [Syntax.Field any]
242242
getSectionsWithModules fields = concatMap go fields
243243
where
@@ -295,7 +295,7 @@ getNameEndPosition (Syntax.Name (Syntax.Position row col) byteString) = Syntax.P
295295
getFieldLineEndPosition :: Syntax.FieldLine Syntax.Position -> Syntax.Position
296296
getFieldLineEndPosition (Syntax.FieldLine (Syntax.Position row col) byteString) = Syntax.Position row (col + BS.length byteString)
297297

298-
-- | Returns a LSP compatible range for a provided field
298+
-- | Returns an LSP compatible range for a provided field
299299
getFieldLSPRange :: Syntax.Field Syntax.Position -> LSP.Range
300300
getFieldLSPRange field = LSP.Range startLSPPos endLSPPos
301301
where

plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Definition.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ lookupBuildTargetPackageDescription (PackageDescription {..}) (Just buildTargetN
193193
else Nothing
194194

195195
-- | Converts a name of a module to a FilePath
196-
-- Warning: Takes a lot of assumptions and generally
196+
-- Warning: Makes a lot of assumptions and generally
197197
-- not advised to use.
198198
--
199199
-- Examples: (output is system dependent)

0 commit comments

Comments
 (0)