Skip to content

Use plain comments instead of annotations for HLint ignores #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

georgefst
Copy link
Collaborator

Now that the HLint plugin works again, time to fix this minor annoyance which I've been meaning to get to since at least 2020:

FWIW, the currently recommended form is {- HLINT ... -}, and all other forms will trigger a HLint suggestion to change them in a future version. If we're going to write tests, I'd focus on that form.

And it's nice not to have to mess about with a second line to disable the unknown-pragma warning.

@georgefst georgefst requested a review from eddiemundo as a code owner July 21, 2025 18:45
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgefst georgefst enabled auto-merge (squash) July 22, 2025 10:48
@fendor fendor requested review from soulomoon and michaelpj July 22, 2025 11:58
@georgefst georgefst merged commit b8c9b84 into master Jul 22, 2025
60 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants