Handle CWE name #116
Open
Handle CWE name #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If that looks good to you, I'll update the other advisories. |
frasertweedale
requested changes
Aug 23, 2023
code/cwe/src/CWE.hs
Outdated
Comment on lines
20
to
26
| -- | A map to lookup CWE names. | ||
| cweNames :: Map CWEID Text | ||
| cweNames = Map.fromList (coerce cweData) | ||
|
|
||
| -- | A map to lookup CWEID. | ||
| cweIds :: Map Text CWEID | ||
| cweIds = Map.fromList $ (\(k, v) -> (v, k)) <$> (coerce cweData) |
There was a problem hiding this comment.
Eventually I would like to add all the parent / child / category membership data as well. But this is good for now.
|
Thank you for the review @frasertweedale! I'll address the rest of the comments tomorrow. |
blackheaven
requested changes
Aug 23, 2023
blackheaven
approved these changes
Aug 23, 2023
blackheaven
approved these changes
Oct 18, 2023
Comment on lines
+1
to
+4
| #!/usr/bin/env cabal | ||
| {- cabal: | ||
| build-depends: base, xml | ||
| -} |
There was a problem hiding this comment.
Since it's just for one-shot codegen I figured it was not necessary to add this to the cabal file.
TristanCacqueray
force-pushed
the
cwe
branch
from
fe63c09 to
f0f370f
Compare
blackheaven
approved these changes
Dec 13, 2023
TristanCacqueray
force-pushed
the
cwe
branch
2 times, most recently
from
261a833 to
013e031
Compare
blackheaven
approved these changes
Dec 18, 2023
This change adds a new library to parse CWE names.
|
@frasertweedale I'm tempted to close this PR, though I think it can be useful to quickly lookup the name. What do you think, should I rebase it instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables using CWE names instead of their number to improve advisory visibility.