Redesign security checks to use SomeException

Author: Bodigrim

Codec/Archive/Tar/Check/Internal.hs

@@ -291,6 +291,9 @@ instance Show PortabilityError where
 --------------------------
 -- Utils
 
-checkEntries :: (GenEntry a b -> Maybe e') -> GenEntries a b e -> GenEntries a b (Either e e')
+checkEntries
+  :: (GenEntry tarPath linkTarget -> Maybe e')
+  -> GenEntries tarPath linkTarget e
+  -> GenEntries tarPath linkTarget (Either e e')
 checkEntries checkEntry =
   mapEntries (\entry -> maybe (Right entry) Left (checkEntry entry))

changelog.md

@@ -9,7 +9,7 @@ See also http://pvp.haskell.org/faq
   * Handle > 8 GB files
   * Prohibit non-ASCII file names instead of silent corruption
   * Fix tests on 32-bit architectures
-  * Do not leak file handles in `packFileEntry`
+  * Alleviate leakage of file handles in `packFileEntry`
   * Add support for over-long filepaths via GNU extension
   * Add `toTarPath'`, `ToTarPathResult`, `longLinkEntry`, `longSymLinkEntry`
   * Fix handling of hardlinks and symlinks
@@ -18,7 +18,7 @@ See also http://pvp.haskell.org/faq
   * Switch to trailer parsing mode only after a full block of `NUL`
   * Drop deprecated `emptyIndex` and `finaliseIndex`
   * Extend `FileNameError` with `UnsafeLinkTarget` constructor
-  * Add `packAndCheck` and `unpackAndCheck`
+  * Add `packAndCheck`, `unpackAndCheck` and `Entry`-wise checks
   * Generalize `Entries`, `Entry` and `EntryContent` to `GenEntries`, `GenEntry` and `GenEntryContent`
 
 0.5.1.1 Herbert Valerio Riedel <[email protected]> August 2019