remaining cases

Author: GregoryTravis

Control/Monad/Trans/RWS/CPS.hs

@@ -213,11 +213,11 @@ instance (Monad m) => Applicative (RWST r w s m) where
         return (f x, s'', w'')
     {-# INLINE (<*>) #-}
 
-instance (MonadPlus m) => Alternative (RWST r w s m) where
-    empty = RWST $ \ _ _ _ -> mzero
+instance (Functor m, Alternative m, Monad m) => Alternative (RWST r w s m) where
+    empty = RWST $ \ _ _ _ -> empty
     {-# INLINE empty #-}
 
-    RWST m <|> RWST n = RWST $ \ r s w -> m r s w `mplus` n r s w
+    RWST m <|> RWST n = RWST $ \ r s w -> m r s w <|> n r s w
     {-# INLINE (<|>) #-}
 
 instance (Monad m) => Monad (RWST r w s m) where

Control/Monad/Trans/Select.hs

@@ -108,10 +108,10 @@ instance (Monad m) => Applicative (SelectT r m) where
     m *> k = m >>= \_ -> k
     {-# INLINE (*>) #-}
 
-instance (MonadPlus m) => Alternative (SelectT r m) where
-    empty = mzero
+instance (Functor m, Alternative m, Monad m) => Alternative (SelectT r m) where
+    empty = empty
     {-# INLINE empty #-}
-    (<|>) = mplus
+    (<|>) = (<|>)
     {-# INLINE (<|>) #-}
 
 instance (Monad m) => Monad (SelectT r m) where

Control/Monad/Trans/State/Lazy.hs

@@ -215,10 +215,10 @@ instance (Monad m) => Applicative (StateT s m) where
     m *> k = m >>= \_ -> k
     {-# INLINE (*>) #-}
 
-instance (MonadPlus m) => Alternative (StateT s m) where
-    empty = StateT $ \ _ -> mzero
+instance (Functor m, Alternative m, Monad m) => Alternative (StateT s m) where
+    empty = StateT $ \ _ -> empty
     {-# INLINE empty #-}
-    StateT m <|> StateT n = StateT $ \ s -> m s `mplus` n s
+    StateT m <|> StateT n = StateT $ \ s -> m s <|> n s
     {-# INLINE (<|>) #-}
 
 instance (Monad m) => Monad (StateT s m) where

Control/Monad/Trans/State/Strict.hs

@@ -208,10 +208,10 @@ instance (Monad m) => Applicative (StateT s m) where
     m *> k = m >>= \_ -> k
     {-# INLINE (*>) #-}
 
-instance (MonadPlus m) => Alternative (StateT s m) where
-    empty = StateT $ \ _ -> mzero
+instance (Functor m, Alternative m, Monad m) => Alternative (StateT s m) where
+    empty = StateT $ \ _ -> empty
     {-# INLINE empty #-}
-    StateT m <|> StateT n = StateT $ \ s -> m s `mplus` n s
+    StateT m <|> StateT n = StateT $ \ s -> m s <|> n s
     {-# INLINE (<|>) #-}
 
 instance (Monad m) => Monad (StateT s m) where

Control/Monad/Trans/Writer/CPS.hs

@@ -168,11 +168,11 @@ instance (Monad m) => Applicative (WriterT w m) where
         return (f x, w'')
     {-# INLINE (<*>) #-}
 
-instance (MonadPlus m) => Alternative (WriterT w m) where
-    empty = WriterT $ const mzero
+instance (Functor m, Alternative m, Monad m) => Alternative (WriterT w m) where
+    empty = WriterT $ const empty
     {-# INLINE empty #-}
 
-    WriterT m <|> WriterT n = WriterT $ \ w -> m w `mplus` n w
+    WriterT m <|> WriterT n = WriterT $ \ w -> m w <|> n w
     {-# INLINE (<|>) #-}
 
 instance (Monad m) => Monad (WriterT w m) where