Alternative instances no longer require MonadPlus#106
Alternative instances no longer require MonadPlus#106GregoryTravis wants to merge 10 commits intohaskell:mainfrom
Conversation
|
Could I ask for this to be rebased and then we can re-review? |
GregoryTravis
force-pushed
the
alternative
branch
from
4311ade to
bd76b37
Compare
|
@L0neGamer ready for re-review. |
|
Looks like the CI caught some redundant constraints on some versions of ghc! Sorry for the slow feedback loop. |
|
MHs seems to require a Traversible import that ghc 9.14.1 doesn't want. Trying an ifdef. |
|
Darn, yeah that's an issue we have. Sorry, would you be able to leave it in without the cpp? We can live with some warnings until #117 is merged when MHS updates. |
|
Just needs to undo the removal of imports in Lift and I think we're good to go! |
L0neGamer
left a comment
L0neGamer
left a comment
There was a problem hiding this comment.
Again, sorry for the back and forth. further review which should be the last thing:
restore Writer.Lazy's imports
restore Except's imports
restore Identity's imports
restore Maybe's imports
restore Reverse's imports
3 participants
Fixes #83 by requiring
Alternativerather thanMonadPlusin theAlternativeinstances for: