More typechecking and fix the type errors

Author: fendor

eslint.config.mjs

@@ -1,15 +1,31 @@
 import globals from 'globals';
-import pluginJs from '@eslint/js';
+import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';
 
-export default [
+export default tseslint.config(
   { files: ['**/*.{js,mjs,cjs,ts}'] },
-  { languageOptions: { globals: globals.node } },
   {
-    ...pluginJs.configs.recommended,
-    ...tseslint.configs.recommendedTypeChecked,
+    languageOptions: {
+      globals: globals.node,
+      parserOptions: { projectService: true, tsconfigRootDir: import.meta.dirname },
+    },
+  },
+  {
+    // disables type checking for this file only
+    files: ['eslint.config.mjs'],
+    extends: [tseslint.configs.disableTypeChecked],
+  },
+  eslint.configs.recommended,
+  tseslint.configs.recommendedTypeChecked,
+  {
     rules: {
+      // turn off these lints as we access workspaceConfiguration fields.
+      // So far, there was no bug found with these unsafe accesses.
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
+      // Sometimes, the 'any' just saves too much time.
       '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-floating-promises': 'error',
       '@typescript-eslint/no-unused-vars': [
         'error',
         {
@@ -24,5 +40,4 @@ export default [
       ],
     },
   },
-  ...tseslint.configs.recommended,
-];
+);

src/config.ts

@@ -1,6 +1,6 @@
 import { OutputChannel, Uri, window,  WorkspaceConfiguration,  WorkspaceFolder } from 'vscode';
 import { expandHomeDir, ExtensionLogger, IEnvVars } from './utils';
-import path = require('path');
+import * as path from 'path';
 import { Logger } from 'vscode-languageclient';
 
 export type LogLevel = 'off' | 'messages' | 'verbose';

src/docsBrowser.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { dirname } from 'path';
 import {
   CancellationToken,
@@ -51,7 +50,7 @@ async function showDocumentation({
     const bytes = await workspace.fs.readFile(Uri.parse(localPath));
 
     const addBase = `
-          <base href="${panel.webview.asWebviewUri(Uri.parse(documentationDirectory))}/">
+          <base href="${panel.webview.asWebviewUri(Uri.parse(documentationDirectory)).toString()}/">
           `;
 
     panel.webview.html = `
@@ -63,8 +62,10 @@ async function showDocumentation({
           </body>
           </html>
           `;
-  } catch (e: any) {
-    await window.showErrorMessage(e);
+  } catch (e) {
+    if (e instanceof Error) {
+      await window.showErrorMessage(e.message);
+    }
   }
   return panel;
 }
@@ -87,8 +88,10 @@ async function openDocumentationOnHackage({
     if (inWebView) {
       await commands.executeCommand('workbench.action.closeActiveEditor');
     }
-  } catch (e: any) {
-    await window.showErrorMessage(e);
+  } catch (e) {
+    if (e instanceof Error) {
+      await window.showErrorMessage(e.message);
+    }
   }
 }
 
@@ -154,11 +157,9 @@ function processLink(ms: MarkdownString | MarkedString): string | MarkdownString
             cmd = 'command:haskell.showDocumentation?' + encoded;
           }
           return `[${title}](${cmd})`;
-        } else if (title === 'Source') {
-          hackageUri = `https://hackage.haskell.org/package/${packageName}/docs/src/${fileAndAnchor.replace(
-            /-/gi,
-            '.',
-          )}`;
+        } else if (title === 'Source' && typeof fileAndAnchor === 'string') {
+          const moduleLocation = fileAndAnchor.replace(/-/gi, '.');
+          hackageUri = `https://hackage.haskell.org/package/${packageName}/docs/src/${moduleLocation}`;
           const encoded = encodeURIComponent(JSON.stringify({ title, localPath, hackageUri }));
           let cmd: string;
           if (openSourceInHackage) {
@@ -174,7 +175,7 @@ function processLink(ms: MarkdownString | MarkedString): string | MarkdownString
     );
   }
   if (typeof ms === 'string') {
-    return transform(ms as string);
+    return transform(ms);
   } else if (ms instanceof MarkdownString) {
     const mstr = new MarkdownString(transform(ms.value));
     mstr.isTrusted = true;

src/extension.ts

@@ -26,19 +26,21 @@ export async function activate(context: ExtensionContext) {
   // just support
   // https://microsoft.github.io/language-server-protocol/specifications/specification-3-15/#workspace_workspaceFolders
   // and then we can just launch one server
-  workspace.onDidOpenTextDocument(async (document: TextDocument) => await activeServer(context, document));
-  workspace.textDocuments.forEach(async (document: TextDocument) => await activeServer(context, document));
+  workspace.onDidOpenTextDocument(async (document: TextDocument) => await activateServer(context, document));
+  for (const document of workspace.textDocuments) {
+    await activateServer(context, document);
+  }
 
   // Stop the server from any workspace folders that are removed.
-  workspace.onDidChangeWorkspaceFolders((event) => {
+  workspace.onDidChangeWorkspaceFolders(async (event) => {
     for (const folder of event.removed) {
       const client = clients.get(folder.uri.toString());
       if (client) {
         const uri = folder.uri.toString();
         client.info(`Deleting folder for clients: ${uri}`);
         clients.delete(uri);
         client.info('Stopping the server');
-        client.stop();
+        await client.stop();
       }
     }
   });
@@ -49,7 +51,7 @@ export async function activate(context: ExtensionContext) {
       langClient?.info('Stopping the server');
       await langClient?.stop();
       langClient?.info('Starting the server');
-      langClient?.start();
+      await langClient?.start();
     }
   });
 
@@ -68,7 +70,7 @@ export async function activate(context: ExtensionContext) {
   const startCmd = commands.registerCommand(StartServerCommandName, async () => {
     for (const langClient of clients.values()) {
       langClient?.info('Starting the server');
-      langClient?.start();
+      await langClient?.start();
       langClient?.info('Server started');
     }
   });
@@ -83,7 +85,7 @@ export async function activate(context: ExtensionContext) {
   context.subscriptions.push(openOnHackageDisposable);
 }
 
-async function activeServer(context: ExtensionContext, document: TextDocument) {
+async function activateServer(context: ExtensionContext, document: TextDocument) {
   // We are only interested in Haskell files.
   if (
     (document.languageId !== 'haskell' &&
@@ -97,7 +99,7 @@ async function activeServer(context: ExtensionContext, document: TextDocument) {
   const uri = document.uri;
   const folder = workspace.getWorkspaceFolder(uri);
 
-  activateServerForFolder(context, uri, folder);
+  await activateServerForFolder(context, uri, folder);
 }
 
 async function activateServerForFolder(context: ExtensionContext, uri: Uri, folder?: WorkspaceFolder) {