Skip to content

Commit 76c909a

Browse files
Merge pull request #390 from jhrcek/jhrcek/flag-groups-fix
Don't render 'Enabled by:' for flags which are not part of any flag group
2 parents 8e7d220 + 8eeb3ea commit 76c909a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

message-index/site.hs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,9 @@ flagSetFields =
274274
_ -> noResult "",
275275
field "flag_group" $ \_me -> do
276276
flagInfo >>= \case
277-
Just (_, g) -> return $ unwords g
277+
-- Don't render flag_group field for flags which are not member of any flag group (like -Wall)
278+
Just (_, []) -> noResult ""
279+
Just (_, groups) -> return $ unwords groups
278280
Nothing -> return ""
279281
]
280282

message-index/templates/message.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
$if(on_by_default)$
55
<i>Enabled by default</i>
66
$else$
7-
<i>Enabled by: <code>$flag_group$</code></i>
7+
$if(flag_group)$
8+
<i>Enabled by: <code>$flag_group$</code></i>
9+
$endif$
810
$endif$
911
</p>
1012
$endif$

0 commit comments

Comments
 (0)