Merge pull request #432 from Soupstraw/patch-2

GHC-58008

Author: david-christiansen

message-index/messages/GHC-58008/gadt-without-monobind/after/GADTWithoutMonoBind.hs

@@ -0,0 +1,9 @@
+{-# LANGUAGE MonoLocalBinds #-}
+
+module GADTWithoutMonoBind where
+
+data A a where
+  A :: A ()
+
+f :: A () -> ()
+f A = ()

message-index/messages/GHC-58008/gadt-without-monobind/before/GADTWithoutMonoBind.hs

@@ -0,0 +1,7 @@
+module GADTWithoutMonoBind where
+
+data A a where
+  A :: A ()
+
+f :: A () -> ()
+f A = ()

message-index/messages/GHC-58008/gadt-without-monobind/index.md

@@ -0,0 +1,24 @@
+---
+title: Pattern matching on GADTs without MonoLocalBinds
+---
+
+## Message
+
+```
+GADTWithoutMonoBind.hs:7:3: warning: [GHC-58008] [-Wgadt-mono-local-binds]
+    Pattern matching on GADTs without MonoLocalBinds is fragile.
+    Suggested fix:
+      Enable any of the following extensions: GADTs, TypeFamilies
+  |
+7 | f A = ()
+  |   ^
+```
+
+## Explanation
+
+When using GADTs, the type system is different in the sense that it's not 
+possible to derive the principal type of the function `f`. Both
+`f :: A a -> ()` and `f :: A () -> ()` can be considered the most general
+typing for the function. The `MonoLocalBinds` extension uses a slightly more
+conservative policy in order to be able to derive the type properly in such
+cases.

message-index/messages/GHC-58008/index.md

@@ -0,0 +1,13 @@
+---
+title: Pattern matching on GADTs without MonoLocalBinds is fragile
+summary: Pattern matching on GADTs without MonoLocalBinds is fragile
+introduced: 9.6.1
+severity: warning
+flag: -Wgadt-mono-local-binds
+---
+
+This warning is triggered on pattern matching involving GADTs, if `MonoLocalBinds` is disabled. Type inference can be fragile in this case.
+See [the OutsideIn(X) paper](https://doi.org/10.1017/S0956796811000098) and [Let-generalisation](https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/let_generalisation.html) for more details.
+To resolve this warning, you can enable `MonoLocalBinds` or an extension implying it (`GADTs` or `TypeFamilies`).
+The warning is also triggered when matching on GADT-like pattern synonyms (i.e. pattern synonyms containing equalities in provided constraints).
+In previous versions of GHC (9.2 and below), it was an error to pattern match on a GADT if neither `GADTs` nor `TypeFamilies` were enabled.