Skip to content

Commit aa6afbe

Browse files
committed
Remove DiagnosticReason
1 parent f17fbd1 commit aa6afbe

File tree

2 files changed

+4
-29
lines changed

2 files changed

+4
-29
lines changed

proposals/0000-specify-dump-json.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,7 @@ For demonstrative purposes, here is an example valid instance of the schema.
119119
},
120120
"severity": "Error",
121121
"code": 27958,
122-
"message": " • Couldn't match type ‘b0’ with ‘(Bool, b0)’ \n Expected: b0 -> Maybe (Bool, b0) \nActual: b0 -> Maybe b0 \n• In the first argument of ‘unfoldr’, namely ‘Just’ \nIn the expression: unfoldr Just \nIn an equation for ‘f’: f = unfoldr Just",
123-
"warnReason": {
124-
"reason": "ErrorWithoutFlag"
125-
}
122+
"message": " • Couldn't match type ‘b0’ with ‘(Bool, b0)’ \n Expected: b0 -> Maybe (Bool, b0) \nActual: b0 -> Maybe b0 \n• In the first argument of ‘unfoldr’, namely ‘Just’ \nIn the expression: unfoldr Just \nIn an equation for ‘f’: f = unfoldr Just"
126123
}
127124
]
128125
}

proposals/0000-specify-dump-json/schema.json

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -38,36 +38,14 @@
3838
"message": {
3939
"description": "The string output of the diagnostic message by GHC",
4040
"type": "string"
41-
},
42-
"warnReason": {
43-
"description": "The flag, if it exists, which caused the warning",
44-
"type": "object",
45-
"properties": {
46-
"reason": {
47-
"description": "The reason why a diagnostic was emitted in the first place (e.g., flag, category)",
48-
"type": "string",
49-
"enum": [
50-
"WarningWithoutFlag",
51-
"WarningWithFlag",
52-
"WarningWithCategory",
53-
"ErrorWithoutFlag"
54-
]
55-
},
56-
"flagOrCategory": {
57-
"desciption": "The flag or category which caused the warning",
58-
"type": "string",
59-
}
60-
},
61-
"required": [
62-
"reason"
63-
]
6441
}
6542
},
6643
"required": [
6744
"span",
6845
"severity",
6946
"message"
70-
]
47+
],
48+
"additionalProperties": false
7149
}
7250
}
7351
},
@@ -78,7 +56,7 @@
7856
"additionalProperties": false,
7957
"$defs": {
8058
"span": {
81-
"description": "The location of the diganostic",
59+
"description": "The location of the diagnostic",
8260
"type": "object",
8361
"properties": {
8462
"file": {

0 commit comments

Comments
 (0)