Skip to content

Commit 0124b8c

Browse files
ctzsnoozehaslinghuis
authored andcommitted
update pid_tuning page for 4.3
Fix sliders disable input Verify target has all addresses found in the hex file instead of verifying the size. As noted in PR betaflight#2512 simply verifying the size of the hex file is not extensible and is not how hex files are designed to be used. A hex file can contains many non-contiguous blocks of data. This also supports targets with any partition layout. Additionally, this provides a more flexible way of providing hex files which can now contain data for non-contiguous blocks, e.g. firmware + config or firmware + osd fonts. Fix pre-existing code-smells. Indicate inactive dyn notch if looprate less 2k don't change filter type when moving filter slider Presets: remove cache for fetch Update github issues templates Fix Port Detection using VID/PID Add option for manufacturers and developers fix integrated yaw usage move code to pidtuning.js fix tuningsliders disable only if rpy Fix filter slider update Fix lowpass 1 handlers Put things back Restore Initial Settings Fix PID rows updating Work on PID Fix PID copy Remove PID validation Apply new MSP FW sliders: fix gyro and dterm ON/OF toggles FW sliders for 4.2: Mark's diff file applied FW Sliders for 4.2: Fix infinity for PD ratio and fix PD gain slider adjustin only D FE Sliders for 4.2: fixing legacy filter and PID sliders - bringing back old logic FW Sliders: bringing back SetDirty for the correct profile select blocking Fix slider calculation Remove MSP_APPLY* Fix legacy Revert CSS for PID tab Move Filter Mode element in UI Remove bitflag Remove apply byte FW sliders: symmetrical MSP commands Fix saving gyro lowpass 1 disable FW sliders: fix dterm dynamic LPF after enabling it FW sliders: fix enabled input field background FW Sliders: fix when loading PID tab with non-default expert sliders in non-expert mode
1 parent c7af0c4 commit 0124b8c

File tree

19 files changed

+1167
-1022
lines changed

19 files changed

+1167
-1022
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: Bug Report
3+
about: Create a report to help us fix bugs in Betaflight Configurator
4+
labels: "Template: Bug"
5+
---
6+
<!-- This is a template that you must fill. If not, the message will be closed. So don't erase any subtitle in this template (they start with ###)
7+
and complete all of them -->
8+
9+
### Describe the bug
10+
<!-- A clear and concise description of what the bug is. -->
11+
12+
### To Reproduce
13+
<!-- Steps to reproduce the behavior -->
14+
15+
### Expected behavior
16+
<!-- A clear and concise description of what you expected to happen. -->
17+
18+
### Setup
19+
<!-- Specify the version of the configurator (as displayed in the app) -->
20+
- Configurator version:
21+
22+
<!-- If this bug is related to a specific flight controller and/or configuration please specify it here. Create a diff and post it here in a code block. Put (three backticks) at the start and end of the diff block (instructions on how to do a diff: https://oscarliang.com/use-diff-not-dump-betaflight/) -->
23+
```
24+
PASTE THE OUTPUT OF 'diff' HERE
25+
```
26+
27+
<!-- Add any other context about the problem that you think might be relevant here. -->

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Configuration and other support questions
4+
url: https://github.com/betaflight/betaflight#support-and-developers-channel
5+
about: Official Slack chat channel and Facebook group about Betaflight
6+
- name: Hardware Issues
7+
url: https://github.com/betaflight/betaflight#hardware-issues
8+
about: What to do in the case of hardware issues
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
name: Feature Request
3+
about: Suggest an idea for for a new feature for Betaflight Configurator
4+
labels: "Template: Feature Request"
5+
---
6+
<!-- This is a template that you must fill. If not, the message will be closed. So don't erase any subtitle in this template (they start with ###)
7+
and complete all of them -->
8+
9+
<!-- Please note that feature requests are not 'fire and forget'. It is a lot more likely that the feature you would like to have will be implemented if you keep watching your feature request, and provide more details to developers looking into implementing your feature, and help them with testing. -->
10+
11+
### Is your feature request related to a problem? Please describe.
12+
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
13+
14+
### Describe the solution you'd like
15+
<!-- A clear and concise description of what you want to happen. -->
16+
17+
### Describe alternatives you've considered
18+
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
19+
20+
21+
<!-- Add any other context or screenshots about the feature request that you think might be relevant here. -->

.github/issue_template.md

Lines changed: 0 additions & 12 deletions
This file was deleted.

locales/en/messages.json

Lines changed: 103 additions & 66 deletions
Large diffs are not rendered by default.

src/css/tabs/pid_tuning.css

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,6 @@
255255
text-align: right;
256256
border: 1px solid var(--subtleAccent);
257257
border-radius: 3px;
258-
background-color: #f9f9f9;
259-
}
260-
261-
.tab-pid_tuning .subtab-pid table input:disabled {
262-
background-color: #dddddd;
263258
}
264259

265260
.tab-pid_tuning .subtab-filter table input,
@@ -906,7 +901,13 @@
906901
}
907902

908903
.tab-pid_tuning .subtab-pid .cf_column {
909-
min-width: 600px;
904+
min-width: 450px;
905+
flex: 1.3;
906+
}
907+
908+
.tab-pid_tuning .subtab-pid .cf_column_right{
909+
min-width: 300px;
910+
margin-left: 15px;
910911
flex: 1;
911912
}
912913

@@ -1011,6 +1012,15 @@
10111012
width: 100%;
10121013
}
10131014

1015+
.tab-pid_tuning .subtab-pid .cf_column_right {
1016+
min-width: 100%;
1017+
margin-left: 0px;
1018+
}
1019+
1020+
.tab-pid_tuning .note-button td:first-child {
1021+
width: 60%;
1022+
}
1023+
10141024
.tab-pid_tuning .spacer_left {
10151025
width: 100%;
10161026
}
@@ -1058,4 +1068,10 @@
10581068
.tab-pid_tuning .tuningPIDSliders .pid_titlebar th:nth-child(2), .tab-pid_tuning .tuningFilterSliders .pid_titlebar th:nth-child(2) {
10591069
width: 20%;
10601070
}
1071+
1072+
.tab-pid_tuning .pid_titlebar th div .xs {
1073+
text-overflow: ellipsis;
1074+
overflow: hidden;
1075+
white-space: nowrap;
1076+
}
10611077
}

0 commit comments

Comments
 (0)