Merge pull request #12 from altertable-ai/su/fix-curl-segv

hatamiarash7 · web-flow · commit 813c32cf747b · 2025-09-28T08:01:20.000+03:30
Fix cURL's WRITEFUNCTION undefined behavior leading to segfault
diff --git a/src/functions/get_tranco.cpp b/src/functions/get_tranco.cpp
@@ -17,14 +17,14 @@ namespace duckdb
         // Function to get the download code for the Tranco list
         std::string GetTrancoDownloadCode (char *date)
         {
-            CURL *curl = CreateCurlHandler ();
+            CURL *curl = CreateCurlHandler (WriteStringCallback);
             CURLcode res;
             std::string readBuffer;
 
             // Construct the URL for the daily list
             std::string url = "https://tranco-list.eu/daily_list?date=" + std::string (date) + "&subdomains=true";
 
-            LogMessage (LogLevel::INFO, "Get Tranco download code for date: " + std::string (date));
+            LogMessage (LogLevel::LOG_INFO, "Get Tranco download code for date: " + std::string (date));
 
             curl_easy_setopt (curl, CURLOPT_URL, url.c_str ());
             curl_easy_setopt (curl, CURLOPT_WRITEDATA, &readBuffer);
@@ -33,20 +33,20 @@ namespace duckdb
 
             if (res != CURLE_OK)
             {
-                LogMessage (LogLevel::ERROR, std::string (curl_easy_strerror (res)));
-                LogMessage (LogLevel::CRITICAL, "Failed to fetch Tranco download code.");
+                LogMessage (LogLevel::LOG_ERROR, std::string (curl_easy_strerror (res)));
+                LogMessage (LogLevel::LOG_CRITICAL, "Failed to fetch Tranco download code.");
             }
 
             // Extract the download code from the URL
             std::regex code_regex (R"(Information on the Tranco list with ID ([A-Z0-9]+))");
             std::smatch code_match;
             if (std::regex_search (readBuffer, code_match, code_regex) && code_match.size () > 1)
             {
-                LogMessage (LogLevel::INFO, "Tranco download code: " + code_match[1].str ());
+                LogMessage (LogLevel::LOG_INFO, "Tranco download code: " + code_match[1].str ());
                 return code_match[1].str ();
             }
 
-            LogMessage (LogLevel::CRITICAL, "Failed to extract Tranco download code.");
+            LogMessage (LogLevel::LOG_CRITICAL, "Failed to extract Tranco download code.");
         }
 
         // Function to download the Tranco list and create a table
@@ -78,16 +78,16 @@ namespace duckdb
                 // Construct the download URL
                 std::string download_url = "https://tranco-list.eu/download/" + download_code + "/full";
 
-                LogMessage (LogLevel::INFO, "Download Tranco list: " + download_url);
+                LogMessage (LogLevel::LOG_INFO, "Download Tranco list: " + download_url);
 
                 // Download the CSV file to a temporary file
-                CURL *curl = CreateCurlHandler ();
+                CURL *curl = CreateCurlHandler (WriteFileCallback);
                 CURLcode res;
                 FILE *file = fopen (temp_file.c_str (), "wb");
                 if (!file)
                 {
                     curl_easy_cleanup (curl);
-                    LogMessage (LogLevel::CRITICAL, "Failed to create temporary file for Tranco list.");
+                    LogMessage (LogLevel::LOG_CRITICAL, "Failed to create temporary file for Tranco list.");
                 }
 
                 curl_easy_setopt (curl, CURLOPT_URL, download_url.c_str ());
@@ -99,18 +99,18 @@ namespace duckdb
                 if (res != CURLE_OK)
                 {
                     remove (temp_file.c_str ()); // Clean up the temporary file
-                    LogMessage (LogLevel::ERROR, std::string (curl_easy_strerror (res)));
-                    LogMessage (LogLevel::CRITICAL, "Failed to download Tranco list. Check logs for details.");
+                    LogMessage (LogLevel::LOG_ERROR, std::string (curl_easy_strerror (res)));
+                    LogMessage (LogLevel::LOG_CRITICAL, "Failed to download Tranco list. Check logs for details.");
                 }
             }
 
             if (!file.good ())
             {
-                LogMessage (LogLevel::CRITICAL, "Tranco list `" + temp_file + "` not found. Download it first using `SELECT update_tranco(true);`");
+                LogMessage (LogLevel::LOG_CRITICAL, "Tranco list `" + temp_file + "` not found. Download it first using `SELECT update_tranco(true);`");
             }
 
             // Parse the CSV data and insert into a table
-            LogMessage (LogLevel::INFO, "Inserting Tranco list into table");
+            LogMessage (LogLevel::LOG_INFO, "Inserting Tranco list into table");
 
             Connection con (db);
             string query = "CREATE OR REPLACE TABLE tranco_list AS"
@@ -133,7 +133,7 @@ namespace duckdb
 
             if (result->HasError ())
             {
-                LogMessage (LogLevel::CRITICAL, result->GetError ());
+                LogMessage (LogLevel::LOG_CRITICAL, result->GetError ());
             }
         }
 
@@ -162,7 +162,7 @@ namespace duckdb
 
             if (table_exists->RowCount () == 0)
             {
-                LogMessage (LogLevel::CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
+                LogMessage (LogLevel::LOG_CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
             }
 
             // Extract the input from the arguments
@@ -201,7 +201,7 @@ namespace duckdb
 
             if (table_exists->RowCount () == 0)
             {
-                LogMessage (LogLevel::CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
+                LogMessage (LogLevel::LOG_CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
             }
 
             // Extract the input from the arguments
diff --git a/src/utils/logger.cpp b/src/utils/logger.cpp
@@ -15,24 +15,24 @@ namespace duckdb
             const char *env_level = std::getenv ("LOG_LEVEL");
             if (env_level == nullptr)
             {
-                return LogLevel::INFO; // default level
+                return LogLevel::LOG_INFO; // default level
             }
 
             std::string level_str (env_level);
             if (level_str == "DEBUG")
-                return LogLevel::DEBUG;
+                return LogLevel::LOG_DEBUG;
             if (level_str == "INFO")
-                return LogLevel::INFO;
+                return LogLevel::LOG_INFO;
             if (level_str == "WARNING")
-                return LogLevel::WARNING;
+                return LogLevel::LOG_WARNING;
             if (level_str == "ERROR")
-                return LogLevel::ERROR;
+                return LogLevel::LOG_ERROR;
             if (level_str == "CRITICAL")
-                return LogLevel::CRITICAL;
+                return LogLevel::LOG_CRITICAL;
 
             std::cerr << "Unknown LOG_LEVEL environment variable value: " << level_str
                       << ". Defaulting to INFO." << std::endl;
-            return LogLevel::INFO;
+            return LogLevel::LOG_INFO;
         }
 
         std::string getCurrentTimestamp ()
@@ -57,11 +57,11 @@ namespace duckdb
             const char *level_str = "";
             switch (level)
             {
-            case LogLevel::DEBUG: level_str = "DEBUG"; break;
-            case LogLevel::INFO: level_str = "INFO"; break;
-            case LogLevel::WARNING: level_str = "WARNING"; break;
-            case LogLevel::ERROR: level_str = "ERROR"; break;
-            case LogLevel::CRITICAL: level_str = "CRITICAL"; break;
+            case LogLevel::LOG_DEBUG: level_str = "DEBUG"; break;
+            case LogLevel::LOG_INFO: level_str = "INFO"; break;
+            case LogLevel::LOG_WARNING: level_str = "WARNING"; break;
+            case LogLevel::LOG_ERROR: level_str = "ERROR"; break;
+            case LogLevel::LOG_CRITICAL: level_str = "CRITICAL"; break;
             }
 
             std::ofstream log_file ("netquack.log", std::ios_base::app);
@@ -76,13 +76,13 @@ namespace duckdb
                      << message << std::endl;
 
             // Also output to stderr for error levels
-            if (level >= LogLevel::ERROR)
+            if (level >= LogLevel::LOG_ERROR)
             {
                 std::cerr << "[" << level_str << "] " << message << std::endl;
             }
 
             // Throw exception for critical errors
-            if (level == LogLevel::CRITICAL)
+            if (level == LogLevel::LOG_CRITICAL)
             {
                 throw std::runtime_error (message);
             }
diff --git a/src/utils/logger.hpp b/src/utils/logger.hpp
@@ -8,13 +8,14 @@ namespace duckdb
 {
     namespace netquack
     {
+        // Note: `LOG_` prefix is to avoid problems with DEBUG and ERROR macros
         enum class LogLevel
         {
-            DEBUG,
-            INFO,
-            WARNING,
-            ERROR,
-            CRITICAL
+            LOG_DEBUG,
+            LOG_INFO,
+            LOG_WARNING,
+            LOG_ERROR,
+            LOG_CRITICAL
         };
 
         // Function to log messages with a specified log level
diff --git a/src/utils/utils.cpp b/src/utils/utils.cpp
@@ -32,12 +32,12 @@ namespace duckdb
 #endif
         }
 
-        CURL *CreateCurlHandler ()
+        CURL *CreateCurlHandler (curl_write_callback write_callback)
         {
             CURL *curl = curl_easy_init ();
             if (!curl)
             {
-                LogMessage (LogLevel::CRITICAL, "Failed to initialize CURL");
+                LogMessage (LogLevel::LOG_CRITICAL, "Failed to initialize CURL");
             }
 
             const char *ca_info = std::getenv ("CURL_CA_INFO");
@@ -63,34 +63,41 @@ namespace duckdb
             }
 #endif
             curl_easy_setopt (curl, CURLOPT_FOLLOWLOCATION, 1L); // Follow redirects
-            curl_easy_setopt (curl, CURLOPT_WRITEFUNCTION, WriteCallback);
+            curl_easy_setopt (curl, CURLOPT_WRITEFUNCTION, write_callback);
+            
             if (ca_info)
             {
                 // Set the custom CA certificate bundle file
                 // https://github.com/hatamiarash7/duckdb-netquack/issues/6
-                LogMessage (LogLevel::DEBUG, "Using custom CA certificate bundle: " + std::string (ca_info));
+                LogMessage (LogLevel::LOG_DEBUG, "Using custom CA certificate bundle: " + std::string (ca_info));
                 curl_easy_setopt (curl, CURLOPT_CAINFO, ca_info);
             }
             const char *ca_path = std::getenv ("CURL_CA_PATH");
             if (ca_path)
             {
                 // Set the custom CA certificate directory
-                LogMessage (LogLevel::DEBUG, "Using custom CA certificate directory: " + std::string (ca_path));
+                LogMessage (LogLevel::LOG_DEBUG, "Using custom CA certificate directory: " + std::string (ca_path));
                 curl_easy_setopt (curl, CURLOPT_CAPATH, ca_path);
             }
 
             return curl;
         }
 
-        size_t WriteCallback (void *contents, size_t size, size_t nmemb, void *userp)
+        size_t WriteStringCallback (char *contents, size_t size, size_t nmemb, void *userp)
         {
             ((std::string *)userp)->append ((char *)contents, size * nmemb);
             return size * nmemb;
         }
 
+        size_t WriteFileCallback (char *contents, size_t size, size_t nmemb, void *userp)
+        {
+            FILE *file = (FILE *)userp;
+            return fwrite (contents, size, nmemb, file);
+        }
+
         std::string DownloadPublicSuffixList ()
         {
-            CURL *curl = CreateCurlHandler ();
+            CURL *curl = CreateCurlHandler (WriteStringCallback);
             CURLcode res;
             std::string readBuffer;
 
@@ -101,8 +108,8 @@ namespace duckdb
 
             if (res != CURLE_OK)
             {
-                LogMessage (LogLevel::ERROR, std::string (curl_easy_strerror (res)));
-                LogMessage (LogLevel::CRITICAL, "Failed to download public suffix list. Check logs for details.");
+                LogMessage (LogLevel::LOG_ERROR, std::string (curl_easy_strerror (res)));
+                LogMessage (LogLevel::LOG_CRITICAL, "Failed to download public suffix list. Check logs for details.");
             }
 
             return readBuffer;
@@ -118,14 +125,14 @@ namespace duckdb
 
             if (table_exists->RowCount () == 0 || table_data->RowCount () <= 1 || force)
             {
-                LogMessage (LogLevel::INFO, "Loading public suffix list...");
+                LogMessage (LogLevel::LOG_INFO, "Loading public suffix list...");
                 // Download the list
                 auto list_data = DownloadPublicSuffixList ();
 
                 // Validate the downloaded data
                 if (list_data.empty ())
                 {
-                    LogMessage (LogLevel::CRITICAL, "Failed to download public suffix list: empty data received");
+                    LogMessage (LogLevel::LOG_CRITICAL, "Failed to download public suffix list: empty data received");
                 }
 
                 // Count non-comment/non-empty lines for validation
@@ -143,11 +150,11 @@ namespace duckdb
 
                 if (valid_line_count <= 1)
                 {
-                    LogMessage (LogLevel::ERROR, validation_line);
-                    LogMessage (LogLevel::CRITICAL, "Downloaded public suffix list contains no valid entries. Try again or run `SELECT update_suffixes();`.");
+                    LogMessage (LogLevel::LOG_ERROR, validation_line);
+                    LogMessage (LogLevel::LOG_CRITICAL, "Downloaded public suffix list contains no valid entries. Try again or run `SELECT update_suffixes();`.");
                 }
 
-                LogMessage (LogLevel::INFO, "Downloaded public suffix list with " + std::to_string (valid_line_count) + " valid entries");
+                LogMessage (LogLevel::LOG_INFO, "Downloaded public suffix list with " + std::to_string (valid_line_count) + " valid entries");
 
                 // Parse the list and insert into a table
                 std::istringstream stream (list_data);
diff --git a/src/utils/utils.hpp b/src/utils/utils.hpp
@@ -10,11 +10,14 @@ namespace duckdb
 {
     namespace netquack
     {
-        // Function to get a CURL handler
-        CURL *CreateCurlHandler ();
+        // Function to get a CURL handler with custom write callback
+        CURL *CreateCurlHandler (curl_write_callback write_callback);
 
-        // Function to download a file from a URL
-        size_t WriteCallback (void *contents, size_t size, size_t nmemb, void *userp);
+        // Function to write data to a string (for HTTP responses)
+        size_t WriteStringCallback (char *contents, size_t size, size_t nmemb, void *userp);
+
+        // Function to write data to a file (for file downloads)
+        size_t WriteFileCallback (char *contents, size_t size, size_t nmemb, void *userp);
 
         // Function to download the public suffix list
         std::string DownloadPublicSuffixList ();
diff --git a/test/sql/update_tranco.test_slow b/test/sql/update_tranco.test_slow
@@ -0,0 +1,10 @@
+# name: test/sql/update_tranco.test_slow
+# description: test netquack extension update_tranco function
+# group: [netquack]
+
+require netquack
+
+query I
+SELECT update_tranco(true);
+----
+Tranco list updated

Original file line number	Diff line number	Diff line change
`@@ -17,14 +17,14 @@ namespace duckdb`
`17`	`17`	`// Function to get the download code for the Tranco list`
`18`	`18`	`std::string GetTrancoDownloadCode (char *date)`
`19`	`19`	`{`
`20`		`- CURL *curl = CreateCurlHandler ();`
	`20`	`+ CURL *curl = CreateCurlHandler (WriteStringCallback);`
`21`	`21`	`CURLcode res;`
`22`	`22`	`std::string readBuffer;`
`23`	`23`
`24`	`24`	`// Construct the URL for the daily list`
`25`	`25`	`std::string url = "https://tranco-list.eu/daily_list?date=" + std::string (date) + "&subdomains=true";`
`26`	`26`
`27`		`- LogMessage (LogLevel::INFO, "Get Tranco download code for date: " + std::string (date));`
	`27`	`+ LogMessage (LogLevel::LOG_INFO, "Get Tranco download code for date: " + std::string (date));`
`28`	`28`
`29`	`29`	`curl_easy_setopt (curl, CURLOPT_URL, url.c_str ());`
`30`	`30`	`curl_easy_setopt (curl, CURLOPT_WRITEDATA, &readBuffer);`
`@@ -33,20 +33,20 @@ namespace duckdb`
`33`	`33`
`34`	`34`	`if (res != CURLE_OK)`
`35`	`35`	`{`
`36`		`- LogMessage (LogLevel::ERROR, std::string (curl_easy_strerror (res)));`
`37`		`- LogMessage (LogLevel::CRITICAL, "Failed to fetch Tranco download code.");`
	`36`	`+ LogMessage (LogLevel::LOG_ERROR, std::string (curl_easy_strerror (res)));`
	`37`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to fetch Tranco download code.");`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`// Extract the download code from the URL`
`41`	`41`	`std::regex code_regex (R"(Information on the Tranco list with ID ([A-Z0-9]+))");`
`42`	`42`	`std::smatch code_match;`
`43`	`43`	`if (std::regex_search (readBuffer, code_match, code_regex) && code_match.size () > 1)`
`44`	`44`	`{`
`45`		`- LogMessage (LogLevel::INFO, "Tranco download code: " + code_match[1].str ());`
	`45`	`+ LogMessage (LogLevel::LOG_INFO, "Tranco download code: " + code_match[1].str ());`
`46`	`46`	`return code_match[1].str ();`
`47`	`47`	`}`
`48`	`48`
`49`		`- LogMessage (LogLevel::CRITICAL, "Failed to extract Tranco download code.");`
	`49`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to extract Tranco download code.");`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`// Function to download the Tranco list and create a table`
`@@ -78,16 +78,16 @@ namespace duckdb`
`78`	`78`	`// Construct the download URL`
`79`	`79`	`std::string download_url = "https://tranco-list.eu/download/" + download_code + "/full";`
`80`	`80`
`81`		`- LogMessage (LogLevel::INFO, "Download Tranco list: " + download_url);`
	`81`	`+ LogMessage (LogLevel::LOG_INFO, "Download Tranco list: " + download_url);`
`82`	`82`
`83`	`83`	`// Download the CSV file to a temporary file`
`84`		`- CURL *curl = CreateCurlHandler ();`
	`84`	`+ CURL *curl = CreateCurlHandler (WriteFileCallback);`
`85`	`85`	`CURLcode res;`
`86`	`86`	`FILE *file = fopen (temp_file.c_str (), "wb");`
`87`	`87`	`if (!file)`
`88`	`88`	`{`
`89`	`89`	`curl_easy_cleanup (curl);`
`90`		`- LogMessage (LogLevel::CRITICAL, "Failed to create temporary file for Tranco list.");`
	`90`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to create temporary file for Tranco list.");`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`curl_easy_setopt (curl, CURLOPT_URL, download_url.c_str ());`
`@@ -99,18 +99,18 @@ namespace duckdb`
`99`	`99`	`if (res != CURLE_OK)`
`100`	`100`	`{`
`101`	`101`	`remove (temp_file.c_str ()); // Clean up the temporary file`
`102`		`- LogMessage (LogLevel::ERROR, std::string (curl_easy_strerror (res)));`
`103`		`- LogMessage (LogLevel::CRITICAL, "Failed to download Tranco list. Check logs for details.");`
	`102`	`+ LogMessage (LogLevel::LOG_ERROR, std::string (curl_easy_strerror (res)));`
	`103`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to download Tranco list. Check logs for details.");`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`if (!file.good ())`
`108`	`108`	`{`
`109`		- LogMessage (LogLevel::CRITICAL, "Tranco list `" + temp_file + "` not found. Download it first using `SELECT update_tranco(true);`");
	`109`	+ LogMessage (LogLevel::LOG_CRITICAL, "Tranco list `" + temp_file + "` not found. Download it first using `SELECT update_tranco(true);`");
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`// Parse the CSV data and insert into a table`
`113`		`- LogMessage (LogLevel::INFO, "Inserting Tranco list into table");`
	`113`	`+ LogMessage (LogLevel::LOG_INFO, "Inserting Tranco list into table");`
`114`	`114`
`115`	`115`	`Connection con (db);`
`116`	`116`	`string query = "CREATE OR REPLACE TABLE tranco_list AS"`
`@@ -133,7 +133,7 @@ namespace duckdb`
`133`	`133`
`134`	`134`	`if (result->HasError ())`
`135`	`135`	`{`
`136`		`- LogMessage (LogLevel::CRITICAL, result->GetError ());`
	`136`	`+ LogMessage (LogLevel::LOG_CRITICAL, result->GetError ());`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`
`@@ -162,7 +162,7 @@ namespace duckdb`
`162`	`162`
`163`	`163`	`if (table_exists->RowCount () == 0)`
`164`	`164`	`{`
`165`		- LogMessage (LogLevel::CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
	`165`	+ LogMessage (LogLevel::LOG_CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`// Extract the input from the arguments`
`@@ -201,7 +201,7 @@ namespace duckdb`
`201`	`201`
`202`	`202`	`if (table_exists->RowCount () == 0)`
`203`	`203`	`{`
`204`		- LogMessage (LogLevel::CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
	`204`	+ LogMessage (LogLevel::LOG_CRITICAL, "Tranco table not found. Download it first using `SELECT update_tranco(true);`");
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`// Extract the input from the arguments`
Original file line number	Diff line number	Diff line change
`@@ -8,13 +8,14 @@ namespace duckdb`
`8`	`8`	`{`
`9`	`9`	`namespace netquack`
`10`	`10`	`{`
	`11`	+ // Note: `LOG_` prefix is to avoid problems with DEBUG and ERROR macros
`11`	`12`	`enum class LogLevel`
`12`	`13`	`{`
`13`		`- DEBUG,`
`14`		`- INFO,`
`15`		`- WARNING,`
`16`		`- ERROR,`
`17`		`- CRITICAL`
	`14`	`+ LOG_DEBUG,`
	`15`	`+ LOG_INFO,`
	`16`	`+ LOG_WARNING,`
	`17`	`+ LOG_ERROR,`
	`18`	`+ LOG_CRITICAL`
`18`	`19`	`};`
`19`	`20`
`20`	`21`	`// Function to log messages with a specified log level`
Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,12 @@ namespace duckdb`
`32`	`32`	`#endif`
`33`	`33`	`}`
`34`	`34`
`35`		`- CURL *CreateCurlHandler ()`
	`35`	`+ CURL *CreateCurlHandler (curl_write_callback write_callback)`
`36`	`36`	`{`
`37`	`37`	`CURL *curl = curl_easy_init ();`
`38`	`38`	`if (!curl)`
`39`	`39`	`{`
`40`		`- LogMessage (LogLevel::CRITICAL, "Failed to initialize CURL");`
	`40`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to initialize CURL");`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`const char *ca_info = std::getenv ("CURL_CA_INFO");`
`@@ -63,34 +63,41 @@ namespace duckdb`
`63`	`63`	`}`
`64`	`64`	`#endif`
`65`	`65`	`curl_easy_setopt (curl, CURLOPT_FOLLOWLOCATION, 1L); // Follow redirects`
`66`		`- curl_easy_setopt (curl, CURLOPT_WRITEFUNCTION, WriteCallback);`
	`66`	`+ curl_easy_setopt (curl, CURLOPT_WRITEFUNCTION, write_callback);`
	`67`	`+`
`67`	`68`	`if (ca_info)`
`68`	`69`	`{`
`69`	`70`	`// Set the custom CA certificate bundle file`
`70`	`71`	`// https://github.com/hatamiarash7/duckdb-netquack/issues/6`
`71`		`- LogMessage (LogLevel::DEBUG, "Using custom CA certificate bundle: " + std::string (ca_info));`
	`72`	`+ LogMessage (LogLevel::LOG_DEBUG, "Using custom CA certificate bundle: " + std::string (ca_info));`
`72`	`73`	`curl_easy_setopt (curl, CURLOPT_CAINFO, ca_info);`
`73`	`74`	`}`
`74`	`75`	`const char *ca_path = std::getenv ("CURL_CA_PATH");`
`75`	`76`	`if (ca_path)`
`76`	`77`	`{`
`77`	`78`	`// Set the custom CA certificate directory`
`78`		`- LogMessage (LogLevel::DEBUG, "Using custom CA certificate directory: " + std::string (ca_path));`
	`79`	`+ LogMessage (LogLevel::LOG_DEBUG, "Using custom CA certificate directory: " + std::string (ca_path));`
`79`	`80`	`curl_easy_setopt (curl, CURLOPT_CAPATH, ca_path);`
`80`	`81`	`}`
`81`	`82`
`82`	`83`	`return curl;`
`83`	`84`	`}`
`84`	`85`
`85`		`- size_t WriteCallback (void contents, size_t size, size_t nmemb, void userp)`
	`86`	`+ size_t WriteStringCallback (char contents, size_t size, size_t nmemb, void userp)`
`86`	`87`	`{`
`87`	`88`	`((std::string )userp)->append ((char )contents, size * nmemb);`
`88`	`89`	`return size * nmemb;`
`89`	`90`	`}`
`90`	`91`
	`92`	`+ size_t WriteFileCallback (char contents, size_t size, size_t nmemb, void userp)`
	`93`	`+ {`
	`94`	`+ FILE file = (FILE )userp;`
	`95`	`+ return fwrite (contents, size, nmemb, file);`
	`96`	`+ }`
	`97`	`+`
`91`	`98`	`std::string DownloadPublicSuffixList ()`
`92`	`99`	`{`
`93`		`- CURL *curl = CreateCurlHandler ();`
	`100`	`+ CURL *curl = CreateCurlHandler (WriteStringCallback);`
`94`	`101`	`CURLcode res;`
`95`	`102`	`std::string readBuffer;`
`96`	`103`
`@@ -101,8 +108,8 @@ namespace duckdb`
`101`	`108`
`102`	`109`	`if (res != CURLE_OK)`
`103`	`110`	`{`
`104`		`- LogMessage (LogLevel::ERROR, std::string (curl_easy_strerror (res)));`
`105`		`- LogMessage (LogLevel::CRITICAL, "Failed to download public suffix list. Check logs for details.");`
	`111`	`+ LogMessage (LogLevel::LOG_ERROR, std::string (curl_easy_strerror (res)));`
	`112`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to download public suffix list. Check logs for details.");`
`106`	`113`	`}`
`107`	`114`
`108`	`115`	`return readBuffer;`
`@@ -118,14 +125,14 @@ namespace duckdb`
`118`	`125`
`119`	`126`	`if (table_exists->RowCount () == 0 \|\| table_data->RowCount () <= 1 \|\| force)`
`120`	`127`	`{`
`121`		`- LogMessage (LogLevel::INFO, "Loading public suffix list...");`
	`128`	`+ LogMessage (LogLevel::LOG_INFO, "Loading public suffix list...");`
`122`	`129`	`// Download the list`
`123`	`130`	`auto list_data = DownloadPublicSuffixList ();`
`124`	`131`
`125`	`132`	`// Validate the downloaded data`
`126`	`133`	`if (list_data.empty ())`
`127`	`134`	`{`
`128`		`- LogMessage (LogLevel::CRITICAL, "Failed to download public suffix list: empty data received");`
	`135`	`+ LogMessage (LogLevel::LOG_CRITICAL, "Failed to download public suffix list: empty data received");`
`129`	`136`	`}`
`130`	`137`
`131`	`138`	`// Count non-comment/non-empty lines for validation`
`@@ -143,11 +150,11 @@ namespace duckdb`
`143`	`150`
`144`	`151`	`if (valid_line_count <= 1)`
`145`	`152`	`{`
`146`		`- LogMessage (LogLevel::ERROR, validation_line);`
`147`		- LogMessage (LogLevel::CRITICAL, "Downloaded public suffix list contains no valid entries. Try again or run `SELECT update_suffixes();`.");
	`153`	`+ LogMessage (LogLevel::LOG_ERROR, validation_line);`
	`154`	+ LogMessage (LogLevel::LOG_CRITICAL, "Downloaded public suffix list contains no valid entries. Try again or run `SELECT update_suffixes();`.");
`148`	`155`	`}`
`149`	`156`
`150`		`- LogMessage (LogLevel::INFO, "Downloaded public suffix list with " + std::to_string (valid_line_count) + " valid entries");`
	`157`	`+ LogMessage (LogLevel::LOG_INFO, "Downloaded public suffix list with " + std::to_string (valid_line_count) + " valid entries");`
`151`	`158`
`152`	`159`	`// Parse the list and insert into a table`
`153`	`160`	`std::istringstream stream (list_data);`