chore: improve ip_utils

Author: hatamiarash7

src/utils/ip_utils.cpp

@@ -65,7 +65,7 @@ namespace duckdb
             }
             else
             {
-                // For /32, the IP itself is the only host ( Hostroute )
+                // For /32, the IP itself is the only host (Hostroute)
                 info.network = ip;
             }
 
@@ -74,7 +74,7 @@ namespace duckdb
 
         bool IPCalculator::isValidInput (const std::string &input)
         {
-            std::regex pattern (R"((\d{1,3}\.){3}\d{1,3}(/\d{1,2})?)");
+            static const std::regex pattern (R"((\d{1,3}\.){3}\d{1,3}(/\d{1,2})?)");
             return std::regex_match (input, pattern);
         }
 
@@ -91,14 +91,15 @@ namespace duckdb
             return true;
         }
 
-        std::vector<int> IPCalculator::parseIP (const std::string &ip)
+        std::array<int, 4> IPCalculator::parseIP (const std::string &ip)
         {
-            std::vector<int> octets;
+            std::array<int, 4> octets{};
             std::stringstream ss (ip);
             std::string octet;
-            while (std::getline (ss, octet, '.'))
+            for (int i = 0; i < 4; ++i)
             {
-                octets.push_back (std::stoi (octet));
+                std::getline (ss, octet, '.');
+                octets[i] = std::stoi (octet);
             }
             return octets;
         }
@@ -190,7 +191,7 @@ namespace duckdb
             return ss.str ();
         }
 
-        std::string IPCalculator::intToIP (const std::vector<int> &octets)
+        std::string IPCalculator::intToIP (const std::array<int, 4> &octets)
         {
             std::stringstream ss;
             for (int i = 0; i < 4; ++i)

src/utils/ip_utils.hpp

@@ -27,7 +27,7 @@ namespace duckdb
           private:
             static bool isValidInput (const std::string &input);
             static bool isValidIP (const std::string &ip);
-            static std::vector<int> parseIP (const std::string &ip);
+            static std::array<int, 4> parseIP (const std::string &ip);
             static std::string getSubnetMask (int maskBits);
             static std::string getWildcardMask (const std::string &subnetMask);
             static std::string getNetworkAddress (const std::string &ip, const std::string &subnetMask, const int &maskBits);
@@ -37,7 +37,7 @@ namespace duckdb
             static int getHostsPerNet (int maskBits);
             static std::string getIPClass (const std::string &ip);
             static std::string intToIP (uint32_t ip);
-            static std::string intToIP (const std::vector<int> &octets);
+            static std::string intToIP (const std::array<int, 4> &octets);
         };
     } // namespace netquack
 } // namespace duckdb