Skip to content
This repository was archived by the owner on Feb 20, 2025. It is now read-only.

Commit e8722ca

Browse files
committed
fix: couple more types
1 parent 9ced997 commit e8722ca

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

hatchet_sdk/clients/dispatcher/action_listener.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ async def get_listen_client(
366366
f"action listener connection interrupted, retrying... ({self.retries}/{DEFAULT_ACTION_LISTENER_RETRY_COUNT})"
367367
)
368368

369-
## TODO: Figure out how to get type support for these
370369
self.aio_client = DispatcherStub(new_conn(self.config, True)) # type: ignore[no-untyped-call]
371370

372371
if self.listen_strategy == "v2":

hatchet_sdk/clients/rest_client.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,15 +234,14 @@ async def workflow_run_create(
234234
workflow_id: str,
235235
input: JSONSerializableDict,
236236
version: str | None = None,
237-
additional_metadata: list[str] | None = None,
237+
additional_metadata: JSONSerializableDict = {},
238238
) -> WorkflowRun:
239239
return await self.workflow_run_api.workflow_run_create(
240240
workflow=workflow_id,
241241
version=version,
242-
## TODO: Fix this type error - maybe a list of strings is okay since it's still JSON?
243242
trigger_workflow_run_request=TriggerWorkflowRunRequest(
244243
input=input,
245-
additionalMetadata=additional_metadata, # type: ignore[arg-type]
244+
additionalMetadata=additional_metadata,
246245
),
247246
)
248247

@@ -495,7 +494,7 @@ def workflow_run_create(
495494
workflow_id: str,
496495
input: JSONSerializableDict,
497496
version: str | None = None,
498-
additional_metadata: list[str] | None = None,
497+
additional_metadata: JSONSerializableDict = {},
499498
) -> WorkflowRun:
500499
return self._run_coroutine(
501500
self.aio.workflow_run_create(

0 commit comments

Comments
 (0)