Merge pull request #2366 from angmolin/bugfix/gcc+12-strict-overflow-warning

HiFiPhile · web-flow · commit 71f1400aea9f · 2023-12-10T17:22:43.000+01:00
Fix strict-overflow warning when compiling with gcc &gt;= 12
diff --git a/src/class/audio/audio_device.c b/src/class/audio/audio_device.c
@@ -1565,7 +1565,8 @@ uint16_t audiod_open(uint8_t rhport, tusb_desc_interface_t const * itf_desc, uin
       {
         uint8_t const *p_desc = _audiod_fct[i].p_desc;
         uint8_t const *p_desc_end = p_desc + _audiod_fct[i].desc_length - TUD_AUDIO_DESC_IAD_LEN;
-        while (p_desc < p_desc_end)
+        // Condition modified from p_desc < p_desc_end to prevent gcc>=12 strict-overflow warning
+        while (p_desc_end - p_desc > 0)
         {
           if (tu_desc_type(p_desc) == TUSB_DESC_ENDPOINT)
           {

Original file line number	Diff line number	Diff line change
`@@ -1565,7 +1565,8 @@ uint16_t audiod_open(uint8_t rhport, tusb_desc_interface_t const * itf_desc, uin`
`1565`	`1565`	`{`
`1566`	`1566`	`uint8_t const *p_desc = _audiod_fct[i].p_desc;`
`1567`	`1567`	`uint8_t const *p_desc_end = p_desc + _audiod_fct[i].desc_length - TUD_AUDIO_DESC_IAD_LEN;`
`1568`		`- while (p_desc < p_desc_end)`
	`1568`	`+ // Condition modified from p_desc < p_desc_end to prevent gcc>=12 strict-overflow warning`
	`1569`	`+ while (p_desc_end - p_desc > 0)`
`1569`	`1570`	`{`
`1570`	`1571`	`if (tu_desc_type(p_desc) == TUSB_DESC_ENDPOINT)`
`1571`	`1572`	`{`