make board_uart_read()/write() return -1 when unimplemented for consistency across all families

Author: hathach

.claude/commands/hil.md

@@ -7,27 +7,21 @@ Run Hardware-in-the-Loop (HIL) tests on physical boards.
 
 ## Instructions
 
-1. Determine the HIL config file:
-   ```bash
-   HIL_CONFIG=$( (systemctl list-units --type=service --state=running 2>/dev/null; systemctl --user list-units --type=service --state=running 2>/dev/null) | grep -q 'actions\.runner' && echo tinyusb.json || echo local.json )
-   ```
-   Default is `local.json` for local development.
-
-2. Parse $ARGUMENTS:
+1. Parse $ARGUMENTS:
    - If $ARGUMENTS contains `-b BOARD_NAME`, run for that specific board only.
    - If $ARGUMENTS is empty or has no `-b`, run for all boards in the config.
    - Pass through any other flags (e.g. `-v` for verbose, `-r N` for retry count) directly to the command.
 
-3. Determine whether to run **locally** or **remotely via SSH**:
+2. Determine whether to run **locally** or **remotely via SSH**:
    - **Local**: boards are attached to this machine (default when `local.json` is used)
    - **Remote (`ssh ci.lan`)**: boards are attached to the CI machine (when `tinyusb.json` is used)
 
-4. **Local execution** (boards attached to this machine):
+3. **Local execution** (boards attached to this machine):
    ```bash
    python test/hil/hil_test.py -b BOARD_NAME -B examples $HIL_CONFIG $EXTRA_ARGS
    ```
 
-5. **Remote execution** (boards attached to `ci.lan`):
+4. **Remote execution** (boards attached to `ci.lan`):
    Only copy the minimal files needed (firmware binaries + test script + config), then run remotely.
 
    ```bash
@@ -56,9 +50,9 @@ Run Hardware-in-the-Loop (HIL) tests on physical boards.
    - Flasher tools: `JLinkExe`, `openocd`, etc. as needed by the board
    - USB access to the boards (udev rules configured)
 
-6. Use a timeout of at least 20 minutes (600000ms). HIL tests take 2-5 minutes. NEVER cancel early.
+5. Use a timeout of at least 20 minutes (600000ms). HIL tests take 2-5 minutes. NEVER cancel early.
 
-7. After the test completes:
+6. After the test completes:
    - Show the test output to the user.
    - Summarize pass/fail results per board.
    - If there are failures, suggest re-running with `-v` flag for verbose output to help debug.

hw/bsp/board.c

@@ -97,17 +97,22 @@ int sys_read (int fhdl, char *buf, size_t count) {
 #else
 
 // Default logging with on-board UART
-// Retry to ensure printf/log output is not lost when board_uart_write is non-blocking
+// board_uart_write() is non-blocking, retry until all bytes sent.
+// Returns negative if UART is not available (stub), break immediately.
 int sys_write (int fhdl, const char *buf, size_t count) {
   (void) fhdl;
-  int written = 0;
-  while ((size_t)written < count) {
-    int wr = board_uart_write(buf + written, (int)(count - (size_t)written));
-    if (wr > 0) {
-      written += wr;
+  size_t written = 0;
+  while (written < count) {
+    int wr = board_uart_write(buf + written, (int)(count - written));
+    if (wr < 0) {
+      break; // UART not available
     }
+    if (wr == 0) {
+      continue; // TX busy, keep trying
+    }
+    written += (size_t) wr;
   }
-  return written;
+  return (int) written;
 }
 
 int sys_read (int fhdl, char *buf, size_t count) {

hw/bsp/da1469x/family.c

@@ -123,14 +123,14 @@ uint32_t board_button_read(void) {
 int board_uart_read(uint8_t* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const* buf, int len) {
   (void) buf;
   (void) len;
 
-  return 0;
+  return -1;
 }
 
 #if CFG_TUSB_OS == OPT_OS_NONE

hw/bsp/efm32/family.c

@@ -673,13 +673,13 @@ uint32_t board_button_read(void)
 int board_uart_read(uint8_t* buf, int len)
 {
   (void) buf; (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const * buf, int len)
 {
   (void) buf; (void) len;
-  return 0;
+  return -1;
 }
 
 #if CFG_TUSB_OS  == OPT_OS_NONE

hw/bsp/lpc11/family.c

@@ -114,13 +114,13 @@ uint32_t board_button_read(void) {
 int board_uart_read(uint8_t* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 #if CFG_TUSB_OS == OPT_OS_NONE

hw/bsp/lpc13/family.c

@@ -101,11 +101,11 @@ uint32_t board_button_read(void) {
 int board_uart_read(uint8_t* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }

hw/bsp/lpc17/family.c

@@ -64,29 +64,13 @@ void board_init(void) {
   Chip_GPIO_SetPinDIROutput(LPC_GPIO, LED_PORT, LED_PIN);
   Chip_GPIO_SetPinDIRInput(LPC_GPIO, BUTTON_PORT, BUTTON_PIN);
 
-#if 0
   //------------- UART -------------//
-  PINSEL_CFG_Type PinCfg =
-  {
-      .Portnum   = 0,
-      .Pinnum    = 0, // TXD is P0.0
-      .Funcnum   = 2,
-      .OpenDrain = 0,
-      .Pinmode   = 0
-  };
-  PINSEL_ConfigPin(&PinCfg);
-
-  PinCfg.Portnum = 0;
-  PinCfg.Pinnum  = 1; // RXD is P0.1
-  PINSEL_ConfigPin(&PinCfg);
-
-  UART_CFG_Type UARTConfigStruct;
-  UART_ConfigStructInit(&UARTConfigStruct);
-  UARTConfigStruct.Baud_rate = CFG_BOARD_UART_BAUDRATE;
-
-  UART_Init(BOARD_UART_PORT, &UARTConfigStruct);
-  UART_TxCmd(BOARD_UART_PORT, ENABLE); // Enable UART Transmit
-#endif
+  // Pin muxing for UART3 (TXD3=P0.0, RXD3=P0.1) is configured in board.h pinmuxing[]
+  Chip_UART_Init(BOARD_UART_PORT);
+  Chip_UART_SetBaud(BOARD_UART_PORT, CFG_BOARD_UART_BAUDRATE);
+  Chip_UART_ConfigData(BOARD_UART_PORT, (UART_LCR_WLEN8 | UART_LCR_SBS_1BIT | UART_LCR_PARITY_DIS));
+  Chip_UART_SetupFIFOS(BOARD_UART_PORT, (UART_FCR_FIFO_EN | UART_FCR_TRG_LEV0));
+  Chip_UART_TXEnable(BOARD_UART_PORT);
 
   //------------- USB -------------//
   Chip_IOCON_SetPinMuxing(LPC_IOCON, pin_usb_mux, sizeof(pin_usb_mux) / sizeof(PINMUX_GRP_T));
@@ -125,17 +109,30 @@ uint32_t board_button_read(void) {
 }
 
 int board_uart_read(uint8_t* buf, int len) {
-//  return UART_ReceiveByte(BOARD_UART_PORT);
-  (void) buf;
-  (void) len;
-  return 0;
+  int count = 0;
+  while (count < len) {
+    if (BOARD_UART_PORT->LSR & UART_LSR_RDR) {
+      buf[count] = (uint8_t) BOARD_UART_PORT->RBR;
+      count++;
+    } else {
+      break;
+    }
+  }
+  return count;
 }
 
 int board_uart_write(void const* buf, int len) {
-//  UART_Send(BOARD_UART_PORT, &c, 1, BLOCKING);
-  (void) buf;
-  (void) len;
-  return 0;
+  const uint8_t *p = (const uint8_t *) buf;
+  int count = 0;
+  while (count < len) {
+    if (BOARD_UART_PORT->LSR & UART_LSR_THRE) {
+      BOARD_UART_PORT->THR = p[count];
+      count++;
+    } else {
+      break;
+    }
+  }
+  return count;
 }
 
 #if CFG_TUSB_OS == OPT_OS_NONE

hw/bsp/lpc40/family.c

@@ -139,14 +139,14 @@ int board_uart_read(uint8_t *buf, int len) {
   //return UART_ReceiveByte(BOARD_UART_PORT);
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const *buf, int len) {
   //UART_Send(BOARD_UART_PORT, &c, 1, BLOCKING);
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 #if CFG_TUSB_OS == OPT_OS_NONE

hw/bsp/lpc51/family.c

@@ -106,13 +106,13 @@ uint32_t board_button_read(void) {
 int board_uart_read(uint8_t* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 #if CFG_TUSB_OS == OPT_OS_NONE

hw/bsp/lpc54/family.c

@@ -224,7 +224,7 @@ uint32_t board_button_read(void) {
 int board_uart_read(uint8_t* buf, int len) {
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 }
 
 int board_uart_write(void const* buf, int len) {
@@ -243,7 +243,7 @@ int board_uart_write(void const* buf, int len) {
 #else
   (void) buf;
   (void) len;
-  return 0;
+  return -1;
 #endif
 }