Correctly closes temporary files in cache

Author: hauke96

src/cache/cache.go

@@ -104,6 +104,12 @@ func CacheToFile(cacheFolderName string, filename string, reader io.ReadCloser)
 		}
 	}
 
+	// Close file as it's not needed anymore. Without closing it, Windows has problems moving the file.
+	err = tempFile.Close()
+	if err != nil {
+		return errors.Wrap(err, fmt.Sprintf("Unable to close temporary file '%s'", filepath.Join(GetTempPath(), filename)))
+	}
+
 	//
 	// 3. Move file to actual location
 	//

src/util/files.go

@@ -137,6 +137,7 @@ type FileLike interface {
 	Name() string
 	Write(p []byte) (n int, err error)
 	Stat() (os.FileInfo, error)
+	Close() error
 }
 
 type Filesystem interface {

src/util/files_mock.go

@@ -70,6 +70,10 @@ func (m *MockFile) Stat() (os.FileInfo, error) {
 	return NewMockFileInfo(m.Name()), nil
 }
 
+func (m *MockFile) Close() error {
+	return nil
+}
+
 type MockFilesystem struct {
 	ExistsFunc          func(path string) bool
 	GetSizeInBytesFunc  func(path string) (int64, error)