Skip to content

Commit a98e7e7

Browse files
Fixes typeddjango#2413 -- update ModelAdmin.log_FOO method signatures (typeddjango#2414)
Renamed the 'object' parameter to 'obj' to be consistent with the runtime implementation. Verified against Django 4.2 and the main branch.
1 parent fbce0b8 commit a98e7e7

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

django-stubs/contrib/admin/options.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,9 @@ class ModelAdmin(BaseModelAdmin[_ModelT]):
204204
orphans: int = ...,
205205
allow_empty_first_page: bool = ...,
206206
) -> Paginator: ...
207-
def log_addition(self, request: HttpRequest, object: _ModelT, message: Any) -> LogEntry: ...
208-
def log_change(self, request: HttpRequest, object: _ModelT, message: Any) -> LogEntry: ...
209-
def log_deletion(self, request: HttpRequest, object: _ModelT, object_repr: str) -> LogEntry: ...
207+
def log_addition(self, request: HttpRequest, obj: _ModelT, message: Any) -> LogEntry: ...
208+
def log_change(self, request: HttpRequest, obj: _ModelT, message: Any) -> LogEntry: ...
209+
def log_deletion(self, request: HttpRequest, obj: _ModelT, object_repr: str) -> LogEntry: ...
210210
def action_checkbox(self, obj: _ModelT) -> SafeString: ...
211211
def get_actions(self, request: HttpRequest) -> dict[str, tuple[Callable[..., str], str, str] | None]: ...
212212
def get_action_choices(

scripts/stubtest/allowlist_todo.txt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ django.conf.global_settings.gettext_noop
66
django.conf.urls.url
77
django.contrib.admin.FieldListFilter.title
88
django.contrib.admin.ModelAdmin
9-
django.contrib.admin.ModelAdmin.log_addition
10-
django.contrib.admin.ModelAdmin.log_change
11-
django.contrib.admin.ModelAdmin.log_deletion
129
django.contrib.admin.StackedInline
1310
django.contrib.admin.TabularInline
1411
django.contrib.admin.action
@@ -42,9 +39,6 @@ django.contrib.admin.options.InlineModelAdmin
4239
django.contrib.admin.options.InlineModelAdmin.model
4340
django.contrib.admin.options.InlineModelAdmin.template
4441
django.contrib.admin.options.ModelAdmin
45-
django.contrib.admin.options.ModelAdmin.log_addition
46-
django.contrib.admin.options.ModelAdmin.log_change
47-
django.contrib.admin.options.ModelAdmin.log_deletion
4842
django.contrib.admin.options.StackedInline
4943
django.contrib.admin.options.TabularInline
5044
django.contrib.admin.site
@@ -176,9 +170,6 @@ django.contrib.flatpages.models.FlatPage.url
176170
django.contrib.gis.admin.GISModelAdmin
177171
django.contrib.gis.admin.GISModelAdmin.gis_widget
178172
django.contrib.gis.admin.ModelAdmin
179-
django.contrib.gis.admin.ModelAdmin.log_addition
180-
django.contrib.gis.admin.ModelAdmin.log_change
181-
django.contrib.gis.admin.ModelAdmin.log_deletion
182173
django.contrib.gis.admin.StackedInline
183174
django.contrib.gis.admin.TabularInline
184175
django.contrib.gis.admin.action

0 commit comments

Comments
 (0)