Fix process start/kill on windows

Author: atsamd21

package.json

@@ -10,7 +10,7 @@
   ],
   "scripts": {
     "prepare": "scripts/build_protobuf.sh",
-    "test": "node ./node_modules/.bin/jest --forceExit --detectOpenHandles",
+    "test": "jest --forceExit --detectOpenHandles",
     "eslint": "eslint .",
     "eslintfix": "eslint src/* --fix",
     "typedoc": "typedoc ./src/index.ts --entryPointStrategy expand src/ --exclude **/*.test.ts --excludePrivate"

src/HavenoClient.test.ts

@@ -3963,7 +3963,7 @@ async function initHaveno(ctx?: HavenodContext): Promise<HavenoClient> {
 
     // start haveno process using configured ports if available
     const cmd: string[] = [
-      "./haveno-daemon",
+      (process.platform === 'win32'? "haveno-daemon.bat" : "./haveno-daemon"),
       "--baseCurrencyNetwork", TestConfig.baseCurrencyNetwork,
       "--useLocalhostForP2P", TestConfig.baseCurrencyNetwork === BaseCurrencyNetwork.XMR_MAINNET ? "false" : "true", // TODO: disable for stagenet too
       "--useDevPrivilegeKeys", TestConfig.baseCurrencyNetwork === BaseCurrencyNetwork.XMR_LOCAL ? "true" : "false",

src/HavenoClient.ts

@@ -145,7 +145,7 @@ export default class HavenoClient {
         let daemon: HavenoClient | undefined = undefined;
 
         // start process
-        const childProcess = require('child_process').spawn(cmd[0], cmd.slice(1), {cwd: havenoPath});
+        const childProcess = require('child_process').spawn(cmd[0], cmd.slice(1), {cwd: havenoPath, shell: process.platform === 'win32'});
         childProcess.stdout.setEncoding('utf8');
         childProcess.stderr.setEncoding('utf8');
 

src/utils/HavenoUtils.ts

@@ -19,6 +19,7 @@ import assert from "assert";
 import console from "console";
 import Decimal from 'decimal.js';
 import { PaymentAccountForm, PaymentAccountFormField } from "../protobuf/pb_pb";
+import { exec } from "child_process";
 
 /**
  * Collection of utilities for working with Haveno.
@@ -88,7 +89,14 @@ export default class HavenoUtils {
     return new Promise(function(resolve, reject) {
       process.on("exit", function() { resolve(); });
       process.on("error", function(err: any) { reject(err); });
-      process.kill(signal ? signal : "SIGINT");
+
+      if (global.process.platform === 'win32') {
+        exec(`taskkill /PID ${process.pid} /T /F`, err => {
+          if (err) reject(err);
+        });
+      } else {
+        process.kill(signal ? signal : "SIGINT");
+      }
     });
   }