core: poll wallet pool txs on startup (#2186)

Author: woodser

core/src/main/java/haveno/core/trade/Trade.java

@@ -730,7 +730,7 @@ public void initialize(ProcessModelServiceProvider serviceProvider) {
                         if (isShutDownStarted) return;
                         if (xmrConnectionService.isConnected()) {
                             try {
-                                xmrWalletService.doPollWallet(true);
+                                xmrWalletService.doPollWallet();
                             } catch (Exception e) {
                                 // use default error handling
                             }
@@ -1905,7 +1905,7 @@ public void processBuyerPayout(String payoutTxId) {
         // poll the main wallet
         log.warn("Processing payout tx for {} {} by polling main wallet", getClass().getSimpleName(), getShortId());
         try {
-            xmrWalletService.doPollWallet(true);
+            xmrWalletService.doPollWallet();
         } catch (Exception e) {
             // use default error handling
         }

core/src/main/java/haveno/core/xmr/wallet/XmrWalletService.java

@@ -1366,7 +1366,7 @@ private void initMainWallet() {
                     // attempt to sync wallet on startup or open application without syncing
                     for (int i = 0; i < MAX_SYNC_ATTEMPTS; i++) {
                         try {
-                            doPollWallet(false);
+                            doPollWallet();
                             break;
                         } catch (Exception e) {
                             if (isShutDownStarted) return;
@@ -1922,11 +1922,11 @@ private void pollWallet() {
         synchronized (pollLock) {
             if (pollInProgress) return;
         }
-        doPollWallet(true);
+        doPollWallet();
     }
 
     @SuppressWarnings("unused")
-    public void doPollWallet(boolean getPoolTxs) {
+    public void doPollWallet() {
 
         // skip polling after wallet service initialized until all domain services are initialized
         if (isWalletServiceInitialized() && !HavenoUtils.isAllDomainServicesInitialized()) {
@@ -1995,9 +1995,7 @@ public void doPollWallet(boolean getPoolTxs) {
             synchronized (HavenoUtils.getDaemonLock()) {
                 if (lastPollTxsTimestamp == 0) lastPollTxsTimestamp = System.currentTimeMillis(); // set initial timestamp
                 try {
-                    MoneroTxQuery query = new MoneroTxQuery().setIncludeOutputs(true);
-                    if (!getPoolTxs) query.setInTxPool(false);
-                    cachedTxs = wallet.getTxs(query);
+                    cachedTxs = wallet.getTxs(new MoneroTxQuery().setIncludeOutputs(true));
                     lastPollTxsTimestamp = System.currentTimeMillis();
                 } catch (Exception e) { // fetch from pool can fail
                     if (!isShutDownStarted && wallet == sourceWallet) {