Merge pull request #55 from takker99/fix-ci

Run lint and format in CI

Author: hayd

.github/workflows/ci.yml

@@ -8,5 +8,10 @@ jobs:
       - uses: actions/checkout@v2
       - uses: denoland/setup-deno@v1
         with:
-          deno-version: 1.15.3
-      - run: deno test --allow-read --allow-write
+          deno-version: 1.17.3
+      - name: Check format
+        run: deno fmt --check
+      - name: Run lint
+        run: deno lint
+      - name: Run test
+        run: deno test --allow-read --allow-write

.github/workflows/udd.yml

@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: denoland/setup-deno@v1
         with:
-          deno-version: 1.15.3
+          deno-version: 1.17.3
       - name: Update dependencies
         run: |
           deno run -A https://deno.land/x/udd/main.ts deps.ts

main.ts

@@ -48,11 +48,11 @@ Optional arguments:
 
 function version() {
   // FIXME this might be kinda a hacky way to do it...
-  let u = new DenoLand(import.meta.url);
+  const u = new DenoLand(import.meta.url);
   try {
     console.log(u.version());
-  } catch (err) {
-    console.log(undefined);
+  } catch (e) {
+    console.error(e);
   }
 }
 
@@ -77,7 +77,7 @@ async function spawn(args: string[], cwd?: string): Promise<string> {
 }
 
 async function upgrade() {
-  let u = new DenoLand("https://deno.land/x/udd@0.x/main.ts");
+  const u = new DenoLand("https://deno.land/x/udd@0.x/main.ts");
   const latestVersion = (await u.all())[0];
   const url = u.at(latestVersion).url;
   console.log(url);

mod.ts

@@ -95,7 +95,7 @@ export class Udd {
 
     try {
       new Semver(url.version());
-    } catch (e) {
+    } catch (_) {
       // The version string is a non-semver string like a branch name.
       await this.progress.log(`Skip updating: ${url.url}`);
       return { initUrl, initVersion };

progress.ts

@@ -23,5 +23,5 @@ export class Progress {
 }
 
 export class SilentProgress extends Progress {
-  async log(msg: string) {}
+  async log(_: string) {}
 }

semver.ts

@@ -115,7 +115,7 @@ export function fragment(
     const s = new Semver(v || version);
     // we have to reverse this due to the way fragments work...
     return (other: Semver) => other._(t, s);
-  } catch (e) {
+  } catch (_) {
     throw new SyntaxError(`invalid semver version: ${v || version}`);
   }
 }

test.ts

@@ -1,12 +1,6 @@
 import { udd, UddOptions, UddResult } from "./mod.ts";
 import { RegistryCtor } from "./registry.ts";
-import {
-  assert,
-  assertEquals,
-  assertThrowsAsync,
-  FakeDenoLand,
-  FakeRegistry,
-} from "./test_deps.ts";
+import { assertEquals, FakeDenoLand, FakeRegistry } from "./test_deps.ts";
 
 async function testUdd(
   before: string,