Using impl class when configuring a provider

[jerrinot]

The guide says:

Finally, we need to specify the JCache provider in the application.properties file.
[...]
spring.cache.jcache.provider=com.hazelcast.cache.impl.HazelcastServerCachingProvider

The impl package inside a configuration makes me uneasy. Isnt there another way? If there isnt then please open a github issue against Hazelcast. Thank you!

[alparslanavci]

Starting with 4.x, when you call Caching.getCachingProvider("com.hazelcast.cache.HazelcastCachingProvider"), it returns the client provider by default since now the client classes are included within the Hazelcast package.

I guess that is why we need to specify com.hazelcast.cache.impl.HazelcastServerCachingProvider as the provider explicitly.

[pivovarit]

Shouldn't this be considered a bug then?

I was just trying passing com.hazelcast.cache.HazelcastCachingProvider as a provider, but it clearly doesn't work

[alparslanavci]

Yes, passing com.hazelcast.cache.HazelcastCachingProvider doesn't work. I talked to Vassilis about it, and I am not sure if it should be considered as a bug but we definitely need it to be mentioned in the 4.0 migration guide.

BTW, it also affects spring-boot's Hazelcast 4.0 upgrade.

[jerrinot]

yes. it's a bug. under no circumstances we should be encouraging users to touch .impl. classes.
If there is no other way then please open an issue against Hazelcast.

[pivovarit]

I'm actually reviewing the guide at the moment. Will figure out if there's some non-impl way of doing that.

[pivovarit]

Not only this seems to be the only way to make it work, but it's also quite commonly used:

https://github.com/search?q=spring.cache.jcache.provider%3Dcom.hazelcast.cache.impl.HazelcastServerCachingProvider+extension%3Aproperties&type=Code&ref=advsearch&l=&l=

[jerrinot]

oh boy, we are teaching people bad practices :(

[pivovarit]

Opened this one: hazelcast/hazelcast#17312

[pivovarit]

After the next Hazelcast release, we'll be able to replace usages of impl.* classes with public ones