Openrewrite Improvements (#709)

Apply OpenRewrite automated refactorings to this project, _already_
applied to `hazelcast-mono`.

- `Add missing @OverRide annotation`
   - hazelcast/hazelcast-mono#2879
- Enum values should be compared with `==`
   - hazelcast/hazelcast-mono#2884
- Use diamond operator
   - hazelcast/hazelcast-mono#2887
- Remove empty Javadoc parameters
   - hazelcast/hazelcast-mono#2888
- Replace `Collection` `.size() > 0` with !`isEmpty()`
   - hazelcast/hazelcast-mono#2889
- Make JUnit5 tests default visibility
   - hazelcast/hazelcast-mono#2893
- Combine semantically equal `catch` blocks
   - hazelcast/hazelcast-mono#3716

Author: JackPGreen

cluster-split-brain-protection/src/main/java/CustomSplitBrainProtectionFunction.java

@@ -23,7 +23,7 @@ public class CustomSplitBrainProtectionFunction implements SplitBrainProtectionF
     static final long HEARTBEAT_TOLERANCE_MILLIS = 3000;
     static final int SPLIT_BRAIN_PROTECTION_SIZE = 2;
 
-    private Map<Member, Long> lastHeartbeatReceived = new HashMap<Member, Long>();
+    private Map<Member, Long> lastHeartbeatReceived = new HashMap<>();
 
     @Override
     public void memberAdded(MembershipEvent membershipEvent) {

cluster-split-brain-protection/src/test/java/CustomSplitBrainProtectionFunctionTest.java

@@ -62,7 +62,7 @@ public void splitBrainProtectionAbsent_whenNotEnoughMembers() {
         splitBrainProtectionFunction.memberAdded(mockEvent(members.get(0)));
         splitBrainProtectionFunction.memberAdded(mockEvent(members.get(1)));
 
-        List<Member> splitCluster = new ArrayList<Member>();
+        List<Member> splitCluster = new ArrayList<>();
         splitCluster.add(members.get(0));
         assertFalse(splitBrainProtectionFunction.apply(splitCluster));
     }

demo/src/main/java/com/hazelcast/demo/AllTest.java

@@ -60,7 +60,7 @@ public final class AllTest {
 
     private final HazelcastInstance hazelcast;
     private final int nThreads;
-    private final List<Runnable> operations = new ArrayList<Runnable>();
+    private final List<Runnable> operations = new ArrayList<>();
     private final ExecutorService ex;
     private final Random random = new Random();
     private final AtomicInteger messagesReceived = new AtomicInteger(0);
@@ -256,9 +256,7 @@ private List<Runnable> loadMapOperations() {
             IMap map = hazelcast.getMap("myMap");
             try {
                 map.getAsync(random.nextInt(SIZE)).toCompletableFuture().get();
-            } catch (InterruptedException e) {
-                throw new RuntimeException(e);
-            } catch (ExecutionException e) {
+            } catch (InterruptedException | ExecutionException e) {
                 throw new RuntimeException(e);
             }
         }, 1);
@@ -344,9 +342,7 @@ private List<Runnable> loadMapOperations() {
             try {
                 map.putAsync(random.nextInt(SIZE), new Customer(random.nextInt(100), String.valueOf(random.nextInt(10000)))
                 ).toCompletableFuture().get();
-            } catch (InterruptedException e) {
-                throw new RuntimeException(e);
-            } catch (ExecutionException e) {
+            } catch (InterruptedException | ExecutionException e) {
                 throw new RuntimeException(e);
             }
         }, 5);

demo/src/main/java/com/hazelcast/demo/LongRunningTest.java

@@ -41,7 +41,7 @@ public final class LongRunningTest {
     private static final int STATS_SECONDS = 10;
     private static final Logger LOGGER = Logger.getLogger(LongRunningTest.class.getName());
 
-    private final List<TheNode> nodes = new CopyOnWriteArrayList<TheNode>();
+    private final List<TheNode> nodes = new CopyOnWriteArrayList<>();
     private final Random random;
     private int nodeIdGen;
     private int starts;
@@ -85,7 +85,7 @@ private void run() {
         Runtime.getRuntime().addShutdownHook(new Thread() {
             public void run() {
                 log("Shutting down " + nodes.size());
-                while (nodes.size() > 0) {
+                while (!nodes.isEmpty()) {
                     removeNode();
                 }
             }
@@ -251,8 +251,6 @@ public void run() {
                             Stats currentStats = stats.getAndReset();
                             logger.info("Cluster size: " + clusterSize + ", Operations per second: "
                                     + (currentStats.total() / STATS_SECONDS));
-                        } catch (HazelcastInstanceNotActiveException e) {
-                            throw new RuntimeException(e);
                         } catch (Exception e) {
                             throw new RuntimeException(e);
                         }

demo/src/main/java/com/hazelcast/demo/SimpleFunctionalMapTest.java

@@ -78,7 +78,7 @@ private static Object createValue() {
      * Map statistics class
      */
     private static class Stats {
-        Map<String, AtomicLong> mapStats = new ConcurrentHashMap<String, AtomicLong>(10);
+        Map<String, AtomicLong> mapStats = new ConcurrentHashMap<>(10);
 
         Stats() {
             mapStats.put("put", new AtomicLong(0));

demo/src/main/java/com/hazelcast/demo/SimpleMapTest.java

@@ -160,7 +160,7 @@ private void load(ExecutorService es) throws InterruptedException {
 
         final IMap<String, Object> map = instance.getMap(NAMESPACE);
         final Member thisMember = instance.getCluster().getLocalMember();
-        List<String> lsOwnedEntries = new LinkedList<String>();
+        List<String> lsOwnedEntries = new LinkedList<>();
         for (int i = 0; i < entryCount; i++) {
             final String key = String.valueOf(i);
             Partition partition = instance.getPartitionService().getPartition(key);

distributed-collections/itemlisteners/src/main/java/ItemListenerMember.java

@@ -14,10 +14,12 @@ public static void main(String[] args) {
     }
 
     private static class ItemListenerImpl<E> implements ItemListener<E> {
+        @Override
         public void itemAdded(ItemEvent<E> itemEvent) {
             System.out.println("Item added:" + itemEvent.getItem());
         }
 
+        @Override
         public void itemRemoved(ItemEvent<E> itemEvent) {
             System.out.println("Item removed:" + itemEvent.getItem());
         }

distributed-executor/basic-executor/src/main/java/EchoTask.java

@@ -8,6 +8,7 @@ public EchoTask(String msg) {
         this.msg = msg;
     }
 
+    @Override
     public void run() {
         try {
             Thread.sleep(5000);

distributed-executor/durable-executor-service/src/main/java/configuration/EchoTask.java

@@ -28,6 +28,7 @@ public class EchoTask implements Runnable, Serializable {
         this.msg = msg;
     }
 
+    @Override
     public void run() {
         sleepSeconds(5);
 

distributed-executor/executing-on-all-members/src/main/java/SumTask.java

@@ -9,10 +9,12 @@ public class SumTask implements Callable<Integer>, Serializable, HazelcastInstan
 
     private transient HazelcastInstance hz;
 
+    @Override
     public void setHazelcastInstance(HazelcastInstance hz) {
         this.hz = hz;
     }
 
+    @Override
     public Integer call() throws Exception {
         IMap<String, Integer> map = hz.getMap("map");
         int result = 0;