Skip to content

Commit d0f02b1

Browse files
committed
addressed James' feedback
1 parent 9e53e2f commit d0f02b1

File tree

3 files changed

+19
-17
lines changed

3 files changed

+19
-17
lines changed

testing/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ execution of a listener:
104104
}
105105
```
106106

107+
The test class this method is extracted from is [OrderServiceWithListenerTest](src/test/java/com/hazelcast/samples/testing/junit4/OrderServiceWithListenerTest.java).
108+
107109
### Testing streaming applications
108110

109111
Test streaming applications is also supported - this is done extending `JetTestSupport` (itself an extension

testing/src/test/java/com/hazelcast/samples/testing/samples/junit4/MyPipelineTest.java

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,25 +16,28 @@
1616
import static org.junit.Assert.assertEquals;
1717

1818
@RunWith(JUnit4.class)
19-
public class MyPipelineTest
20-
extends JetTestSupport {
19+
public class MyPipelineTest extends JetTestSupport {
2120

2221
@Test
2322
public void testSimplePipeline() {
2423
Config config = new Config();
2524
config.setJetConfig(new JetConfig().setEnabled(true));
2625

2726
HazelcastInstance instance = createHazelcastInstance(config);
28-
JetService jet = instance.getJet();
27+
try {
28+
JetService jet = instance.getJet();
2929

30-
Pipeline p = Pipeline.create();
31-
p.readFrom(TestSources.items(1, 2, 3)).writeTo(Sinks.list("out"));
30+
Pipeline p = Pipeline.create();
31+
p.readFrom(TestSources.items(1, 2, 3)).writeTo(Sinks.list("out"));
3232

33-
jet.newJob(p).join();
33+
jet.newJob(p).join();
3434

35-
IList<Integer> result = instance.getList("out");
36-
assertEquals(3, result.size());
37-
38-
instance.shutdown();
35+
IList<Integer> result = instance.getList("out");
36+
assertEquals(3, result.size());
37+
} finally {
38+
if (instance != null) {
39+
instance.shutdown();
40+
}
41+
}
3942
}
4043
}

testing/src/test/java/com/hazelcast/samples/testing/samples/junit5/MyClusterFailureTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public class MyClusterFailureTest {
2424
private HazelcastInstance member1;
2525
private HazelcastInstance member2;
2626
private MembershipListener mockListener;
27+
private TestHazelcastFactory factory;
2728

2829
private static Config getConfig(String v) {
2930
MemberAttributeConfig mAttr = new MemberAttributeConfig();
@@ -35,7 +36,7 @@ private static Config getConfig(String v) {
3536

3637
@BeforeEach
3738
void setupCluster() {
38-
TestHazelcastFactory factory = new TestHazelcastFactory(2);
39+
factory = new TestHazelcastFactory(2);
3940
member1 = factory.newHazelcastInstance(getConfig("1"));
4041
member2 = factory.newHazelcastInstance(getConfig("2"));
4142

@@ -49,12 +50,8 @@ void setupCluster() {
4950

5051
@AfterEach
5152
void tearDownCluster() {
52-
client.shutdown();
53-
if (member1 != null) {
54-
member1.shutdown();
55-
}
56-
if (member2 != null) {
57-
member2.shutdown();
53+
if (factory != null) {
54+
factory.shutdownAll();
5855
}
5956
}
6057

0 commit comments

Comments
 (0)