Skip to content

Commit 0d1252b

Browse files
authored
Remove test-membership duplication (#1248)
The PR builder uses a local copy of an action which has [since been centralised](https://github.com/hazelcast/hazelcast-tpm/blob/main/membership/action.yaml). This was originally copied from the pattern in `hazelcast-nodejs-client` - but this has [since been migrated](https://github.com/hazelcast/hazelcast-nodejs-client/blob/master/.github/workflows/coverage_runner.yml#L16-L29). Updated to use centralise version - allowing a central place to make improvements.
1 parent 0d03241 commit 0d1252b

File tree

2 files changed

+2
-43
lines changed

2 files changed

+2
-43
lines changed

.github/actions/test-membership/action.yml

Lines changed: 0 additions & 32 deletions
This file was deleted.

.github/workflows/build-pr.yml

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,12 @@ jobs:
3939
name: Test Hazelcast Membership
4040
runs-on: ubuntu-latest
4141
outputs:
42-
is-hazelcast: ${{ steps.test-membership.outputs.is-member }}
42+
is-hazelcast: ${{ steps.test-membership.outputs.check-result }}
4343

4444
steps:
45-
# checkout the hazelcast/hazelcast-cpp-client repository
46-
# bare minimum - just to use actions
47-
- name: Checkout code
48-
uses: actions/checkout@v4
49-
with:
50-
ref: ${{ inputs.ref }}
51-
token: ${{ secrets.GH_TOKEN }}
52-
submodules: false
53-
5445
- name: Test
5546
id: test-membership
56-
uses: ./.github/actions/test-membership
47+
uses: hazelcast/hazelcast-tpm/membership@main
5748
with:
5849
organization-name: hazelcast
5950
member-name: ${{ github.actor }}

0 commit comments

Comments
 (0)