Skip to content

Commit 34f12fa

Browse files
committed
We need to suppress the Clang compiler warnings for known warnings in newer boost libraries even when the project uses C++14 as the language standard and if the warnings are treated as errors (Werror flag exists). Failing to do this causes compilation failure when using newest boost 1.90.0.
e.g.: ``` cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DBUILD_EXAMPLES=ON -DWITH_OPENSSL=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_TOOLCHAIN_FILE=/Users/ihsan/Desktop/work/src/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_MANIFEST_FEATURES='build-tests' "-DCMAKE_CXX_FLAGS=-Werror -m64 -Wall" -DCMAKE_INSTALL_PREFIX=/Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cpp_install -G "Unix Makefiles" -S /Users/ihsan/Desktop/work/src/hazelcast-cpp-client -B /Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cmake-build-arm-debug-vcpkg ``` Failures: ``` /Users/ihsan/Applications/CLion.app/Contents/bin/cmake/mac/aarch64/bin/cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DBUILD_EXAMPLES=ON -DWITH_OPENSSL=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_TOOLCHAIN_FILE=/Users/ihsan/Desktop/work/src/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_MANIFEST_FEATURES='build-tests' "-DCMAKE_CXX_FLAGS=-Werror -m64 -Wall" -DCMAKE_INSTALL_PREFIX=/Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cpp_install -G "Unix Makefiles" -S /Users/ihsan/Desktop/work/src/hazelcast-cpp-client -B /Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cmake-build-arm-debug-vcpkg ```
1 parent 904ee87 commit 34f12fa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ if (MSVC)
163163
endif ()
164164

165165
# AppleClang-specific compiler flags, we set for all targets since we want these flags also for tests and examples
166-
if (CMAKE_CXX_STANDARD EQUAL 11 AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
166+
if (CMAKE_CXX_FLAGS MATCHES "-Werror" AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
167167
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-enum-constexpr-conversion -Wno-deprecated-declarations -Wno-deprecated-builtins -Wno-unused-but-set-variable")
168168
endif ()
169169

0 commit comments

Comments
 (0)