Skip to content

Commit 5d6dec8

Browse files
authored
Fix install-thrift download errors on GitHub Runners (#1318)
Despite the changes in #1315, the downloads are [still failing](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16020766406/job/45197809787) on GitHub Runners. Specifically, the [mirror service doesn't _have_ a mirror of the specific version of `thrift` we want](https://www.apache.org/dyn/closer.cgi?path=/thrift/0.13.0/thrift-0.13.0.tar.gz): > The requested file or directory is not on the mirrors. The object is in our archive : https://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.tar.gz And it just redirects to `archive.apache.org` - which is what it was using originally. Updated to use an alternative mirror (Debian) and checked the checksums match (`38a27d391a2b03214b444cb13d5664f1`).
1 parent 5b11d0d commit 5d6dec8

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/actions/build-test/windows/action.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,11 @@ runs:
9999
name: Install Thrift
100100
shell: pwsh
101101
run: |
102+
# Ideally we would download directly from Apache:
103+
# https://www.apache.org/dyn/closer.lua/thrift/$1/thrift-$1.tar.gz?action=download
104+
# But this has intermittent failures in GitHub Actions
102105
Invoke-WebRequest `
103-
"https://www.apache.org/dyn/closer.lua/thrift/${{ inputs.THRIFT_VERSION }}/thrift-${{ inputs.THRIFT_VERSION }}.tar.gz?action=download" `
106+
"https://deb.debian.org/debian/pool/main/t/thrift/thrift_${{ inputs.THRIFT_VERSION }}.orig.tar.gz" `
104107
-OutFile "thrift-${{ inputs.THRIFT_VERSION }}.tar.gz"
105108
tar xzf thrift-${{ inputs.THRIFT_VERSION }}.tar.gz
106109
rm thrift-${{ inputs.THRIFT_VERSION }}.tar.gz

scripts/install-thrift.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ if [[ "$#" -ne 1 ]]; then
1010
exit 1
1111
fi
1212

13-
curl --fail --silent --show-error --location "https://www.apache.org/dyn/closer.lua/thrift/$1/thrift-$1.tar.gz?action=download" | tar xzf -
13+
# Ideally we would download directly from Apache:
14+
# https://www.apache.org/dyn/closer.lua/thrift/$1/thrift-$1.tar.gz?action=download
15+
# But this has intermittent failures in GitHub Actions
16+
curl --fail --silent --show-error --location "https://deb.debian.org/debian/pool/main/t/thrift/thrift_$1.orig.tar.gz" | tar xzf -
1417
pushd thrift-$1/build
1518
cmake .. -DBUILD_COMPILER=OFF -DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF -DBUILD_LIBRARIES=ON \
1619
-DBUILD_CPP=ON -DBUILD_AS3=OFF -DBUILD_C_GLIB=OFF -DBUILD_JAVA=OFF -DBUILD_PYTHON=OFF \

0 commit comments

Comments
 (0)