Fix pedantic warnings for cleaning up (#1134)

Co-authored-by: Ali Keles <[email protected]>

Author: cngzhnp

hazelcast/include/hazelcast/client/internal/nearcache/NearCacheManager.h

@@ -60,7 +60,7 @@ class HAZELCAST_API NearCacheManager
     {
         return std::static_pointer_cast<NearCache<KS, V>>(
           near_cache_map_.get(name));
-    };
+    }
 
     /**
      * Creates a new {@link NearCache} with given configurations or returns

hazelcast/include/hazelcast/client/membership_listener.h

@@ -70,7 +70,7 @@ class HAZELCAST_API membership_listener final
     {
         joined_ = std::forward<Handler>(h);
         return *this;
-    };
+    }
 
     /**
      * \copydoc membership_listener::on_joined
@@ -81,7 +81,7 @@ class HAZELCAST_API membership_listener final
     {
         on_joined(std::forward<Handler>(h));
         return std::move(*this);
-    };
+    }
 
     /**
      * Set an handler function to be invoked when an existing member leaves the
@@ -94,7 +94,7 @@ class HAZELCAST_API membership_listener final
     {
         left_ = std::forward<Handler>(h);
         return *this;
-    };
+    }
 
     /**
      * \copydoc membership_listener::on_left
@@ -105,7 +105,7 @@ class HAZELCAST_API membership_listener final
     {
         on_left(std::forward<Handler>(h));
         return std::move(*this);
-    };
+    }
 
     /**
      * Set an handler function to be invoked once when this listener is
@@ -118,7 +118,7 @@ class HAZELCAST_API membership_listener final
     {
         init_ = std::forward<Handler>(h);
         return *this;
-    };
+    }
 
     /**
      * \copydoc membership_listener::on_init
@@ -129,7 +129,7 @@ class HAZELCAST_API membership_listener final
     {
         on_init(std::forward<Handler>(h));
         return std::move(*this);
-    };
+    }
 
 private:
     using handler_t = std::function<void(const membership_event&)>;

hazelcast/include/hazelcast/client/proxy/RingbufferImpl.h

@@ -77,7 +77,6 @@ class HAZELCAST_API RingbufferImpl : public PartitionSpecificClientProxy
 {
 public:
     static constexpr const char* SERVICE_NAME = "hz:impl:ringbufferService";
-    ;
 
     /**
      * The maximum number of items that can be retrieved in 1 go using the

hazelcast/include/hazelcast/client/serialization/pimpl/data.h

@@ -117,7 +117,6 @@ struct HAZELCAST_API
       const std::shared_ptr<hazelcast::client::serialization::pimpl::data>& lhs,
       const std::shared_ptr<hazelcast::client::serialization::pimpl::data>& rhs)
       const noexcept;
-    ;
 };
 
 template<>

hazelcast/include/hazelcast/client/serialization/serialization.h

@@ -1363,7 +1363,7 @@ class HAZELCAST_API ClassDefinitionWriter
         std::shared_ptr<ClassDefinition> nestedClassDef =
           create_nested_class_def(*portable);
         builder_.add_portable_field(field_name, nestedClassDef);
-    };
+    }
 
     template<typename T>
     void write_portable_array(const std::string& field_name,
@@ -1378,7 +1378,7 @@ class HAZELCAST_API ClassDefinitionWriter
         std::shared_ptr<ClassDefinition> nestedClassDef =
           create_nested_class_def((*portables)[0]);
         builder_.add_portable_array_field(field_name, nestedClassDef);
-    };
+    }
 
     std::shared_ptr<ClassDefinition> register_and_get();