Fix PR Builder failing to start (#1231)

The PR builder [is failing to even start the
tests](#1222)
due to remote controller now requiring Java 17.

This is non-trivial to fix, as several other things have _also_ broken
in the meantime.

### Force-merge required:
`.github/workflows/build-pr.yml` is configured to use use
`pull_request_target`, rather than `pull_request` - to allow execution
of the action _on the target repository/branch_, allowing it's secrets
to be accessed.
The problem with this is what when these scripts contain an issue,
**even if modified in a PR, the _existing_ scripts will still be
executed** - meaning it's **impossible** to get the PR builder to pass,
whatever you modify.
As such, I've executed this PR in a branch (over a fork) and amended
this behavior, so that the execution of this PR build can be properly
observed in a [test run on a previous
revision](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/10506067493).
This PR will then require a force-merge.
Ideally this behaviour should change, but out-of-scope for this PR.

### Changes:
- Centralised configuration _where possible_
   - Java version
   - Java distribution
   - Hazelcast version
- Upgraded Java runtimes to Java 17
- Upgraded Hazelcast dependency from `5.3.0-SNAPSHOT` to `5.3.0`
   - the `SNAPSHOT` is no longer available
- this is the nearest (although now outdated) direct replacement (can
and should be upgraded -
[separately](#1225))
- Explicitly install the right Java / Maven versions on the runners, in
favour of the bundled (outdated) versions
- Refactor use of `maven-dependency-plugin` to specify a version
- Currently implicitly uses the version bundled with Maven - but this
has broken following Maven upgrade
- Picks a version (not the latest!) that supports a custom download
destination and a custom repository _simultaneously_
- Fix permissions issue installing `boost` on OSX
- Fix `error: unqualified call to 'std::move'` by qualifying call

Fixes: #1222,
#1229,
#1207,
#1226

---------

Co-authored-by: ihsan <[email protected]>

Author: JackPGreen

.github/config.env

@@ -0,0 +1,4 @@
+JAVA_VERSION=17
+JAVA_DISTRIBUTION=temurin
+MAVEN_VERSION=3.9.9
+HAZELCAST_VERSION=5.3.0

.github/workflows/build-pr.yml

@@ -113,19 +113,29 @@ jobs:
           ref: ${{ needs.get-refs.outputs.ref }}
           token: ${{ secrets.GH_TOKEN }}
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Install Necessary Packages
         run: |
           sudo apt-get update
           sudo apt-get install -y net-tools libssl-dev gdb gcovr curl          
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
       - name: Install Boost
         run: |
           sudo ./scripts/install-boost.sh ${{ env.boost_version }}
       - name: Install Thrift
         run: |
           sudo ./scripts/install-thrift.sh ${{ env.thrift_version }}
+  
+      - name: Setup JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: ${{ env.JAVA_DISTRIBUTION }}
+
       - name: Build
         env:
           BUILD_DIR: build
@@ -197,10 +207,23 @@ jobs:
     name: ubuntu-i386-(${{ matrix.build_type.type }}, ${{ matrix.shared_libs.name }}, ${{ matrix.with_openssl.name }})
 
     steps:
+      - name: Checkout Code
+        uses: actions/checkout@v1
+        with:
+          ref: ${{ needs.get-refs.outputs.ref }}
+          token: ${{ secrets.GH_TOKEN }}
+
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
+      # Install Java via `apt`, can't use the `setup-java` action on this image
+      # `setup-java` is written in TypeScript and requires a compatible Node installation
+      # Newest available version for this image is Node 8, which is too old for any version to run against
+      # https://github.com/actions/setup-node/issues/922
       - name: Install Necessary Packages
         run: |
           apt-get update
-          apt-get install -y build-essential cmake curl git libssl-dev maven net-tools openjdk-11-jre-headless gdb curl
+          apt-get install -y build-essential cmake curl git libssl-dev net-tools openjdk-${{ env.JAVA_VERSION }}-jre-headless gdb curl
 
       - name: Make sure the target architecture is 32 bit
         run: |
@@ -215,9 +238,34 @@ jobs:
           ref: ${{ needs.get-refs.outputs.ref }}
           token: ${{ secrets.GH_TOKEN }}
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
+      # `apt-get` brings in `3.6` which is too old to be compatible with Java 17
+      - name: Install Maven
+        run: |
+          install_dir="/opt/maven"
+          mkdir ${install_dir}
+          curl \
+            --fail \
+            --silent \
+            --show-error \
+            --location \
+            https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/${{ env.MAVEN_VERSION }}/apache-maven-${{ env.MAVEN_VERSION }}-bin.tar.gz | 
+          tar \
+            --extract \
+            --gzip \
+            --strip-components=1 \
+            --directory ${install_dir}
+          echo "${install_dir}/bin" >> $GITHUB_PATH
+
+      - name: Test Maven
+        run: |
+          mvn --version
+
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Install Boost
         run: |
@@ -295,9 +343,12 @@ jobs:
           ref: ${{ needs.get-refs.outputs.ref }}
           token: ${{ secrets.GH_TOKEN }}
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Install Boost
         run: |
@@ -306,6 +357,12 @@ jobs:
       - name: Install Thrift
         run: |
           sudo ./scripts/install-thrift.sh ${{env.thrift_version}}
+  
+      - name: Setup JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: ${{ env.JAVA_DISTRIBUTION }}
 
       - name: Build & Install
         env:
@@ -372,11 +429,15 @@ jobs:
           ref: ${{ needs.get-refs.outputs.ref }}
           token: ${{ secrets.GH_TOKEN }}
 
+      - name: Read Config
+        shell: bash
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Download hazelcast-enterprise-tests.jar
         shell: pwsh
         run: |
           [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
-          Invoke-WebRequest https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar -Headers @{"Authorization"="token ${{ secrets.GH_TOKEN }}"} -OutFile hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          Invoke-WebRequest https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar -Headers @{"Authorization"="token ${{ secrets.GH_TOKEN }}"} -OutFile hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
       - name: Install SysInternals
         run: |
             Invoke-WebRequest `
@@ -427,6 +488,13 @@ jobs:
           mkdir C:\Thrift\bin
           cd ../..
           Remove-Item thrift-0.13.0 -Recurse -Force
+  
+      - name: Setup JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: ${{ env.JAVA_DISTRIBUTION }}
+
       - name: Build & Install
         env:
           BUILD_DIR: build
@@ -489,7 +557,7 @@ jobs:
 
     runs-on: macos-latest
 
-    name: macOS-(${{ matrix.build_type.type }}, ${{ matrix.shared_libs.name }} ,${{ matrix.with_openssl.name }})
+    name: macOS-(${{ matrix.build_type.type }}, ${{ matrix.shared_libs.name }}, ${{ matrix.with_openssl.name }})
     env:
       OPENSSL_ROOT_DIR: /usr/local/opt/openssl/
 
@@ -499,13 +567,23 @@ jobs:
           ref: ${{ needs.get-refs.outputs.ref }}
           token: ${{ secrets.GH_TOKEN }}
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Install Dependencies
         run: |
           brew install [email protected] thrift curl
-          ./scripts/install-boost.sh ${{env.boost_version}}
+          sudo ./scripts/install-boost.sh ${{env.boost_version}}
+  
+      - name: Setup JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: ${{ env.JAVA_DISTRIBUTION }}
+    
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Build & Install
         env:

.github/workflows/coverage-report.yaml

@@ -14,14 +14,17 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v2
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Install Necessary Packages
         run: |
           sudo apt-get update
           sudo apt-get install -y net-tools libssl-dev gdb gcovr curl
 
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Install Boost
         run: |

.github/workflows/nightly-macos-x86_64.yml

@@ -49,14 +49,17 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Install Dependencies
         run: |
           brew install [email protected] thrift curl
           ./scripts/install-boost.sh ${{matrix.boost.version}}
 
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Build & Install
         env:

.github/workflows/nightly-ubuntu-i386.yml

@@ -46,10 +46,19 @@ jobs:
       (${{ matrix.build_type.type }}, ${{ matrix.shared_libs.name }}, ${{matrix.boost.version}},${{ matrix.with_openssl.name }})
 
     steps:
+      - uses: actions/checkout@v1
+
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
+      # Install Java via `apt`, can't use the `setup-java` action on this image
+      # `setup-java` is written in TypeScript and requires a compatible Node installation
+      # Newest available version for this image is Node 8, which is too old for any version to run against
+      # https://github.com/actions/setup-node/issues/922
       - name: Install Necessary Packages
         run: |
           apt-get update
-          apt-get install -y build-essential cmake curl git libssl-dev maven net-tools openjdk-11-jre-headless gdb curl
+          apt-get install -y build-essential cmake curl git libssl-dev maven net-tools openjdk-${{ env.JAVA_VERSION }}-jre-headless gdb curl
 
       - name: Make sure the target architecture is 32 bit
         run: |
@@ -58,11 +67,31 @@ jobs:
           ./a
           rm a test.c
 
-      - uses: actions/checkout@v1
+      # `apt-get` brings in `3.6` which is too old to be compatible with Java 17
+      - name: Install Maven
+        run: |
+          install_dir="/opt/maven"
+          mkdir ${install_dir}
+          curl \
+            --fail \
+            --silent \
+            --show-error \
+            --location \
+            https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/${{ env.MAVEN_VERSION }}/apa${{ env.MAVEN_VERSION }}n_version}-bin.tar.gz | 
+          tar \
+            --extract \
+            --gzip \
+            --strip-components=1 \
+            --directory ${install_dir}
+          echo "${install_dir}/bin" >> $GITHUB_PATH
+
+      - name: Test Maven
+        run: |
+          mvn --version
 
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Install Boost
         run: |

.github/workflows/nightly-ubuntu-x86_64.yml

@@ -51,9 +51,12 @@ jobs:
 
       - uses: actions/checkout@v2
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Download hazelcast-enterprise-tests.jar
         run: |
-          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          curl -H "Authorization: token ${{ secrets.GH_TOKEN }}" https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Install Boost
         run: |

.github/workflows/nightly-windows.yml

@@ -77,11 +77,14 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
+      - name: Read Config
+        run: cat .github/config.env >> $GITHUB_ENV
+
       - name: Download hazelcast-enterprise-tests.jar
         shell: pwsh
         run: |
           [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
-          Invoke-WebRequest https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar -Headers @{"Authorization"="token ${{ secrets.GH_TOKEN }}"} -OutFile hazelcast-enterprise-5.3.0-SNAPSHOT-tests.jar
+          Invoke-WebRequest https://raw.githubusercontent.com/hazelcast/private-test-artifacts/data/certs.jar -Headers @{"Authorization"="token ${{ secrets.GH_TOKEN }}"} -OutFile hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
 
       - name: Install SysInternals
         run: |

hazelcast/include/hazelcast/client/protocol/ClientMessage.h

@@ -952,7 +952,7 @@ class HAZELCAST_API ClientMessage
 
         fast_forward_to_end_frame();
 
-        return schema{ type_name, move(fields) };
+        return schema{ type_name, std::move(fields) };
     }
 
     /**

hazelcast/include/hazelcast/client/serialization/generic_record_builder.h

@@ -1520,7 +1520,7 @@ class HAZELCAST_API generic_record_builder
             pimpl::schema_writer& writer =
               boost::get<pimpl::schema_writer>(writer_or_schema_);
 
-            writer.add_field(move(field_name), kind);
+            writer.add_field(std::move(field_name), kind);
         }
 
         return *this;

hazelcast/include/hazelcast/client/serialization/serialization.h

@@ -1858,7 +1858,7 @@ class HAZELCAST_API SerializationService : public util::Disposable
         output.write_object<T>(object);
 
         return { std::move(output).to_byte_array(),
-                 move(output.schemas_will_be_replicated_) };
+                 std::move(output.schemas_will_be_replicated_) };
     }
 
     template<typename T>
@@ -1876,7 +1876,7 @@ class HAZELCAST_API SerializationService : public util::Disposable
         output.write_object<T>(object);
 
         return { std::move(output).to_byte_array(),
-                 move(output.schemas_will_be_replicated_) };
+                 std::move(output.schemas_will_be_replicated_) };
     }
 
     template<typename T>