Skip to content

Commit f6da0a0

Browse files
authored
Fix Ubuntu i386 nightly tests (#1266)
The action [has been failing for a while](https://github.com/hazelcast/hazelcast-cpp-client/actions/workflows/nightly-ubuntu-i386.yml) and I have identified a couple of issues: - #1239 introduced an implicit dependency on Node 20 - incompatible with Ubuntu i386 - #1260 introduced a dependency on `gh` which is pre-installed on GitHub Actions runner images... but the `ubuntu-i386` variant doesn't _use_ the runner image and instead runs on a vanilla Docker image and as such we must explicitly install `gh` as a prerequisite. - #1243 erroneously updated the i386 nightly build to use the **x64** variant Tested [here](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/13507682122) ✅.
1 parent 478074a commit f6da0a0

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

.github/actions/build-test/ubuntu-i386/action.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,19 @@ runs:
7575
--directory ${install_dir}
7676
echo "${install_dir}/bin" >> $GITHUB_PATH
7777
78+
- name: Install `gh` CLI
79+
shell: ${{ env.shell }}
80+
run: |
81+
# https://github.com/cli/cli/blob/trunk/docs/install_linux.md#debian-ubuntu-linux-raspberry-pi-os-apt
82+
(type -p wget >/dev/null || (apt update && apt-get install wget -y)) \
83+
&& mkdir -p -m 755 /etc/apt/keyrings \
84+
&& out=$(mktemp) && wget -nv -O$out https://cli.github.com/packages/githubcli-archive-keyring.gpg \
85+
&& cat $out | tee /etc/apt/keyrings/githubcli-archive-keyring.gpg > /dev/null \
86+
&& chmod go+r /etc/apt/keyrings/githubcli-archive-keyring.gpg \
87+
&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null \
88+
&& apt update \
89+
&& apt install gh -y
90+
7891
- name: Install Boost
7992
shell: ${{ env.shell }}
8093
run: |

.github/workflows/nightly-ubuntu-i386.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,10 @@ jobs:
4646
(${{ matrix.build_type.type }}, ${{ matrix.shared_libs.name }}, ${{matrix.boost.version}},${{ matrix.with_openssl.name }})
4747
4848
steps:
49-
- uses: actions/checkout@v4
49+
# Deliberately uses an old version because i386 is stuck on an outdated version of Javascript
50+
- uses: actions/checkout@v1
5051

51-
- uses: ./.github/actions/build-test/ubuntu-x86_64
52+
- uses: ./.github/actions/build-test/ubuntu-i386
5253
with:
5354
GH_TOKEN: ${{ secrets.GH_TOKEN }}
5455
BOOST_VERSION: ${{ matrix.boost.version }}

0 commit comments

Comments
 (0)