Skip to content

Reverted #1389 - vcpkg.json boost version back to 1.89.0 #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ihsandemir merged 2 commits into from
Jan 16, 2026
Merged

Reverted #1389 - vcpkg.json boost version back to 1.89.0 #1396

ihsandemir merged 2 commits into from
Jan 16, 2026

Conversation

@ihsandemir
Copy link
Collaborator

@ihsandemir ihsandemir commented Jan 15, 2026 •
edited
Loading

Reverted #1389 changes.

Changed vcpkg.json boost version to 1.89.0. Failing to do this causes project build using manifest mode vcpkg.json. e.g.

PR #1389 caused the problem.

cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DBUILD_EXAMPLES=ON -DWITH_OPENSSL=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_TOOLCHAIN_FILE=/Users/ihsan/Desktop/work/src/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_MANIFEST_FEATURES='build-tests' "-DCMAKE_CXX_FLAGS=-Werror -m64 -Wall" -DCMAKE_INSTALL_PREFIX=/Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cpp_install -G "Unix Makefiles" -S /Users/ihsan/Desktop/work/src/hazelcast-cpp-client -B /Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cmake-build-arm-debug-vcpkg

The failure was:

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: /Users/ihsan/Desktop/work/src/vcpkg/downloads/tools/ninja-1.13.2-osx/ninja -v
    Working Directory: /Users/ihsan/Desktop/work/src/vcpkg/buildtrees/boost-locale/arm64-osx-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      /Users/ihsan/Desktop/work/src/vcpkg/buildtrees/boost-locale/config-arm64-osx-dbg-CMakeCache.txt.log
      /Users/ihsan/Desktop/work/src/vcpkg/buildtrees/boost-locale/config-arm64-osx-rel-CMakeCache.txt.log
      /Users/ihsan/Desktop/work/src/vcpkg/buildtrees/boost-locale/config-arm64-osx-dbg-CMakeConfigureLog.yaml.log
      /Users/ihsan/Desktop/work/src/vcpkg/buildtrees/boost-locale/config-arm64-osx-rel-CMakeConfigureLog.yaml.log
      /Users/ihsan/Desktop/work/src/vcpkg/buildtrees/boost-locale/config-arm64-osx-out.log

...

vcpkg/buildtrees/boost-locale/config-arm64-osx-out.log:

CMake Error at /Users/ihsan/Desktop/work/src/vcpkg/scripts/buildsystems/vcpkg.cmake:908 (_find_package):
  Could not find a configuration file for package "boost_charconv" that
  exactly matches requested version "1.90.0".

@ihsandemir ihsandemir added this to the 5.6.0 milestone Jan 15, 2026
@ihsandemir ihsandemir requested a review from JackPGreen January 15, 2026 09:30
@ihsandemir ihsandemir self-assigned this Jan 15, 2026
@JackPGreen
Copy link
Contributor

JackPGreen commented Jan 15, 2026

For my reference, this updates from the latest release (2025.12.12) to effectively master/nightly from the upstream repo.

Are we sure this is what we want to do?

@ihsandemir
Copy link
Collaborator Author

ihsandemir commented Jan 15, 2026

For my reference, this updates from the latest release (2025.12.12) to effectively master/nightly from the upstream repo.

Are we sure this is what we want to do?

We either do this or revert back the change at the PR #1389

@JackPGreen
Copy link
Contributor

JackPGreen commented Jan 15, 2026

We either do this or revert back the change at the PR #1389

I think reverting would be safer. We can then add it back in when everythings ready?

@ihsandemir ihsandemir changed the title Update vcpkg.json baseline to reflect the boost update to 1.90.0 Reverted #1389 - vcpkg.json boost version back to 1.89.0 Jan 15, 2026
@ihsandemir
Copy link
Collaborator Author

ihsandemir commented Jan 15, 2026

We either do this or revert back the change at the PR #1389

I think reverting would be safer. We can then add it back in when everythings ready?

Done. Reverted.

@ihsandemir ihsandemir enabled auto-merge (squash) January 15, 2026 14:01
@ihsandemir ihsandemir merged commit 0a350fd into hazelcast:master Jan 16, 2026
31 checks passed
@ihsandemir ihsandemir deleted the vcpkg_baseline branch January 16, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackPGreen JackPGreen JackPGreen approved these changes

Assignees

@ihsandemir ihsandemir

Labels

Type: Enhancement

Projects

None yet

Milestone

5.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ihsandemir @JackPGreen