QFix: Handle Hulygram errors (#9637)

ArtyomSavchenko · web-flow · commit ede693adda6e · 2025-08-05T09:16:32.000+07:00
diff --git a/plugins/gmail-resources/src/components/Configure.svelte b/plugins/gmail-resources/src/components/Configure.svelte
@@ -48,10 +48,6 @@
   }
 
   async function change (shared: AccountUuid[]) {
-    const integrationClient = await getIntegrationClient()
-    integration = isWorkspaceIntegration(integration)
-      ? integration
-      : await integrationClient.integrate(integration, getCurrentWorkspaceUuid())
     if (integrationSettings == null) {
       console.error('Integrations settings are not found', integration.socialId, integration.kind)
       return
diff --git a/plugins/telegram-assets/lang/cs.json b/plugins/telegram-assets/lang/cs.json
@@ -93,6 +93,8 @@
     "NoChannelsAvailable": "Nejsou dostupné žádné kanály",
     "EnableSyncToConfigure": "Povolit synchronizaci pro konfiguraci přístupu kanálu",
     "AccessCannotBeChanged": "Přístup nelze změnit pro existující kanál",
-    "ServiceIsUnavailable": "Služba Telegram není k dispozici"
+    "ServiceIsUnavailable": "Služba Telegram není k dispozici",
+    "IncorrectPhoneOrCode": "Nepodařilo se připojit účet Telegram, zkontrolujte, zda je telefonní číslo a kód zadán správně",
+    "UnknownError": "Došlo k neznámé chybě v Telegram službě"
   }
 }
diff --git a/plugins/telegram-assets/lang/de.json b/plugins/telegram-assets/lang/de.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "Keine Kanäle verfügbar",
     "EnableSyncToConfigure": "Aktivieren Sie die Synchronisierung, um den Kanalzugriff zu konfigurieren",
     "AccessCannotBeChanged": "Der Zugriff kann für vorhandene Kanäle nicht geändert werden",
-    "ServiceIsUnavailable": "Telegram-Dienst ist nicht verfügbar"
+    "ServiceIsUnavailable": "Telegram-Dienst ist nicht verfügbar",
+    "IncorrectPhoneOrCode": "Es konnte kein Telegram-Konto verbunden werden, bitte überprüfen Sie, ob die Telefonnummer und der Code korrekt eingegeben wurden",
+    "UnknownError": "Es ist ein unbekannter Fehler im Telegram-Dienst aufgetreten"
   }
 }
diff --git a/plugins/telegram-assets/lang/en.json b/plugins/telegram-assets/lang/en.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "No channels available",
     "EnableSyncToConfigure": "Enable synchronization to configure channel access",
     "AccessCannotBeChanged": "Access cannot be changed for existing channel",
-    "ServiceIsUnavailable": "Telegram service is not available"
+    "ServiceIsUnavailable": "Telegram service is not available",
+    "IncorrectPhoneOrCode": "Failed to connect Telegram account, please check that the phone number and code are entered correctly",
+    "UnknownError": "An unknown error occurred in the Telegram service"
   }
 }
diff --git a/plugins/telegram-assets/lang/es.json b/plugins/telegram-assets/lang/es.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "No hay canales disponibles",
     "EnableSyncToConfigure": "Habilitar sincronización para configurar el acceso al canal",
     "AccessCannotBeChanged": "El acceso no se puede cambiar para el canal existente",
-    "ServiceIsUnavailable": "El servicio de Telegram no está disponible"
+    "ServiceIsUnavailable": "El servicio de Telegram no está disponible",
+    "IncorrectPhoneOrCode": "No se pudo conectar la cuenta de Telegram, verifique que el número de teléfono y el código se ingresen correctamente",
+    "UnknownError": "Se produjo un error desconocido en el servicio de Telegram"
   }
 }
diff --git a/plugins/telegram-assets/lang/fr.json b/plugins/telegram-assets/lang/fr.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "Aucun canal disponible",
     "EnableSyncToConfigure": "Activer la synchronisation pour configurer l'accès au canal",
     "AccessCannotBeChanged": "L'accès ne peut pas être modifié pour le canal existant",
-    "ServiceIsUnavailable": "Le service Telegram n'est pas disponible"
+    "ServiceIsUnavailable": "Le service Telegram n'est pas disponible",
+    "IncorrectPhoneOrCode": "Échec de la connexion du compte Telegram, veuillez vérifier que le numéro de téléphone et le code sont correctement saisis",
+    "UnknownError": "Une erreur inconnue s'est produite dans le service Telegram"
   }
 }
diff --git a/plugins/telegram-assets/lang/it.json b/plugins/telegram-assets/lang/it.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "Nessun canale disponibile",
     "EnableSyncToConfigure": "Abilita sincronizzazione per configurare l'accesso al canale",
     "AccessCannotBeChanged": "L'accesso non può essere modificato per il canale esistente",
-    "ServiceIsUnavailable": "Il servizio Telegram non è disponibile"
+    "ServiceIsUnavailable": "Il servizio Telegram non è disponibile",
+    "IncorrectPhoneOrCode": "Impossibile connettere l'account Telegram, controlla che il numero di telefono e il codice siano inseriti correttamente",
+    "UnknownError": "Si è verificato un errore sconosciuto nel servizio Telegram"
   }
 }
diff --git a/plugins/telegram-assets/lang/ja.json b/plugins/telegram-assets/lang/ja.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "利用可能なチャンネルがありません",
     "EnableSyncToConfigure": "チャンネルアクセスを構成するには同期を有効にしてください",
     "AccessCannotBeChanged": "既存のチャンネルのアクセスは変更できません",
-    "ServiceIsUnavailable": "Telegramサービスは利用できません"
+    "ServiceIsUnavailable": "Telegramサービスは利用できません",
+    "IncorrectPhoneOrCode": "Telegramアカウントの接続に失敗しました。電話番号とコードが正しく入力されていることを確認してください。",
+    "UnknownError": "Telegramサービスで不明なエラーが発生しました"
   }
 }
diff --git a/plugins/telegram-assets/lang/pt.json b/plugins/telegram-assets/lang/pt.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "Nenhum canal disponível",
     "EnableSyncToConfigure": "Ativar sincronização para configurar o acesso ao canal",
     "AccessCannotBeChanged": "O acesso não pode ser alterado para o canal existente",
-    "ServiceIsUnavailable": "O serviço Telegram não está disponível"
+    "ServiceIsUnavailable": "O serviço Telegram não está disponível",
+    "IncorrectPhoneOrCode": "Falha ao conectar a conta do Telegram, verifique se o número de telefone e o código estão corretos",
+    "UnknownError": "Ocorreu um erro desconhecido no serviço Telegram"
   }
 }
diff --git a/plugins/telegram-assets/lang/ru.json b/plugins/telegram-assets/lang/ru.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "Каналы недоступны",
     "EnableSyncToConfigure": "Включите синхронизацию, чтобы настроить доступ к каналу",
     "AccessCannotBeChanged": "Доступ не может быть изменен для существующего канала",
-    "ServiceIsUnavailable": "Telegram сервис недоступен"
+    "ServiceIsUnavailable": "Telegram сервис недоступен",
+    "IncorrectPhoneOrCode": "Не удалось подключить Telegram аккаунт, проверьте что номер и код введены корректно",
+    "UnknownError": "Произошла неизвестная ошибка в Telegram сервисе"
   }
 }
diff --git a/plugins/telegram-assets/lang/zh.json b/plugins/telegram-assets/lang/zh.json
@@ -94,6 +94,8 @@
     "NoChannelsAvailable": "没有可用的频道",
     "EnableSyncToConfigure": "启用同步以配置频道访问权限",
     "AccessCannotBeChanged": "现有频道的访问权限无法更改",
-    "ServiceIsUnavailable": "Telegram 服务不可用"
+    "ServiceIsUnavailable": "Telegram 服务不可用",
+    "IncorrectPhoneOrCode": "无法连接 Telegram 账户，请检查电话号码和代码是否正确输入",
+    "UnknownError": "在 Telegram 服务中发生了未知错误"
   }
 }
diff --git a/plugins/telegram-resources/src/api.ts b/plugins/telegram-resources/src/api.ts
@@ -13,7 +13,7 @@
 //
 
 import { concatLink, type PersonId } from '@hcengineering/core'
-import { getMetadata } from '@hcengineering/platform'
+import platform, { getMetadata, PlatformError, Status, Severity } from '@hcengineering/platform'
 import telegram from './plugin'
 import presentation, { getCurrentWorkspaceUuid } from '@hcengineering/presentation'
 import login from '@hcengineering/login'
@@ -48,21 +48,46 @@ const url = getMetadata(telegram.metadata.TelegramURL) ?? ''
 async function _request (method: 'GET' | 'POST' | 'DELETE', path?: string, body?: any): Promise<any> {
   const base = concatLink(url, 'api/integrations')
 
-  const response = await fetch(concatLink(base, path ?? ''), {
-    method,
-    headers: {
-      Authorization: 'Bearer ' + getMetadata(presentation.metadata.Token),
-      'Content-Type': 'application/json'
-    },
-    ...(body !== undefined ? { body: JSON.stringify(body) } : {})
-  })
+  let response: Response
+  try {
+    response = await fetch(concatLink(base, path ?? ''), {
+      method,
+      headers: {
+        Authorization: 'Bearer ' + getMetadata(presentation.metadata.Token),
+        'Content-Type': 'application/json'
+      },
+      ...(body !== undefined ? { body: JSON.stringify(body) } : {})
+    })
+  } catch (err) {
+    throw new PlatformError(
+      new Status(Severity.ERROR, platform.status.ConnectionClosed, {
+        message: 'Network error occurred'
+      })
+    )
+  }
 
   if (response.status === 200) {
-    return await response.json()
+    try {
+      return await response.json()
+    } catch (err) {
+      throw new PlatformError(
+        new Status(Severity.ERROR, platform.status.BadRequest, {
+          message: 'Failed to parse response JSON'
+        })
+      )
+    }
   } else if (response.status === 202) {
     return undefined
+  } else if (response.status === 401) {
+    throw new PlatformError(new Status(Severity.ERROR, platform.status.Unauthorized, {}))
+  } else if (response.status === 403) {
+    throw new PlatformError(new Status(Severity.ERROR, platform.status.Forbidden, {}))
+  } else if (response.status === 404) {
+    throw new PlatformError(new Status(Severity.ERROR, platform.status.ResourceNotFound, { resource: path ?? '' }))
+  } else if (response.status >= 500) {
+    throw new PlatformError(new Status(Severity.ERROR, platform.status.InternalServerError, {}))
   } else {
-    throw new Error(`Unexpected response: ${response.status}`)
+    throw new PlatformError(new Status(Severity.ERROR, platform.status.BadRequest, { status: response.status }))
   }
 }
 
diff --git a/plugins/telegram-resources/src/components/Connect.svelte b/plugins/telegram-resources/src/components/Connect.svelte
@@ -13,7 +13,7 @@
 // limitations under the License.
 -->
 <script lang="ts">
-  import { IntlString } from '@hcengineering/platform'
+  import platform, { IntlString, PlatformError } from '@hcengineering/platform'
   import ui, { Button, EditBox, IconClose, Label, IconError } from '@hcengineering/ui'
   import { createEventDispatcher } from 'svelte'
   import PinPad from './PinPad.svelte'
@@ -68,11 +68,11 @@
         .then((i) => {
           integrationState = i
         })
-        .catch((error) => {
+        .catch((error: any) => {
           state = {
             mode: 'Error',
             hint: error.message,
-            errorLabel: getErrorLabel(error.message),
+            errorLabel: getErrorLabel(error),
             buttons: {
               primary: { label: ui.string.Ok, handler: close }
             }
@@ -81,10 +81,19 @@
     }
   }
 
-  function getErrorLabel (errorMessage: string): IntlString | undefined {
+  function getErrorLabel (error: any): IntlString | undefined {
+    if (error instanceof PlatformError) {
+      if (error.status.code === platform.status.Unauthorized || error.status.code === platform.status.Forbidden) {
+        return telegram.string.IncorrectPhoneOrCode
+      } else if (error.status.code === platform.status.ConnectionClosed) {
+        return telegram.string.ServiceIsUnavailable
+      }
+    }
+    const errorMessage: string = error.message ?? ''
     if (errorMessage.toLowerCase().includes('failed to fetch')) {
       return telegram.string.ServiceIsUnavailable
     }
+    return telegram.string.UnknownError
   }
 
   $: {
@@ -224,7 +233,7 @@
     {:else if state.mode === 'Authorized'}
       <Label label={telegram.string.IntegrationConnected} params={{ phone: state.hint }} />
     {:else if state.mode === 'Error'}
-      <div class="flex-row-center gap-3 pt-2">
+      <div class="flex-row-top flex-gap-1 gap-3 pt-2">
         <IconError size={'medium'} />
         {#if state.errorLabel !== undefined}
           <Label label={state.errorLabel} />
diff --git a/plugins/telegram-resources/src/plugin.ts b/plugins/telegram-resources/src/plugin.ts
@@ -87,7 +87,9 @@ export default mergeIds(telegramId, telegram, {
     NoChannelsAvailable: '' as IntlString,
     EnableSyncToConfigure: '' as IntlString,
     ServiceIsUnavailable: '' as IntlString,
-    AccessCannotBeChanged: '' as IntlString
+    AccessCannotBeChanged: '' as IntlString,
+    IncorrectPhoneOrCode: '' as IntlString,
+    UnknownError: '' as IntlString
   },
   component: {
     MessagePresenter: '' as AnyComponent

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,8 @@`
`93`	`93`	`"NoChannelsAvailable": "Nejsou dostupné žádné kanály",`
`94`	`94`	`"EnableSyncToConfigure": "Povolit synchronizaci pro konfiguraci přístupu kanálu",`
`95`	`95`	`"AccessCannotBeChanged": "Přístup nelze změnit pro existující kanál",`
`96`		`- "ServiceIsUnavailable": "Služba Telegram není k dispozici"`
	`96`	`+ "ServiceIsUnavailable": "Služba Telegram není k dispozici",`
	`97`	`+ "IncorrectPhoneOrCode": "Nepodařilo se připojit účet Telegram, zkontrolujte, zda je telefonní číslo a kód zadán správně",`
	`98`	`+ "UnknownError": "Došlo k neznámé chybě v Telegram službě"`
`97`	`99`	`}`
`98`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,8 @@`
`94`	`94`	`"NoChannelsAvailable": "Keine Kanäle verfügbar",`
`95`	`95`	`"EnableSyncToConfigure": "Aktivieren Sie die Synchronisierung, um den Kanalzugriff zu konfigurieren",`
`96`	`96`	`"AccessCannotBeChanged": "Der Zugriff kann für vorhandene Kanäle nicht geändert werden",`
`97`		`- "ServiceIsUnavailable": "Telegram-Dienst ist nicht verfügbar"`
	`97`	`+ "ServiceIsUnavailable": "Telegram-Dienst ist nicht verfügbar",`
	`98`	`+ "IncorrectPhoneOrCode": "Es konnte kein Telegram-Konto verbunden werden, bitte überprüfen Sie, ob die Telefonnummer und der Code korrekt eingegeben wurden",`
	`99`	`+ "UnknownError": "Es ist ein unbekannter Fehler im Telegram-Dienst aufgetreten"`
`98`	`100`	`}`
`99`	`101`	`}`