Skip to content

Commit 2715765

Browse files
author
Adam Argyle
committed
fixes bug when closing visbug
1 parent 6e144d7 commit 2715765

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

app/components/metatip/metatip.element.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class Metatip extends HTMLElement {
2727

2828
disconnectedCallback() {
2929
this.unobserve()
30-
this.hidePopover && this.hidePopover()()
30+
this.hidePopover && this.hidePopover()
3131
}
3232

3333
dispatchQuery(e) {

app/components/selection/distance.element.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export class Distance extends HTMLElement {
1313

1414
disconnectedCallback() {
1515
if (this.hasAttribute('popover'))
16-
this.hidePopover && this.hidePopover()()
16+
this.hidePopover && this.hidePopover()
1717
}
1818

1919
set position({line_model, node_label_id}) {

app/components/selection/gridlines.element.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ export class Gridlines extends HTMLElement {
1313
this.setAttribute('popover', 'manual')
1414
this.showPopover && this.showPopover()
1515
}
16-
16+
1717
disconnectedCallback() {
18-
this.hidePopover && this.hidePopover()()
18+
this.hidePopover && this.hidePopover()
1919
}
2020

2121
set position(boundingRect) {

app/components/selection/handles.element.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class Handles extends HTMLElement {
1919
}
2020

2121
disconnectedCallback() {
22-
if (this.hidePopover && this.hidePopover()) this.hidePopover && this.hidePopover()()
22+
if (this.hidePopover && this.hidePopover()) this.hidePopover && this.hidePopover()
2323
window.removeEventListener('resize', this.on_window_resize)
2424
}
2525

app/components/selection/label.element.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class Label extends HTMLElement {
2121
}
2222

2323
disconnectedCallback() {
24-
this.hidePopover && this.hidePopover()()
24+
this.hidePopover && this.hidePopover()
2525
$('a', this.$shadow).off('click mouseenter', this.dispatchQuery)
2626
window.removeEventListener('resize', this.on_resize)
2727
}
@@ -86,15 +86,15 @@ export class Label extends HTMLElement {
8686
detectOutsideViewport() {
8787
const hoverText = this.$shadow.firstElementChild.innerText.replace(/\s+/g, ' ')
8888
if (hoverText === 'body') return;
89-
89+
9090
const boundingBox = this.$shadow.firstElementChild.getBoundingClientRect()
91-
91+
9292
const currentStyle = window.getComputedStyle(this);
9393
const currentPosition = {
9494
top: currentStyle.getPropertyValue('--top').replace('px', ''),
9595
left: currentStyle.getPropertyValue('--left').replace('px', ''),
9696
}
97-
97+
9898
const originalPosition = {
9999
top: this.getAttribute('data-original-top'),
100100
left: this.getAttribute('data-original-left'),

app/components/vis-bug/vis-bug.element.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,13 @@ export default class VisBug extends HTMLElement {
129129
}
130130

131131
cleanup() {
132-
this.hidePopover && this.hidePopover()()
132+
this.hidePopover && this.hidePopover()
133133

134134
Array.from(document.body.children)
135135
.filter(node => node.nodeName.includes('VISBUG'))
136136
.forEach(el => el.remove())
137137

138-
this.teardown();
138+
this.teardown()
139139

140140
document.querySelectorAll('[data-pseudo-select=true]')
141141
.forEach(el =>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "VisBug",
3-
"version": "0.4.1",
3+
"version": "0.4.3",
44
"description": "",
55
"author": "Adam Argyle",
66
"license": "Apache-2.0",

0 commit comments

Comments
 (0)