Merge pull request #1402 from hcoles/feature/config_updater_verifier

introduce simple verifier for config updaters

Author: hcoles

pitest-entry/src/test/java/org/pitest/mutationtest/autoconfig/EnableAssertionsTest.java

@@ -1,13 +1,16 @@
 package org.pitest.mutationtest.autoconfig;
 
 import org.junit.Test;
+import org.pitest.mutationtest.config.ConfigUpdaterVerifier;
 import org.pitest.mutationtest.config.ReportOptions;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 public class EnableAssertionsTest {
     EnableAssertions underTest = new EnableAssertions();
 
+    ConfigUpdaterVerifier v = ConfigUpdaterVerifier.confirmFactory(underTest);
+
     @Test
     public void addsEAFlag() {
         ReportOptions data = new ReportOptions();
@@ -23,6 +26,11 @@ public void featureIsNamedAutoAssertions() {
 
     @Test
     public void featureIsOnByDefault() {
-        assertThat(underTest.provides().isOnByDefault()).isTrue();
+        v.isOnByDefault();
+    }
+
+    @Test
+    public void isOnChain() {
+        v.isOnChain();
     }
 }

pitest-entry/src/test/java/org/pitest/mutationtest/autoconfig/KeepMacOsFocusTest.java

@@ -1,6 +1,7 @@
 package org.pitest.mutationtest.autoconfig;
 
 import org.junit.Test;
+import org.pitest.mutationtest.config.ConfigUpdaterVerifier;
 import org.pitest.mutationtest.config.ReportOptions;
 import org.pitest.plugin.FeatureSetting;
 
@@ -9,6 +10,8 @@
 public class KeepMacOsFocusTest {
     KeepMacOsFocus underTest = new KeepMacOsFocus();
 
+    ConfigUpdaterVerifier v = ConfigUpdaterVerifier.confirmFactory(underTest);
+
     @Test
     public void addsHeadlessTrueToJvmArgs() {
         ReportOptions data = new ReportOptions();
@@ -18,16 +21,17 @@ public void addsHeadlessTrueToJvmArgs() {
     }
 
     @Test
-    public void featureIsNamedMacOsFocus() {
-        KeepMacOsFocus underTest = new KeepMacOsFocus();
+    public void isOnChain() {
+        v.isOnChain();
+    }
 
-        assertThat(underTest.provides().name()).isEqualTo("macos_focus");
+    @Test
+    public void featureIsNamedMacOsFocus() {
+        v.featureName().isEqualTo("macos_focus");
     }
 
     @Test
     public void featureIsOnByDefault() {
-        KeepMacOsFocus underTest = new KeepMacOsFocus();
-
-        assertThat(underTest.provides().isOnByDefault()).isTrue();
+       v.isOnByDefault();
     }
 }

pitest-entry/src/test/java/org/pitest/mutationtest/config/ConfigUpdaterVerifier.java

@@ -0,0 +1,44 @@
+package org.pitest.mutationtest.config;
+
+import org.assertj.core.api.AbstractStringAssert;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class ConfigUpdaterVerifier {
+    private final ConfigurationUpdater factory;
+
+    public ConfigUpdaterVerifier(ConfigurationUpdater factory) {
+        this.factory = factory;
+    }
+
+    public static ConfigUpdaterVerifier confirmFactory(ConfigurationUpdater factory) {
+        return new ConfigUpdaterVerifier(factory);
+    }
+
+    public void isOnChain() {
+        factoryIsOnChain(factory.getClass());
+    }
+
+    public void isOnByDefault() {
+        assertThat(factory.provides().isOnByDefault()).isTrue();
+    }
+
+    public void isOffByDefault() {
+        assertThat(factory.provides().isOnByDefault()).isFalse();
+    }
+
+    public AbstractStringAssert<?> featureName() {
+        return assertThat(factory.provides().name());
+    }
+
+    private static void factoryIsOnChain(Class<?> factory) {
+        List<Class<?>> allInterceptors = PluginServices.makeForContextLoader().findConfigurationUpdaters().stream()
+                .map(ConfigurationUpdater::getClass)
+                .collect(Collectors.toList());
+
+        assertThat(allInterceptors).contains(factory);
+    }
+
+}