Skip to content

Commit 10c57c5

Browse files
authored
Merge pull request #5 from hdarjus/copilot/update-full-text-references
Update citation references to published JMVA paper
2 parents 3f4a0e7 + c0f773a commit 10c57c5

File tree

9 files changed

+42
-30
lines changed

9 files changed

+42
-30
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Version: 0.1.0
55
Authors@R: c(
66
person("Darjus", "Hosszejni", role = c("aut", "cre"), email = "darjus.hosszejni@wu.ac.at", comment = c(ORCID = "0000-0002-3803-691X")),
77
person("Sylvia", "Frühwirth-Schnatter", role = c("ths"), email = "sylvia.fruehwirth-schnatter@wu.ac.at", comment = c(ORCID = "0000-0003-0516-5552")))
8-
Description: This is an implementation of the algorithm described in Section 3 of Hosszejni and Frühwirth-Schnatter (2022) <doi:10.48550/arXiv.2211.00671>. The algorithm is used to verify that the counting rule CR(r,1) holds for the sparsity pattern of the transpose of a factor loading matrix. As detailed in Section 2 of the same paper, if CR(r,1) holds, then the idiosyncratic variances are generically identified. If CR(r,1) does not hold, then we do not know whether the idiosyncratic variances are identified or not.
8+
Description: This is an implementation of the algorithm described in Section 3 of Hosszejni and Frühwirth-Schnatter (2026) <doi:10.1016/j.jmva.2025.105536>. The algorithm is used to verify that the counting rule CR(r,1) holds for the sparsity pattern of the transpose of a factor loading matrix. As detailed in Section 2 of the same paper, if CR(r,1) holds, then the idiosyncratic variances are generically identified. If CR(r,1) does not hold, then we do not know whether the idiosyncratic variances are identified or not.
99
License: GPL (>= 3)
1010
SystemRequirements: C++14
1111
Encoding: UTF-8

R/RcppExports.R

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#' Verify that the counting rule CR(r,1) holds
55
#'
66
#' This is an implementation of the algorithm described in Section 3 of
7-
#' Hosszejni and Fruehwirth-Schnatter (2022). The algorithm is used to verify
7+
#' Hosszejni and Fruehwirth-Schnatter (2026). The algorithm is used to verify
88
#' that the counting rule CR(r,1) holds for the sparsity pattern of the transpose
99
#' of a factor loading matrix. As detailed in Section 2 of the same paper, if
1010
#' CR(r,1) holds, then the idiosyncratic variances are generically identified.
@@ -17,9 +17,10 @@
1717
#' @keywords models multivariate
1818
#' @concept factor analysis variance identification
1919
#' @seealso [stats::factanal()]
20-
#' @references Hosszejni and Fruehwirth-Schnatter (2022). "Cover It Up! Bipartite
21-
#' Graphs Uncover Identifiability in Sparse Factor Analysis". arXiv:2211.00671.
22-
#' <doi:10.48550/arXiv.2211.00671>
20+
#' @references Hosszejni and Fruehwirth-Schnatter (2026). "Cover It Up! Bipartite
21+
#' Graphs Uncover Identifiability in Sparse Factor Analysis". Journal of
22+
#' Multivariate Analysis, 211, 105536. ISSN 0047-259X.
23+
#' <doi:10.1016/j.jmva.2025.105536>
2324
#' @example inst/examples/counting_rule_holds.R
2425
#' @export
2526
counting_rule_holds <- function(delta) {

README.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ knitr::opts_chunk$set(
1616
# Package `sparvaride`
1717

1818
The package implements the variance identification algorithm for sparse factor analysis described in the paper "Cover It Up! Bipartite Graphs Uncover Identifiability in Sparse Factor Analysis" by Darjus Hosszejni and Sylvia Frühwirth-Schnatter.
19-
The paper is available at [arXiv](https://arxiv.org/abs/2211.00671).
19+
The paper is published in the [Journal of Multivariate Analysis](https://doi.org/10.1016/j.jmva.2025.105536).
2020

2121
The package is still under development and the API is subject to change.
2222
For a Matlab implementation, see [`sparvaride-matlab`](https://github.com/hdarjus/sparvaride-matlab).

README.md

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
The package implements the variance identification algorithm for sparse
77
factor analysis described in the paper “Cover It Up\! Bipartite Graphs
88
Uncover Identifiability in Sparse Factor Analysis” by Darjus Hosszejni
9-
and Sylvia Frühwirth-Schnatter. The paper is available at
10-
[arXiv](https://arxiv.org/abs/2211.00671).
9+
and Sylvia Frühwirth-Schnatter. The paper is published in the [Journal
10+
of Multivariate
11+
Analysis](https://doi.org/10.1016/j.jmva.2025.105536).
1112

1213
The package is still under development and the API is subject to change.
1314
For a Matlab implementation, see [`sparvaride-matlab`](https://github.com/hdarjus/sparvaride-matlab).
@@ -75,18 +76,22 @@ citation("sparvaride")
7576
#>
7677
#> To cite sparvaride in publications use:
7778
#>
78-
#> Hosszejni D, Frühwirth-Schnatter S (2022). "Cover It Up! Bipartite
79-
#> Graphs Uncover Identifiability in Sparse Factor Analysis."
80-
#> doi:10.48550/arXiv.2211.00671
81-
#> <https://doi.org/10.48550/arXiv.2211.00671>, arXiv: 2211.00671.
79+
#> Hosszejni D, Frühwirth-Schnatter S (2026). "Cover It Up! Bipartite
80+
#> Graphs Uncover Identifiability in Sparse Factor Analysis." _Journal
81+
#> of Multivariate Analysis_, *211*, 105536. ISSN 0047-259X,
82+
#> doi:10.1016/j.jmva.2025.105536
83+
#> <https://doi.org/10.1016/j.jmva.2025.105536>.
8284
#>
8385
#> A BibTeX entry for LaTeX users is
8486
#>
85-
#> @Unpublished{,
87+
#> @Article{,
8688
#> title = {Cover It Up! Bipartite Graphs Uncover Identifiability in Sparse Factor Analysis},
8789
#> author = {Darjus Hosszejni and Sylvia Frühwirth-Schnatter},
88-
#> year = {2022},
89-
#> note = {arXiv: 2211.00671},
90-
#> doi = {10.48550/arXiv.2211.00671},
90+
#> journal = {Journal of Multivariate Analysis},
91+
#> year = {2026},
92+
#> volume = {211},
93+
#> pages = {105536},
94+
#> issn = {0047-259X},
95+
#> doi = {10.1016/j.jmva.2025.105536},
9196
#> }
9297
```

_codeql_detected_source_root

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.

inst/CITATION

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,20 @@ if(!exists("meta") || is.null(meta)) meta <- packageDescription("sparvaride")
55
year <- sub("-.*", "", meta$Packaged)
66
note <- sprintf("R package version %s", meta$Version)
77

8-
bibentry(bibtype = "unpublished",
8+
bibentry(bibtype = "article",
99
title = "Cover It Up! Bipartite Graphs Uncover Identifiability in Sparse Factor Analysis",
1010
author = c(person(given = "Darjus",
1111
family = "Hosszejni",
1212
email = "darjus.hosszejni@wu.ac.at"),
1313
person(given = "Sylvia",
1414
family = "Frühwirth-Schnatter",
1515
email = "sylvia.fruehwirth-schnatter@wu.ac.at")),
16-
year = "2022",
17-
note = "arXiv: 2211.00671",
18-
doi = "10.48550/arXiv.2211.00671",
16+
journal = "Journal of Multivariate Analysis",
17+
year = "2026",
18+
volume = "211",
19+
pages = "105536",
20+
issn = "0047-259X",
21+
doi = "10.1016/j.jmva.2025.105536",
1922
header = "To cite sparvaride in publications use:"
2023
)
2124

man/counting_rule_holds.Rd

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/check_counting_rule.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
//' Verify that the counting rule CR(r,1) holds
2828
//'
2929
//' This is an implementation of the algorithm described in Section 3 of
30-
//' Hosszejni and Fruehwirth-Schnatter (2022). The algorithm is used to verify
30+
//' Hosszejni and Fruehwirth-Schnatter (2026). The algorithm is used to verify
3131
//' that the counting rule CR(r,1) holds for the sparsity pattern of the transpose
3232
//' of a factor loading matrix. As detailed in Section 2 of the same paper, if
3333
//' CR(r,1) holds, then the idiosyncratic variances are generically identified.
@@ -40,9 +40,10 @@
4040
//' @keywords models multivariate
4141
//' @concept factor analysis variance identification
4242
//' @seealso [stats::factanal()]
43-
//' @references Hosszejni and Fruehwirth-Schnatter (2022). "Cover It Up! Bipartite
44-
//' Graphs Uncover Identifiability in Sparse Factor Analysis". arXiv:2211.00671.
45-
//' <doi:10.48550/arXiv.2211.00671>
43+
//' @references Hosszejni and Fruehwirth-Schnatter (2026). "Cover It Up! Bipartite
44+
//' Graphs Uncover Identifiability in Sparse Factor Analysis". Journal of
45+
//' Multivariate Analysis, 211, 105536. ISSN 0047-259X.
46+
//' <doi:10.1016/j.jmva.2025.105536>
4647
//' @example inst/examples/counting_rule_holds.R
4748
//' @export
4849
// [[Rcpp::export(name="counting_rule_holds", rng=false)]]

vignettes/short_intro.Rmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ knitr::opts_chunk$set(
1818

1919
This is a short introduction to the `sparvaride` package.
2020
The package implements the variance identification algorithm for sparse factor analysis described in the paper "Cover It Up! Bipartite Graphs Uncover Identifiability in Sparse Factor Analysis" by Darjus Hosszejni and Sylvia Frühwirth-Schnatter.
21-
The paper is available at [arXiv](https://arxiv.org/abs/2211.00671).
21+
The paper is published in the [Journal of Multivariate Analysis](https://doi.org/10.1016/j.jmva.2025.105536).
2222

2323
The package is still under development and the API is subject to change.
2424

@@ -34,7 +34,7 @@ For mathematical tractability, we assume orthogonal factors, i.e., $\text{cov}(f
3434

3535
In this setup, the covariance matrix $\text{cov}(\epsilon_i)$ of the idiosyncratic errors may not be uniquely identified if there are too many zeros in $\beta$ (and thus in $\delta$).
3636
The 3579 counting rule is a sufficient condition for the uniqueness of the covariance matrix $\text{cov}(\epsilon_i)$.
37-
More information on the 3579 counting rule can be found in the paper "Cover It Up! Bipartite Graphs Uncover Identifiability in Sparse Factor Analysis" by Darjus Hosszejni and Sylvia Frühwirth-Schnatter at [https://arxiv.org/abs/2211.00671](https://arxiv.org/abs/2211.00671).
37+
More information on the 3579 counting rule can be found in the paper "Cover It Up! Bipartite Graphs Uncover Identifiability in Sparse Factor Analysis" by Darjus Hosszejni and Sylvia Frühwirth-Schnatter at [https://doi.org/10.1016/j.jmva.2025.105536](https://doi.org/10.1016/j.jmva.2025.105536).
3838

3939
## The 3579 Counting Rule
4040

0 commit comments

Comments
 (0)